[transports] fix usage after free of transport info memory

spotted while implementing functional testing for rekey.

when configuring multiple hosts (3+) with 1 link sharing
the same listener, but NOT enabling the link, if the user
attempts to shutdown knet_h, the first call to knet_link_clear_config
will not recognize that the listener is still in use by another
link and will release all resources.
At the time of invoking clear_config on the second link, transport_clear_config
will access already freed memory, or alternatively, a call to
link_enable would cause a crash because the listener does no
longer exist.

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[tests] test rpm should match currently installed version of libknet

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

manpages: Document enums (#206)

And also fix a bug in structure printing that caused it to print the wrong name for a struct.

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[tests] allow shipping of the test suite

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[host] increase log level for currently used links

bug reported on IRC by yuanren

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[transport] don´t specify destination address for connection oriented protocols

some implementations of sendto/sendmsg expects dst_addr / msg_name to be
empty for connection oriented protocols such as SCTP (spotted on FreeBSD).

Make sure to clear or not pass those information on connection oriented protocol.

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[man] fix man page build dependency for BSD Make

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[tests] add ability to create ipv6 sockets

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[man] fix libnozzle man page generation target

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[tests] fix knet_bench help text

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

doxyxml: Don't crash if there's no doxygen stanza for a function

[man] add test to make sure all generated man pages are being shipped / installed

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

Merge pull request #183 from kronosnet/stable1-proposed

Stable1 proposed

[common] fix not reporting a true dlinfo error cause

This was automatically caught with GCC 9
("'%s' directive argument is null").

Signed-off-by: Jan Pokorný <jpokorny@redhat.com>

[libknet] allow better handling of internal threads

while playing around adding some dynamic internal threads, i did
hit a limitation with allocating a dynamic THREAD_MAX value based
on OS availability of certain features.

this patch changes from dynamic to static allocation of threads, that
can always be increased if necessary without breaking anything.

simplify thread numbering and conditionals on OS features

improve debugging of thread status by adding a 2 phase thread registration
process:

- register a thread before starting it with THREAD_REGISTERED before pthread_create
- set a thread status as started with THREAD_STARTED

any failure in between can now be detected in debugging logs.

Note for developers: all threads *MUST* be registered/started before
wait_all_threads_status check in handle.c.

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[build] enable all compilers warnings at once

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libknet] expose API version in libknet.h to make it easier for applications to add conditional builds

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

Skip SCTP event initialization if the protocol is not supported

We may not want to actually use SCTP after all, and if we do, we won't
get to use the uninitialized subscribe struct anyway.  Thus aborting
handle initialization is premature here.

Fix nozzle man dates to SOURCE_EPOCH, just like we fix the libknet ones

[rpm] ship libnozzle man pages

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

Fix typos

Install the nozzle man pages

Merge pull request #162 from kronosnet/stable1-proposed

stable1 proposed

[knet] fix build with older openssl versions

spotted on freebsd-devel

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[global] update notes to package maintainers

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

Tabify

Use the kernel struct size for SCTP event subscription

Signed-off-by: Ferenc Wágner <wferi@debian.org>

[libnozzle] fix variable assignment order

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[global] fix copyright across

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] add nozzle_get_ips tests and kill nozzle_test

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] add nozzle_del_ip tests

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] fix del_ip removal of Ipv6 addresses when MTU < 1280

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] add nozzle_add_ip tests

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] add api_nozzle_run_updown tests

and cleanup lots of craft around related to the old testing method
for the same API

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] add internal execute_bin_sh_command test

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] cleanup tests Makefile.am

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] add nozzle_get_fd test

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] add nozzle_get_name_by_handle test

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] add nozzle_get_handle_by_name tests

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] add nozzle_get_mac / nozzle_set_mac / nozzle_reset_mac tests

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] add nozzle_get_mtu / nozzle_set_mtu / nozzle_reset_mtu tests

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] move multi nozzle device test to api_nozzle_open

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] clean up code in set_up test

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] improve set_down test

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] add api_nozzle_set_(up|down) tests

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] drop unnecessary indirection to call set_down

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] drop redundant check

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] add api_nozzle_close_test

also, share more code in test-common, fix another BSD build issue

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] fix test suite build on BSD

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] add api_nozzle_open test

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] prepare Makefile.am to explode with API tests

also fix nozzle_test for using global compiler flags

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] fix API check paths

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] add per-API call test coverage check

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] re-instate error checking in nozzle_get_ips

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] add comment about BSD ip_add status

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] cleanup nozzle_get_ips public API

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] fix whitespaces

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[global] Update copyright across

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] Update copyright

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] fix build on BSD

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] remove error_string requirement from many API calls and mark them as final

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libtap] move nozzle_run_updown to completed section

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[tests] properly check symbols on PPC64

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[tests] remove debugging sleep()

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] enable libnl3 < 3.3 build workaround

fixes build on opensuse-42

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] Use libnl3.0 for ip address management on Linux

BSD will follow next using internal ioctls and drop usage of forking a shell

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] whitespace cleanup

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] expand buffers to deal with strncpy and -Werror=stringop-truncatio

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] drop duplicated code

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] enable libnozzle build by default

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] move man pages to top level dir

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] fix man page generation

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] propagate errors all the way

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] fix build on BSD

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] nozzle_open and nozzle_close should be stable now

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] move set up and down to the stable API section

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] decouple running pre-up.d/up.d/down.d/post-down.d from interface status (part 4)

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] decouple running pre-up.d/up.d/down.d/post-down.d from interface status (part 3)

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] decouple running pre-up.d/up.d/down.d/post-down.d from interface status (part 2)

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] decouple running pre-up.d/up.d/down.d/post-down.d from interface status (part 1)

provide the facility to do it via nozzle_run_updown but delegate the task to
the application.

This has the benefit of much better fine grained control over errors during those
code paths.

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] move find_ip to internals

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] move ipv4 broadcast to internals

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] cleanup mac address functions

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] move code around to reflect public API and internal functions

cleanup _get_mtu in the process

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] move code around to reflect completion and drop copy of code from internals.c

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] rename _check to is_valid_nozzle, make it more useful and fixup error code checking

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] be more explicit on function naming (part 2)

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] be more explicit on function naming

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] start cleaning internal function names

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] split code around to separate libnozzle and testsuite

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[build] split tests, man pages and build dirs

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] rename lib_mutex to config_mutex

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[build] fix build on BSD

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[cleanup] document nozzle_iface struct, drop unnecessary ifr struct and cleanup names

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[cleanup] rename ip_addr to ipaddr

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[cleanup] rename sockfd to ioctlfd

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[cleanup] rename struct _ip to struct nozzle_ip and cleanup related defines

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] rename _config to nozzle_lib_config

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[cleanup] start splitting the code across multiple files

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] cleanup and document nozzle_get_fd

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>