]>
git.proxmox.com Git - mirror_lxc.git/log
Christian Brauner [Mon, 15 Feb 2021 10:57:31 +0000 (11:57 +0100)]
cgroups: pass handler to cgroup mount() method
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 15 Feb 2021 10:55:33 +0000 (11:55 +0100)]
conf: don't pass conf separately to lxc_mount_auto_mounts()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 15 Feb 2021 10:47:53 +0000 (11:47 +0100)]
cgroups: move cgns_supported() to cgroup utilities
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Sun, 14 Feb 2021 20:38:58 +0000 (15:38 -0500)]
Merge pull request #3672 from brauner/2021-02-14/fixes
start: small fixes
Christian Brauner [Sun, 14 Feb 2021 19:45:22 +0000 (20:45 +0100)]
start: fix comment about time namespace preservation
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sun, 14 Feb 2021 19:44:57 +0000 (20:44 +0100)]
start: improve comment in lxc_spawn()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sun, 14 Feb 2021 19:44:18 +0000 (20:44 +0100)]
start: improve comments
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sun, 14 Feb 2021 19:41:50 +0000 (20:41 +0100)]
start: improve namespace preservation
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sun, 14 Feb 2021 19:36:25 +0000 (20:36 +0100)]
start: fix error handling and improve comment
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Sun, 14 Feb 2021 15:55:54 +0000 (10:55 -0500)]
Merge pull request #3671 from brauner/2021-02-14/namespace_hooks
hooks: rework exposing namespace information
Christian Brauner [Sun, 14 Feb 2021 13:07:44 +0000 (14:07 +0100)]
network: expose namespace fd paths to network hooks
Closes: #3667
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sun, 14 Feb 2021 13:03:07 +0000 (14:03 +0100)]
start: rework namespace preservation and path creation for hooks
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Sun, 14 Feb 2021 00:02:22 +0000 (19:02 -0500)]
Merge pull request #3670 from brauner/2021-02-13/fixes
tree-wide: convert to strequal() and strnequal()
Christian Brauner [Sat, 13 Feb 2021 20:37:47 +0000 (21:37 +0100)]
utils: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 13 Feb 2021 20:37:05 +0000 (21:37 +0100)]
seccomp: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 13 Feb 2021 20:36:14 +0000 (21:36 +0100)]
lxccontainer: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 13 Feb 2021 20:35:45 +0000 (21:35 +0100)]
lsm: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 13 Feb 2021 20:35:19 +0000 (21:35 +0100)]
freezer: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 13 Feb 2021 20:35:01 +0000 (21:35 +0100)]
file_utils: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 13 Feb 2021 20:34:33 +0000 (21:34 +0100)]
confile_utils: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 13 Feb 2021 20:33:58 +0000 (21:33 +0100)]
confile: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 13 Feb 2021 20:33:01 +0000 (21:33 +0100)]
conf: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 13 Feb 2021 20:32:20 +0000 (21:32 +0100)]
cgroups: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 13 Feb 2021 20:31:06 +0000 (21:31 +0100)]
attach: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 13 Feb 2021 20:30:50 +0000 (21:30 +0100)]
utils: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 13 Feb 2021 20:30:11 +0000 (21:30 +0100)]
terminal: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 13 Feb 2021 20:29:51 +0000 (21:29 +0100)]
string_utils: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 13 Feb 2021 20:28:46 +0000 (21:28 +0100)]
state: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 13 Feb 2021 20:28:29 +0000 (21:28 +0100)]
start: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 13 Feb 2021 20:27:53 +0000 (21:27 +0100)]
namespace: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 13 Feb 2021 20:27:35 +0000 (21:27 +0100)]
seccomp: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 13 Feb 2021 20:26:26 +0000 (21:26 +0100)]
network: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 13 Feb 2021 20:40:20 +0000 (21:40 +0100)]
lxccontainer: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 13 Feb 2021 20:24:16 +0000 (21:24 +0100)]
lsm: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 13 Feb 2021 20:23:01 +0000 (21:23 +0100)]
log: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 13 Feb 2021 20:22:35 +0000 (21:22 +0100)]
initutils: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 13 Feb 2021 20:21:58 +0000 (21:21 +0100)]
criu: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 13 Feb 2021 20:21:03 +0000 (21:21 +0100)]
confile_utils: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 13 Feb 2021 20:20:26 +0000 (21:20 +0100)]
confile: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 13 Feb 2021 20:16:18 +0000 (21:16 +0100)]
conf: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 13 Feb 2021 20:14:19 +0000 (21:14 +0100)]
cgroups: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 13 Feb 2021 20:12:45 +0000 (21:12 +0100)]
attach: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Thu, 11 Feb 2021 14:14:16 +0000 (09:14 -0500)]
Merge pull request #3666 from brauner/2021-02-11/fixes
Improved mount api support checking & console setup hardening
Christian Brauner [Thu, 11 Feb 2021 13:51:46 +0000 (14:51 +0100)]
tree-wide: rework mount api support checks
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 11 Feb 2021 13:42:55 +0000 (14:42 +0100)]
conf: introduce lxc_bind_mount_console()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 11 Feb 2021 13:41:02 +0000 (14:41 +0100)]
macro: add LXC_PROC_SELF_FD_LEN
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 11 Feb 2021 13:40:41 +0000 (14:40 +0100)]
file_utils: add same_file_lax()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 11 Feb 2021 13:40:17 +0000 (14:40 +0100)]
string_utils: add fdstr()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 11 Feb 2021 13:39:58 +0000 (14:39 +0100)]
string_utils: add proc_self_fd()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 11 Feb 2021 13:39:20 +0000 (14:39 +0100)]
memory_utils: add close_move_fd()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Thu, 11 Feb 2021 12:59:48 +0000 (07:59 -0500)]
Merge pull request #3665 from brauner/2021-02-11/fixes
tree-wide: fixes
Christian Brauner [Thu, 11 Feb 2021 09:51:54 +0000 (10:51 +0100)]
utils: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 11 Feb 2021 09:49:10 +0000 (10:49 +0100)]
string_utils: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 11 Feb 2021 09:48:07 +0000 (10:48 +0100)]
terminal: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 11 Feb 2021 09:47:38 +0000 (10:47 +0100)]
start: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 11 Feb 2021 09:46:47 +0000 (10:46 +0100)]
seccomp: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 11 Feb 2021 09:45:14 +0000 (10:45 +0100)]
rexec: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 11 Feb 2021 09:44:38 +0000 (10:44 +0100)]
network: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 11 Feb 2021 09:42:22 +0000 (10:42 +0100)]
mount_utils: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 11 Feb 2021 09:41:52 +0000 (10:41 +0100)]
monitor: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 11 Feb 2021 09:40:56 +0000 (10:40 +0100)]
lxclock: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 11 Feb 2021 09:40:00 +0000 (10:40 +0100)]
lxccontainer: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 11 Feb 2021 09:32:22 +0000 (10:32 +0100)]
log: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 11 Feb 2021 09:30:38 +0000 (10:30 +0100)]
file_utils: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 11 Feb 2021 09:29:59 +0000 (10:29 +0100)]
criu: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 11 Feb 2021 09:28:07 +0000 (10:28 +0100)]
confile_utils: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 11 Feb 2021 09:27:06 +0000 (10:27 +0100)]
confile: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 11 Feb 2021 09:24:18 +0000 (10:24 +0100)]
conf: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 11 Feb 2021 09:18:41 +0000 (10:18 +0100)]
commands_utils: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 11 Feb 2021 09:16:34 +0000 (10:16 +0100)]
attach: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 11 Feb 2021 09:15:15 +0000 (10:15 +0100)]
cgroups: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 11 Feb 2021 09:14:34 +0000 (10:14 +0100)]
string_utils: add wrapper for snprintf()
This let's us avoid the tedious
if (ret < 0 || (size_t)ret >= sizeof(buf))
style of error checking.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Wed, 10 Feb 2021 20:52:59 +0000 (15:52 -0500)]
Merge pull request #3664 from brauner/2021-02-10/fixes
cgroups: fixes
Christian Brauner [Wed, 10 Feb 2021 19:18:37 +0000 (20:18 +0100)]
cgroups: log container process entering
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 10 Feb 2021 19:17:32 +0000 (20:17 +0100)]
cgroups: log monitor and transient process entering
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 10 Feb 2021 19:15:48 +0000 (20:15 +0100)]
cgroups: do not return early when entering monitor cgroups
This will happen when restoring a container via criu.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 10 Feb 2021 19:14:38 +0000 (20:14 +0100)]
cgroups: use brackets to have clear semantics for flags checking
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Wed, 10 Feb 2021 18:41:07 +0000 (13:41 -0500)]
Merge pull request #3663 from brauner/2021-02-10/fixes
criu: fixes
Christian Brauner [Wed, 10 Feb 2021 12:21:25 +0000 (13:21 +0100)]
criu: handle new cgroup layout
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 10 Feb 2021 12:12:47 +0000 (13:12 +0100)]
criu: lxc_init() already initializes cgroups
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 10 Feb 2021 12:03:06 +0000 (13:03 +0100)]
criu: warn about cgroup hierarchies without controllers
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 10 Feb 2021 11:50:20 +0000 (12:50 +0100)]
criu: rework init pid retrieval
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 10 Feb 2021 11:46:08 +0000 (12:46 +0100)]
criu: use cleanup macro when parsing mount data
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 10 Feb 2021 11:45:22 +0000 (12:45 +0100)]
criu: use cleanup macro
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 10 Feb 2021 11:39:23 +0000 (12:39 +0100)]
criu: move logging under lxc_log_trace()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 10 Feb 2021 11:27:26 +0000 (12:27 +0100)]
criu: massage exec_criu()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 10 Feb 2021 10:11:45 +0000 (11:11 +0100)]
criu: mark cgroups methods specific to criu
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 10 Feb 2021 09:58:16 +0000 (10:58 +0100)]
conf: fix memory leak
Fixes: Coverity 1472848
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Tue, 9 Feb 2021 15:46:19 +0000 (10:46 -0500)]
Merge pull request #3661 from blenk92/iw_error_msg
network: Add error message if iw couldn't be found
Stéphane Graber [Tue, 9 Feb 2021 15:07:28 +0000 (10:07 -0500)]
Merge pull request #3662 from brauner/2021-02-08/fixes
conf: expand fd-only setup codepaths
Christian Brauner [Mon, 8 Feb 2021 19:32:56 +0000 (20:32 +0100)]
conf: kill PATH_MAX bytes
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 8 Feb 2021 19:30:59 +0000 (20:30 +0100)]
conf: kill PATH_MAX bytes
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 8 Feb 2021 19:24:01 +0000 (20:24 +0100)]
tests: add logging to lxc-test-unpriv
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 8 Feb 2021 13:52:50 +0000 (14:52 +0100)]
conf: fd-only tty setup
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 8 Feb 2021 13:46:08 +0000 (14:46 +0100)]
mount_utils: s/OPEN_TREE_CLONE | OPEN_TREE_CLONE/OPEN_TREE_CLONE | OPEN_TREE_CLOEXEC/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 8 Feb 2021 10:24:57 +0000 (11:24 +0100)]
conf: rework rootfs pinning
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Max [Sat, 6 Feb 2021 19:13:15 +0000 (20:13 +0100)]
network: Add error message if iw couldn't be found
When iw is not installed on the host, lxc fails to move wireless devices
into a container. Unfortunately there is no real error message yet
(other than that it didn't work), so its quite unobvious what causes
this. This commit adds a error message that clearly states the
application iw is missing.
Signed-off-by: Maximilian Blenk <blenkmax@gmail.com>
Christian Brauner [Mon, 8 Feb 2021 09:22:00 +0000 (10:22 +0100)]
conf: kill PAT_MAX bytes
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 8 Feb 2021 09:21:18 +0000 (10:21 +0100)]
conf: kill PATH_MAX bytes
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 8 Feb 2021 09:17:05 +0000 (10:17 +0100)]
conf: don't pass struct lxc_conf
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>