]>
git.proxmox.com Git - pve-manager-legacy.git/log
Stoiko Ivanov [Wed, 16 Dec 2020 11:46:11 +0000 (12:46 +0100)]
ceph: extend error for wrong config-file link
Since I had to look up the cause of the error-message in our source
explaining why exactly ceph-operations fail, because
/etc/ceph/ceph.conf exists.
reported via our community forum:
https://forum.proxmox.com/threads/osd-ersetzen-neu-erstellen.80793/
quickly tested on a virtual ceph cluster
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Thomas Lamprecht [Fri, 11 Dec 2020 08:59:25 +0000 (09:59 +0100)]
update aplinfo
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominik Csapak [Mon, 7 Dec 2020 14:37:07 +0000 (15:37 +0100)]
status/plugin: do not test connection if disabled
so that if one disables the plugin (e.g. because it is offline),
it will work even when the server is not reachable
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Fabian Ebner [Fri, 4 Dec 2020 09:15:18 +0000 (10:15 +0100)]
vzdump: use debugmsg instead of warn
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Fabian Ebner [Fri, 4 Dec 2020 09:15:17 +0000 (10:15 +0100)]
vzdump: warn when both storage and dumpdir are defined in vzdump.conf
and prefer storage, because the storage configuration might contain more
settings. Warning is preferable over dying, because all backups would be
affected (even if they don't use the vzdump.conf parameters) and the settings
could've been compatible (i.e. dumpdir being the storage's dump dir). Previously
one of the two options would randomly be chosen in the loop in new(), because of
perl hash iteration.
Reported here: https://forum.proxmox.com/threads/vzdump-times-out-very-often-on-zfs-storage-pool.80035/post-354277
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Thomas Lamprecht [Thu, 3 Dec 2020 17:14:49 +0000 (18:14 +0100)]
bump version to 6.3-3
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominik Csapak [Thu, 3 Dec 2020 15:01:40 +0000 (16:01 +0100)]
pvestatd: fix container cpuset scheduling
Since pve-container commit
c48a25452dccca37b3915e49b7618f6880aeafb1
the code to get the cpuset controller path lives in pve-commons PVE::CGroup.
Use that and improve the logging in case some error happens in the future.
Such an error will only be logged once per pvestatd run,
so it does not spam the log.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Wed, 2 Dec 2020 12:56:31 +0000 (13:56 +0100)]
fix #3182 #3183: change backup retention mask logic
instead of relying on the contentTypeField (which does not need to
exists, e.g. for iscsi), explicitely write it into the panel/icon
mapping and check that
better would be if we query the backend about storage capabilities,
but such an api call does not exist yet, so this should be ok for now
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Thomas Lamprecht [Wed, 2 Dec 2020 17:00:44 +0000 (18:00 +0100)]
test: allow running replication tests in parallel
running multiple workers reduces built time from >3s to ~0.6s here.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 2 Dec 2020 16:57:18 +0000 (17:57 +0100)]
test: replication: cleanup use statements
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 2 Dec 2020 15:19:34 +0000 (16:19 +0100)]
test: buildsys: allow to execute vzdump tests in parallel
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 2 Dec 2020 15:18:41 +0000 (16:18 +0100)]
test: buildsys: rework target names, prefix with test
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Fabian Ebner [Tue, 1 Dec 2020 08:24:21 +0000 (09:24 +0100)]
vzdump: defaults: correctly parse prune-backups and convert maxfiles
Also simplify handling in new(), now that we never have maxfiles there anymore.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Fabian Ebner [Tue, 1 Dec 2020 08:24:20 +0000 (09:24 +0100)]
vzdump: convert maxfiles CLI parameter to prune-backups
in preparation to clean up handling in new().
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Fabian Ebner [Tue, 1 Dec 2020 08:24:19 +0000 (09:24 +0100)]
vzdump: storage_info: adapt to new maxfiles backend behavior
It's automatically converted to prune-backups when using storage_config() now.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Fabian Ebner [Tue, 1 Dec 2020 08:24:18 +0000 (09:24 +0100)]
test: add tests for retention parameters for vzdump's new()
To get a more complete picture, instead of mocking storage_config,
PVE::Cluster's get_config is mocked. This ensures that the prune-backups
validation and the maxfiles conversion are also called.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Thomas Lamprecht [Wed, 2 Dec 2020 10:45:33 +0000 (11:45 +0100)]
api: fixup: commit change to storage module
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 2 Dec 2020 10:28:39 +0000 (11:28 +0100)]
ui: USB selector: use new API endpoint
so that we can sunset the usbscan from pve-storage's scan API, which
was never fitting there anyway.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 2 Dec 2020 10:26:57 +0000 (11:26 +0100)]
api: add usb list in hardware endpoint
As envisioned in[0][1], better late than never.
[0]: commit
3bca5efd9c219d97c2eac5685bf6cac579a3b0f1
[1]: https://lists.proxmox.com/pipermail/pve-devel/2018-November/034694.html
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 1 Dec 2020 18:30:13 +0000 (19:30 +0100)]
api: use storage scan module from pve-storage
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominik Csapak [Thu, 26 Nov 2020 08:19:53 +0000 (09:19 +0100)]
ui: fix usage of findRecord
findRecord does not match exactly, but only at the beginning and
case insensitive, by default. Change all calls to be case sensitive
and an exactmatch (we never want the default behaviour afaics).
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Thu, 26 Nov 2020 07:58:25 +0000 (08:58 +0100)]
ui: storage: find the correct storage record
by default, findRecord only anchors at the beginning, e.g.
findRecord('id', 'foo');
could find either an entry with id 'foo', 'foobar', 'foobaz', etc.
extend the call to set 'exactMatch' to true, else we sometimes
used the content types of storage e.g., 'local-lvm' for showing
the panels for 'local'
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Fabian Grünbichler [Thu, 26 Nov 2020 09:42:18 +0000 (10:42 +0100)]
ui: don't refer to enc key as 'master key'
the master key is something entirely different, this might confuse
users..
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
Thomas Lamprecht [Wed, 25 Nov 2020 15:19:56 +0000 (16:19 +0100)]
bump version to 6.3-2
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 25 Nov 2020 15:19:50 +0000 (16:19 +0100)]
ui: pbs: set onlineHelp (again)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Stefan Reiter [Tue, 24 Nov 2020 16:52:05 +0000 (17:52 +0100)]
ui: bootorder: add onlineHelp link
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
Dominik Csapak [Wed, 25 Nov 2020 12:56:40 +0000 (13:56 +0100)]
api: metrics/server: test connection on add/update
just a basic check, but better than not checking at all
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Thomas Lamprecht [Wed, 25 Nov 2020 13:49:23 +0000 (14:49 +0100)]
ui: storage edit: ensure to set keep-all by default
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominik Csapak [Wed, 25 Nov 2020 12:04:37 +0000 (13:04 +0100)]
ui: pbs key show: improve labelWidth for 'Key' in translations
it is not that short in other languages, e.g. German
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominic Jäger [Wed, 25 Nov 2020 12:15:19 +0000 (13:15 +0100)]
ui: storage: pbsedit: Fix spelling
No e in unusable.
to loose means to free from restraint, or to make less tight or strict [1].
to lose means to fail to keep, or to miss something from one's possession [2].
So "losing" (instead of "loosing") would be bad.
[0] https://www.merriam-webster.com/dictionary/unusable
[1] https://www.merriam-webster.com/dictionary/loose
[2] https://www.merriam-webster.com/dictionary/lose
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Thomas Lamprecht [Wed, 25 Nov 2020 12:15:19 +0000 (13:15 +0100)]
ui: storage edit: avoid returning prune values if unsupported
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Wolfgang Bumiller [Wed, 25 Nov 2020 10:36:43 +0000 (11:36 +0100)]
ad #3140: allow interface suffix in dns entries
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Dominic Jäger [Wed, 25 Nov 2020 10:29:24 +0000 (11:29 +0100)]
ui: metrics: Link help button to correct chapter
... instead of generic PVE admin guide.
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Dominik Csapak [Wed, 25 Nov 2020 11:06:26 +0000 (12:06 +0100)]
api: metrics/server: add minimum and maximum to port schema
we just added the api, so it would be good to only accept valid ports
(they were wrapped before)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 22:45:11 +0000 (23:45 +0100)]
bump version to 6.3-1
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Stoiko Ivanov [Tue, 24 Nov 2020 18:55:47 +0000 (19:55 +0100)]
api2: osd destroy: untaint device before pvremove
We get the device list from ceph-volume lvm list, and decode the json
output, which at that point is tainted (perlsec (1)).
Untaint it here before calling, because it is currently the only
call-site using the information in a problematic way (run_command).
(the only other call-site being in pve5to6)
Alternatively we could untaint while reading the information, but then
should only return a small subset of the ceph-volume output.
The issue is most likely due to
cb9db10c1a9855cf40ff13e81f9dd97d6a9b2698 in pve-common ('run_command:
improve performance for logging and long lines'),
Tested on a virtual testsetup by creating OSDs with second DB disk,
and destroying it via GUI (did not manage to get the error without the
DB disk)
Reported via our community forum:
https://forum.proxmox.com/threads/insecure-dependency-in-exec-during-osd-destroy.79574/
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Stoiko Ivanov [Tue, 24 Nov 2020 18:55:46 +0000 (19:55 +0100)]
api2: osd destroy: fix error function
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 22:36:02 +0000 (23:36 +0100)]
ui: storage content: add encryption and verification columns for PBS
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 22:35:39 +0000 (23:35 +0100)]
ui: factor out backup verification renderer
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 22:35:15 +0000 (23:35 +0100)]
ui: guest backup view: add encrypted column for PBS storages
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 22:34:25 +0000 (23:34 +0100)]
ui: storage content: allow to specify extraColumns (again)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 22:33:53 +0000 (23:33 +0100)]
ui: storage/browser: pass storage plugin type to content panels
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 22:32:20 +0000 (23:32 +0100)]
ui: storage: pbs paperkey: print short fingerprint in heading
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 22:09:36 +0000 (23:09 +0100)]
ui: storage: pbs: move datastore field to right column for balance
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 22:07:32 +0000 (23:07 +0100)]
ui: storage: pbs: improve encryption key handling
Move encryption key handling in its own tab.
Allow uploads, warn more visible on edit/remove
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 22:08:43 +0000 (23:08 +0100)]
ui: utils: add more generic loadTextFromFile upload helper
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 22:06:21 +0000 (23:06 +0100)]
ui: storage: base: allow adding extra tab panels
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 22:01:53 +0000 (23:01 +0100)]
api: resources: return plugin type
The storage one for now.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 16:09:51 +0000 (17:09 +0100)]
ui: dc/storage: set onlineHelp for prune tab in edit window
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 15:01:48 +0000 (16:01 +0100)]
bump version to 6.2-17
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominik Csapak [Tue, 24 Nov 2020 14:32:55 +0000 (15:32 +0100)]
API2/Ceph: fix createpools 'add_storages' parameter
by deleteing it from $ceph_param we deleted it also from
$param since it was only a reference
fix it by extracting it beforehand
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Fabian Ebner [Tue, 24 Nov 2020 14:31:36 +0000 (15:31 +0100)]
ui: storage: show no-keeps hint exactly when needed
extracting the logic from the previous checkbox listener into a function, which
is also called on field changes and once in afterrender. Calling it initially
makes sure the hint is also displayed at the beginning when editing a storage
with no retention options configured, and the initial disabling of the input
fields for the isCreate case now also happens through that call.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 13:26:18 +0000 (14:26 +0100)]
ui: guest backups: add separator, fix left-over Comments title
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Fabian Ebner [Tue, 24 Nov 2020 13:00:53 +0000 (14:00 +0100)]
ui: storage backup view: add prune window
adapted from PBS. Main differences are:
* API has GET/DELETE distinction instead of 'dry-run'
* API expects a single property string for the prune options
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Dominik Csapak [Tue, 24 Nov 2020 09:09:35 +0000 (10:09 +0100)]
ui: add ability to show and edit comments for backups
for now we filter out pbs storages
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Tue, 24 Nov 2020 09:09:34 +0000 (10:09 +0100)]
ui: change comment column to notes
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 12:38:50 +0000 (13:38 +0100)]
followup code cleanup
actually cleaning up the initial state, the last patch was OK as is..
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominic Jäger [Tue, 24 Nov 2020 12:15:58 +0000 (13:15 +0100)]
storage: base edit: Don't send delete during creation
... as this is now allowed by the API (createSchema() in PVE::SectionConfig).
It is only allowed by the update API call (updateSchema()).
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Dylan Whyte [Tue, 24 Nov 2020 10:14:47 +0000 (11:14 +0100)]
UI: Ceph Wizard: language fixup
Improve the language found in the ceph install Wizard.
Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 08:27:18 +0000 (09:27 +0100)]
ui: wizard: fix ceph docs link
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Mon, 23 Nov 2020 19:12:56 +0000 (20:12 +0100)]
ui: avoid ||=
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Mon, 23 Nov 2020 13:01:54 +0000 (14:01 +0100)]
bump version to 6.2-16
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Mon, 23 Nov 2020 18:31:13 +0000 (19:31 +0100)]
ui: storage: pbs: add hint for backup retention
Normally it's better to configure pruning (backup retention) on the
backup server only, as then multiple client settings may not
interfere with each other due to outdated or to strict prune
settings (remember, the strictest prune setting always wins).
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Mon, 23 Nov 2020 17:55:19 +0000 (18:55 +0100)]
storage: drop max backup fields, replaced by pruning
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Mon, 23 Nov 2020 17:52:19 +0000 (18:52 +0100)]
storage: base edit: add Backup Retention tab
Support all prune keep- settings we have.
masked if the storage cannot support backups.
We do not care if it is disabled as content type for now, a user can
just set them nonetheless (could show a hint though).
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Mon, 23 Nov 2020 17:51:16 +0000 (18:51 +0100)]
storage: base edit: move main inputpanel into tab panel
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Mon, 23 Nov 2020 18:12:36 +0000 (19:12 +0100)]
ui: storage base panel: cope with undefined column2
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Mon, 23 Nov 2020 15:03:57 +0000 (16:03 +0100)]
d/control: bump versioned dependency of libpve-storage-perl 6.2-11
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Fabian Ebner [Mon, 23 Nov 2020 14:54:15 +0000 (15:54 +0100)]
cleanup keep-all handling
If keep-all is set to 0, adding it doesn't make a difference,
if the key is not in the hash, it won't show up in the 'values'.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Fabian Ebner [Mon, 23 Nov 2020 12:33:10 +0000 (13:33 +0100)]
vzdump: adapt to new keep-all prune option
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Thomas Lamprecht [Mon, 23 Nov 2020 13:00:07 +0000 (14:00 +0100)]
ui: snapshot tree: add separator between rollback and edit button
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Moayad Almalat [Mon, 9 Nov 2020 11:40:10 +0000 (12:40 +0100)]
close #3114: ui: snapshots: switch Edit and Remove Button & add warning logo
Signed-off-by: Moayad Almalat <m.almalat@proxmox.com>
Thomas Lamprecht [Mon, 23 Nov 2020 11:01:52 +0000 (12:01 +0100)]
pveceph: update octopus repository
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Sun, 22 Nov 2020 17:51:19 +0000 (18:51 +0100)]
ui: ceph install wizard: fix indentation
Hi to the people from the future which came here due to git blame or
the like. `git show -w` should proof that you got the wrong one.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Fabian Ebner [Wed, 18 Nov 2020 10:04:19 +0000 (11:04 +0100)]
ui: make remaining content views not stateful
Commit
c2b949f05bb8942b4827df4aeec91e10e09c1b2f removed the statefulness from
the other storage content views, so remove it from the remaining ones too.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Fabian Ebner [Wed, 18 Nov 2020 10:04:18 +0000 (11:04 +0100)]
ui: storage: get content types from resources
to avoid waiting for a status API call.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Fabian Ebner [Wed, 18 Nov 2020 10:04:17 +0000 (11:04 +0100)]
cluster resources: include content type for storages
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Thomas Lamprecht [Sun, 22 Nov 2020 16:58:52 +0000 (17:58 +0100)]
ui: ceph install mask: avoid showing version
we do not know yet which version will get installed for real, so just
drop that part.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Sun, 22 Nov 2020 16:56:23 +0000 (17:56 +0100)]
ui: ceph: allow selecting which version to install
Try to find out the newest version in the cluster and select that (if
in the known OK list).
Slightly hacky, but nothing really out of the ordinary, so should be
OK.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Sun, 22 Nov 2020 14:46:18 +0000 (15:46 +0100)]
ui: ceph wizard: move out info panel to separate component
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Sun, 22 Nov 2020 14:29:02 +0000 (15:29 +0100)]
ceph: do not require allow-experimental flag for octopus anymore
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Sun, 22 Nov 2020 14:26:13 +0000 (15:26 +0100)]
ui: console: add beforeLoad callback
we sometimes need to adapt parameters, but in a lot contexts the
component is already created, and the activate event order of
components may make this hard to do in a deterministic way.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Sun, 22 Nov 2020 14:23:16 +0000 (15:23 +0100)]
api: nodes: allow root to pass arbitrary arguments to commands
If the command itself allows it, which normally means it has good
verification of passed arguments.
We may want to re-evaluate security here if we allow execution for a
group of non-root users.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Sun, 22 Nov 2020 15:12:58 +0000 (16:12 +0100)]
api: cluster/ceph: allow version metadata call on non-ceph nodes
the information comes only from the key value store in the pmxcfs, so
we do not actually require ceph to be installed.
So only check if ceph is locally initialized and create the rados
connection after the early return when only versions scope is set.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Sun, 22 Nov 2020 16:58:17 +0000 (17:58 +0100)]
ceph services: cleanup variable names
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Sun, 22 Nov 2020 09:22:10 +0000 (10:22 +0100)]
ui: lxc: code cleanup ssh key upload
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Sat, 21 Nov 2020 19:55:13 +0000 (20:55 +0100)]
ui: metrics: set default for port
while it may not be always correct, we can only win by setting a
reasonable default, taken from
* graphite:
https://graphite.readthedocs.io/en/stable/feeding-carbon.html#the-plaintext-protocol
* influxdb, udp port:
https://docs.influxdata.com/influxdb/v1.8/administration/ports/
Also, changing that is easy for the admin and can always be done
afterwards.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Sat, 21 Nov 2020 19:55:04 +0000 (20:55 +0100)]
ui: metrics: move server and port on same line
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Sat, 21 Nov 2020 19:43:08 +0000 (20:43 +0100)]
ui: metrics: style cleanup: defined xtype first, name second
those are both the most important for what the field is, so they
should come first.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Sat, 21 Nov 2020 19:42:10 +0000 (20:42 +0100)]
ui: metrics: advancedColumn1 may now be empty
we have now improved detection in widget toolkit, not yet packaged
though
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Sat, 21 Nov 2020 19:39:54 +0000 (20:39 +0100)]
ui: metrics: use icons for add server
we could use the official influxdata one, they provide it in their
branding guide - and the use here would seem to comply with their
rules, and would fall under fair-user, probably.
Still, not 100% clear for me and Graphite is not easy to find a good
one with clear rules, so just reuse the bar-graph Font Awesome one,
better than nothing (looks empty-wrong)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Sat, 21 Nov 2020 19:36:31 +0000 (20:36 +0100)]
ui/api: metrics: move server to subpath, post to path with ID
We actually wanted to use that scheme for more new API paths, lets
see if it is really fitting starting with this.
Use the new widget-toolkit submitUrl helper to add the ID on create.
And unify the edit/create window creation, which may fit better in a
separate commit, it's quite small and was to cumbersome to untangle,
so just go against my one rules here... :(
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Sat, 21 Nov 2020 19:31:54 +0000 (20:31 +0100)]
ui: metrics: add server base edit window
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominik Csapak [Fri, 20 Nov 2020 14:12:28 +0000 (15:12 +0100)]
ui: add MetricServerView to Datacenter
adds ui support for configuring the External Metric servers.
for now, influxdb and graphite edit windows do not share code,
it would be ideal to do that once we add more plugins
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Thomas Lamprecht [Fri, 20 Nov 2020 15:45:37 +0000 (16:45 +0100)]
api: drop Config from MetricServer module name
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominik Csapak [Fri, 20 Nov 2020 14:12:27 +0000 (15:12 +0100)]
api2/cluster: add 'metricserver' api endpoints
modeled after our typical api endpoints for sectionschema configs
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Thomas Lamprecht [Sat, 21 Nov 2020 19:39:22 +0000 (20:39 +0100)]
influxdb: avoid three line comment if one is enough
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Sat, 21 Nov 2020 19:28:51 +0000 (20:28 +0100)]
ui: manager: use eslint for lint target
not yet linting by default, we need to fix a few thousands linter
errors before that (most are trivial though)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Sat, 21 Nov 2020 19:33:47 +0000 (20:33 +0100)]
http server: allow duplicate params (URI and form) if equal
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominik Csapak [Fri, 20 Nov 2020 14:29:13 +0000 (15:29 +0100)]
ui: fix 'no iommu found' message for setups
sometimes, the first device in the pci api call is not in a separate
iommu group (see e.g. [0]), but it is active and should work
instead of testing the first, test all, and only show the message
if no device has a set iommu group
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>