]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/log
mirror_ubuntu-disco-kernel.git
11 years ago[media] ivtv: prepare ivtv for adding const to s_register
Hans Verkuil [Sun, 24 Mar 2013 11:24:19 +0000 (08:24 -0300)]
[media] ivtv: prepare ivtv for adding const to s_register

The ivtv_itvc function receives a pointer to v4l2_dbg_register. When we
add const to that pointer in the s_register case we will run into a problem
here since this common function would discard const in that case. So
change this function so it receives the address and a pointer to a value.
In addition we now set the size field in the g_register function which is
where it belongs.
This will simplify the next patch where const will be added to s_register.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] v4l2-ioctl: add precision when printing names
Hans Verkuil [Mon, 18 Mar 2013 14:02:22 +0000 (11:02 -0300)]
[media] v4l2-ioctl: add precision when printing names

Never print more than the size of the buffer containing the name.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] v4l2: pass std by value to the write-only s_std ioctl
Hans Verkuil [Fri, 15 Mar 2013 09:10:40 +0000 (06:10 -0300)]
[media] v4l2: pass std by value to the write-only s_std ioctl

This ioctl is defined as IOW, so pass the argument by value instead of by
reference. I could have chosen to add const instead, but this is 1) easier
to handle in drivers and 2) consistent with the s_std subdev operation.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Jonathan Corbet <corbet@lwn.net>
Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] v4l2: add const to argument of write-only s_tuner ioctl
Hans Verkuil [Fri, 15 Mar 2013 09:10:06 +0000 (06:10 -0300)]
[media] v4l2: add const to argument of write-only s_tuner ioctl

This ioctl is defined as IOW, so pass the argument as const.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Alexey Klimov <klimov.linux@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] v4l2: add const to argument of write-only s_frequency ioctl
Hans Verkuil [Tue, 19 Mar 2013 07:09:26 +0000 (04:09 -0300)]
[media] v4l2: add const to argument of write-only s_frequency ioctl

This ioctl is defined as IOW, so pass the argument as const.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] drivers: staging: davinci_vpfe: use resource_size()
Silviu-Mihai Popescu [Mon, 18 Mar 2013 18:06:20 +0000 (15:06 -0300)]
[media] drivers: staging: davinci_vpfe: use resource_size()

This uses the resource_size() function instead of explicit computation.

Signed-off-by: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] bttv: apply mute settings on open
Frank Schaefer [Thu, 21 Mar 2013 16:51:20 +0000 (13:51 -0300)]
[media] bttv: apply mute settings on open

Previously, this has been done implicitly for video device nodes by calling
set_input() (which calls audio_input() and also modified the mute
setting).
Since input and mute setting are now untangled (as much as possible), we need to
apply the mute setting with an explicit call to audio_mute().
Also apply the mute setting when the radio device node gets opened.

Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] bttv: do not unmute the device before the first open
Frank Schaefer [Thu, 21 Mar 2013 16:51:19 +0000 (13:51 -0300)]
[media] bttv: do not unmute the device before the first open

Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] bttv: untangle audio input and mute setting
Frank Schaefer [Thu, 21 Mar 2013 16:51:18 +0000 (13:51 -0300)]
[media] bttv: untangle audio input and mute setting

Split function audio_mux():
move the mute setting part to function audio_mute() and the input setting part
to function audio_input().

Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] bttv: separate GPIO part from function audio_mux()
Frank Schaefer [Thu, 21 Mar 2013 16:51:17 +0000 (13:51 -0300)]
[media] bttv: separate GPIO part from function audio_mux()

Move the GPIO part of function audio_mux() to a separate function
audio_mux_gpio().
This prepares the code for the next patch which will separate mute and input
setting.

Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] bttv: rename field 'audio' in struct 'bttv' to 'audio_input'
Frank Schaefer [Thu, 21 Mar 2013 16:51:16 +0000 (13:51 -0300)]
[media] bttv: rename field 'audio' in struct 'bttv' to 'audio_input'

'audio_input' better describes the meaning of this field.

Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] bttv: do not save the audio input in audio_mux()
Frank Schaefer [Thu, 21 Mar 2013 16:51:15 +0000 (13:51 -0300)]
[media] bttv: do not save the audio input in audio_mux()

We can't and do not save the mute setting in function audio_mux(), so we
should also not save the input in this function for consistency.

Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] bttv: audio_mux(): do not change the value of the v4l2 mute control
Frank Schaefer [Thu, 21 Mar 2013 16:51:14 +0000 (13:51 -0300)]
[media] bttv: audio_mux(): do not change the value of the v4l2 mute control

There are cases where we want to call audio_mux() without changing the value of
the v4l2 mute control, for example
- mute mute on last close
- mute on device probing

Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] bttv: audio_mux(): use a local variable "gpio_mute" instead of modifying...
Frank Schaefer [Thu, 21 Mar 2013 16:51:13 +0000 (13:51 -0300)]
[media] bttv: audio_mux(): use a local variable "gpio_mute" instead of modifying the function parameter "mute"

Function audio_mux() actually deals with two types of mute: gpio mute and
subdevice muting.
This patch claryfies the meaning of these values, but mainly prepares the code for
the next patch.

Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] davinci: vpfe: fix return value check in vpfe_enable_clock()
Wei Yongjun [Mon, 11 Mar 2013 12:57:22 +0000 (09:57 -0300)]
[media] davinci: vpfe: fix return value check in vpfe_enable_clock()

In case of error, the function clk_get() returns ERR_PTR()
and never returns NULL. The NULL test in the return value
check should be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Reviewed-by: Sakari Ailus <sakari.ailus@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] rc-core: don't treat dev->rc_map.rc_type as a bitmap
David Härdeman [Wed, 6 Mar 2013 19:52:05 +0000 (16:52 -0300)]
[media] rc-core: don't treat dev->rc_map.rc_type as a bitmap

store_protocols() treats dev->rc_map.rc_type as a bitmap which is wrong for
two reasons. First of all, it is pretty bogus to change the protocol type of
the keymap just because the hardware has been asked to decode a different
protocol.
Second, dev->rc_map.rc_type is an enum (i.e. a single protocol) as pointed
out by James Hogan <james.hogan@imgtec.com>.
Fix both issues by introducing a separate enabled_protocols member to
struct rc_dev.

Signed-off-by: David Härdeman <david@hardeman.nu>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] dvb-usb/dw2102: Remove duplicate inclusion of ts2020.h
Sachin Kamat [Wed, 6 Mar 2013 08:04:26 +0000 (05:04 -0300)]
[media] dvb-usb/dw2102: Remove duplicate inclusion of ts2020.h

ts2020.h was included twice.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] [PATH] enable dual tuner to Avermedia Twinstar in af9035 driver
Jose Alberto Reguero [Sun, 10 Feb 2013 18:43:03 +0000 (15:43 -0300)]
[media] [PATH] enable dual tuner to Avermedia Twinstar in af9035 driver

This patch enable dual tuner for Avermedia Twinstar.

Signed-off-by: Jose Alberto Reguero <jareguero@telefonica.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] s5p-tv: remove the dv_preset API from hdmiphy
Hans Verkuil [Fri, 15 Feb 2013 18:00:20 +0000 (15:00 -0300)]
[media] s5p-tv: remove the dv_preset API from hdmiphy

The dv_preset API is deprecated and is replaced by the much improved dv_timings
API. Remove the dv_preset support from this driver as this will allow us to
remove the dv_preset API altogether (s5p-tv being the last user of this code).

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Tested-by: Tomasz Stanislawski <t.stanislaws@samsung.com>
Acked-by: Tomasz Stanislawski <t.stanislaws@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] s5p-tv: remove the dv_preset API from hdmi
Hans Verkuil [Fri, 15 Feb 2013 17:59:48 +0000 (14:59 -0300)]
[media] s5p-tv: remove the dv_preset API from hdmi

The dv_preset API is deprecated and is replaced by the much improved dv_timings
API. Remove the dv_preset support from this driver as this will allow us to
remove the dv_preset API altogether (s5p-tv being the last user of this code).

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Tested-by: Tomasz Stanislawski <t.stanislaws@samsung.com>
Acked-by: Tomasz Stanislawski <t.stanislaws@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] s5p-tv: remove dv_preset support from mixer_video
Hans Verkuil [Mon, 4 Mar 2013 12:32:00 +0000 (09:32 -0300)]
[media] s5p-tv: remove dv_preset support from mixer_video

The dv_preset API is deprecated and is replaced by the much improved dv_timings
API. Remove the dv_preset support from this driver as this will allow us to
remove the dv_preset API altogether (s5p-tv being the last user of this code).

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Tested-by: Tomasz Stanislawski <t.stanislaws@samsung.com>
Acked-by: Tomasz Stanislawski <t.stanislaws@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] s5p-tv: add dv_timings support for mixer_video
Hans Verkuil [Mon, 4 Mar 2013 12:30:48 +0000 (09:30 -0300)]
[media] s5p-tv: add dv_timings support for mixer_video

This just adds dv_timings support without modifying existing dv_preset
support.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Tested-by: Tomasz Stanislawski <t.stanislaws@samsung.com>
Acked-by: Tomasz Stanislawski <t.stanislaws@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] s5p-tv: add dv_timings support for hdmi
Hans Verkuil [Mon, 4 Mar 2013 12:29:33 +0000 (09:29 -0300)]
[media] s5p-tv: add dv_timings support for hdmi

This just adds dv_timings support without modifying existing dv_preset
support.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Tested-by: Tomasz Stanislawski <t.stanislaws@samsung.com>
Acked-by: Tomasz Stanislawski <t.stanislaws@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] s5p-tv: add dv_timings support for hdmiphy
Hans Verkuil [Mon, 4 Mar 2013 12:28:57 +0000 (09:28 -0300)]
[media] s5p-tv: add dv_timings support for hdmiphy

This just adds dv_timings support without modifying existing dv_preset
support, although I had to refactor a little bit in order to share
hdmiphy_find_conf() between the preset and timings code.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Tested-by: Tomasz Stanislawski <t.stanislaws@samsung.com>
Acked-by: Tomasz Stanislawski <t.stanislaws@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] gspca: remove needless check before usb_free_coherent()
Wei Yongjun [Wed, 20 Mar 2013 14:30:46 +0000 (11:30 -0300)]
[media] gspca: remove needless check before usb_free_coherent()

usb_free_coherent() is safe with NULL addr and this check is
not required.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] drxk_hard: Drop unused parameter
Jean Delvare [Wed, 20 Mar 2013 12:43:21 +0000 (12:43 +0000)]
[media] drxk_hard: Drop unused parameter

Last parameter of function GetLockStatus() isn't used so drop it.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] davinci: vpif: Fix module build for capture and display
Lad, Prabhakar [Wed, 20 Mar 2013 04:28:27 +0000 (01:28 -0300)]
[media] davinci: vpif: Fix module build for capture and display

export the symbols which are used by two modules vpif_capture and
vpif_display. renamed "ch_params" to "vpif_ch_params" so as to avoid
name collision.
This patch fixes following error:
ERROR: "ch_params" [drivers/media/platform/davinci/vpif_display.ko] undefined!
ERROR: "vpif_ch_params_count" [drivers/media/platform/davinci/vpif_display.ko] undefined!
ERROR: "vpif_base" [drivers/media/platform/davinci/vpif_display.ko] undefined!
ERROR: "ch_params" [drivers/media/platform/davinci/vpif_capture.ko] undefined!
ERROR: "vpif_ch_params_count" [drivers/media/platform/davinci/vpif_capture.ko] undefined!
ERROR: "vpif_base" [drivers/media/platform/davinci/vpif_capture.ko] undefined!
make[1]: *** [__modpost] Error 1

Reported-by: Sekhar Nori <nsekhar@ti.com>
Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] drivers/staging/media/go7007: using strlcpy instead of strncpy
Chen Gang [Wed, 20 Mar 2013 02:26:09 +0000 (23:26 -0300)]
[media] drivers/staging/media/go7007: using strlcpy instead of strncpy

for NUL terminated string, need always set 0 in the end.

Signed-off-by: Chen Gang <gang.chen@asianux.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] media: radio: add module alias entry for radio-si4713
Eduardo Valentin [Tue, 19 Mar 2013 14:41:34 +0000 (11:41 -0300)]
[media] media: radio: add module alias entry for radio-si4713

Add MODULE_ALIAS entry for radio-si4713 platform driver.

Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] media: radio: add driver owner entry for radio-si4713
Eduardo Valentin [Tue, 19 Mar 2013 14:41:33 +0000 (11:41 -0300)]
[media] media: radio: add driver owner entry for radio-si4713

Simple addition of platform_driver->driver->owner for radio-si4713.

Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] media: radio: correct module license (==> GPL v2)
Eduardo Valentin [Tue, 19 Mar 2013 14:41:32 +0000 (11:41 -0300)]
[media] media: radio: correct module license (==> GPL v2)

As per code header comment, changing the driver license entry
to match the correct version.

Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] media: radio: CodingStyle changes on si4713
Eduardo Valentin [Tue, 19 Mar 2013 14:41:31 +0000 (11:41 -0300)]
[media] media: radio: CodingStyle changes on si4713

Minor changes to make alignment match on open parenthesis.

Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] it913x: fix pid filter
Antti Palosaari [Sun, 10 Mar 2013 00:10:14 +0000 (21:10 -0300)]
[media] it913x: fix pid filter

I just made commit: "dvb_usb_v2: rework USB streaming logic" that
breaks that driver PID filter.
it913x driver checks use of PID filter directly from DVB USB v2 core
internal variable "adap->pid_filtering" and stores it to own state.
Calling order of .pid_filter_ctrl() and .pid_filter() was changed
and due to that state was updated too late. Update state earlier.
TODO: checking PID filter usage from DVB USB v2 is not very good idea
as PID filter callbacks are called only when PID filter is enabled.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] dvb_usb_v2: rework USB streaming logic
Antti Palosaari [Sat, 9 Mar 2013 19:10:55 +0000 (16:10 -0300)]
[media] dvb_usb_v2: rework USB streaming logic

Control flow order changed a little bit. HW PID filter is now
disabled also when streaming is stopped - earlier it was just
set only when streaming was started.
Control flow is now:
* set streaming status bit
* submit USB streaming packets
* enable HW PID filter
* ask device to start streaming
* N x add PID to device HW PID filter
... streaming video ...
* N x remove PID from device HW PID filter
* ask device to stop streaming
* disable HW PID filter
* kill USB streaming packets
* clear streaming status bit

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] cypress_firmware: make checkpatch.pl happy
Antti Palosaari [Sat, 9 Mar 2013 14:38:41 +0000 (11:38 -0300)]
[media] cypress_firmware: make checkpatch.pl happy

New checkpatch version likes to see strings not to split multiple
lines even those are exceeding 80 line length.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] dvb_usb_v2: make checkpatch.pl happy
Antti Palosaari [Sat, 9 Mar 2013 14:36:35 +0000 (11:36 -0300)]
[media] dvb_usb_v2: make checkpatch.pl happy

New checkpatch version likes to see strings not to split multiple
lines even those are exceeding 80 line length.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] dvb_usb_v2: replace Kernel userspace lock with wait queue
Antti Palosaari [Sat, 9 Mar 2013 03:16:32 +0000 (00:16 -0300)]
[media] dvb_usb_v2: replace Kernel userspace lock with wait queue

There was sync mutex which was held over userspace. That is very
wrong and could cause deadlock if different userspace process is
used to "unlock". Wait queue seems to be correct solution for
that kind of synchronizing issue so use it instead.
lock debug gives following bug report:
================================================
[ BUG: lock held when returning to user space! ]
3.9.0-rc1+ #38 Tainted: G           O
------------------------------------------------
tzap/4614 is leaving the kernel with locks still held!
1 lock held by tzap/4614:

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] dvb-usb/dvb-usb-v2: use IS_ENABLED
Mauro Carvalho Chehab [Thu, 21 Mar 2013 19:29:36 +0000 (16:29 -0300)]
[media] dvb-usb/dvb-usb-v2: use IS_ENABLED

Instead of checking everywhere there for 3 symbols, use instead
IS_ENABLED macro.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] cx23885: use IS_ENABLED
Mauro Carvalho Chehab [Thu, 21 Mar 2013 19:29:08 +0000 (16:29 -0300)]
[media] cx23885: use IS_ENABLED

Instead of checking everywhere there for 3 symbols, use instead
IS_ENABLED macro.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] tuners: use IS_ENABLED
Mauro Carvalho Chehab [Thu, 21 Mar 2013 19:24:09 +0000 (16:24 -0300)]
[media] tuners: use IS_ENABLED

Instead of checking everywhere there for 3 symbols, use instead
IS_ENABLED macro.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] dvb-frontends: use IS_ENABLED
Mauro Carvalho Chehab [Thu, 21 Mar 2013 19:11:54 +0000 (16:11 -0300)]
[media] dvb-frontends: use IS_ENABLED

Instead of checking everywhere there for 3 symbols, use instead
IS_ENABLED macro.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] hdpvr-video: Use the proper check for I2C support
Mauro Carvalho Chehab [Thu, 21 Mar 2013 18:46:18 +0000 (15:46 -0300)]
[media] hdpvr-video: Use the proper check for I2C support

As reported by Geert Uytterhoeven <geert@linux-m68k.org>:
drivers/media/usb/hdpvr/hdpvr-video.c: warning: "CONFIG_I2C_MODULE" is not defined [-Wundef]

Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Thanks-to: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] dvb_usb_v2: make local function dvb_usb_v2_generic_io() static
Wei Yongjun [Fri, 22 Mar 2013 02:17:18 +0000 (23:17 -0300)]
[media] dvb_usb_v2: make local function dvb_usb_v2_generic_io() static

dvb_usb_v2_generic_io() was not declared. It should be static.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] em28xx: tuner setup is broken after algo_data change
Hans Verkuil [Fri, 22 Mar 2013 12:54:00 +0000 (09:54 -0300)]
[media] em28xx: tuner setup is broken after algo_data change

Commit aab3125c43d8fecc7134e5f1e729fabf4dd196da broke em28xx. I traced
this eventually to the change in what algo_data points to. This pointer
is also passed to em28xx_tuner_callback() through several hidden tuner
layers (yuck!) and that callback was not updated.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] em28xx: Only change I2C bus inside em28xx-i2c
Mauro Carvalho Chehab [Thu, 21 Mar 2013 09:03:27 +0000 (06:03 -0300)]
[media] em28xx: Only change I2C bus inside em28xx-i2c

There's currently a bug on em28xx-i2c that makes it write the
wrong values to register 06, that controlls the I2C bus speed
and bus.

Fix it to change only the I2C bus flag.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] m5602_ov7660: return error at ov7660_init()
Mauro Carvalho Chehab [Fri, 22 Mar 2013 09:51:06 +0000 (06:51 -0300)]
[media] m5602_ov7660: return error at ov7660_init()

It used to be a code that returns arror at ov7660_init.
However, this was removed by changeset c84e412f:

@@ -231,33 +116,40 @@ int ov7660_init(struct sd *sd)
        if (dump_sensor)
                ov7660_dump_registers(sd);

-   err = ov7660_set_gain(&sd->gspca_dev, sensor_settings[GAIN_IDX]);
-   if (err < 0)
-           return err;
+ return 0;
+}

-   err = ov7660_set_auto_white_balance(&sd->gspca_dev,
-           sensor_settings[AUTO_WHITE_BALANCE_IDX]);
-   if (err < 0)
-           return err;

As complained by gcc:
drivers/media/usb/gspca/m5602/m5602_ov7660.c: In function 'ov7660_init':
drivers/media/usb/gspca/m5602/m5602_ov7660.c:99:9: warning: variable 'err' set but not used [-Wunused-but-set-variable]

It should be noticed that the original error code was crappy, as it wasn't
returning any error if sensor init fails.

Fix it by returning an error if the sensor can't be initialized.

Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] siano: remove the ir protocol field
Mauro Carvalho Chehab [Fri, 22 Mar 2013 09:47:07 +0000 (06:47 -0300)]
[media] siano: remove the ir protocol field

This field is unused. Remove it.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] drxk: fix CNR calculus
Mauro Carvalho Chehab [Fri, 22 Mar 2013 09:37:32 +0000 (06:37 -0300)]
[media] drxk: fix CNR calculus

Changeset 8f3741e accidentally broke the CNR estimation. It should
be calculated as "a + b - c". However, previously, the subtraction
by c only occurred if SNR would be positive, due to a bad binding
to DVBv3 API.

This also fixes the following warning:
drivers/media/dvb-frontends/drxk_hard.c:2556:6: warning: variable 'c' set but not used [-Wunused-but-set-variable]

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] siano: use do_div() for 64-bits division
Mauro Carvalho Chehab [Fri, 22 Mar 2013 09:22:45 +0000 (06:22 -0300)]
[media] siano: use do_div() for 64-bits division

As reported by Frank Schäfer <fschaefer.oss@googlemail.com>:
ERROR: "__divdi3" [drivers/media/common/siano/smsdvb.ko] undefined!

Reported-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Tested-by: Gianluca Gennari <gennarone@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] MAINTAINERS: add drivers/media/tuners/it913x*
Antti Palosaari [Sun, 10 Mar 2013 01:58:13 +0000 (22:58 -0300)]
[media] MAINTAINERS: add drivers/media/tuners/it913x*

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] af9035: style changes for remote controller polling
Antti Palosaari [Fri, 8 Mar 2013 20:50:21 +0000 (17:50 -0300)]
[media] af9035: style changes for remote controller polling

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] af9035: check I/O errors on IR polling
Antti Palosaari [Fri, 8 Mar 2013 20:39:12 +0000 (17:39 -0300)]
[media] af9035: check I/O errors on IR polling

Use more careful error checks.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] af9033: implement i/o optimized reg table writer
Antti Palosaari [Fri, 8 Mar 2013 19:54:09 +0000 (16:54 -0300)]
[media] af9033: implement i/o optimized reg table writer

Use register address auto increment to reduce I/O when large
register / values tables are written.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] af9033: sleep on attach()
Antti Palosaari [Fri, 8 Mar 2013 02:13:31 +0000 (23:13 -0300)]
[media] af9033: sleep on attach()

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] af9033: move code from it913x to af9033
Antti Palosaari [Fri, 8 Mar 2013 01:18:56 +0000 (22:18 -0300)]
[media] af9033: move code from it913x to af9033

That register is property of demodulator so move it correct place.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] it913x: remove unused af9033 demod tuner config inits
Antti Palosaari [Fri, 8 Mar 2013 00:59:41 +0000 (21:59 -0300)]
[media] it913x: remove unused af9033 demod tuner config inits

Those are demodulator init tables according to used tuner tuner
config. af9033 demod driver does those inits currently and due
to that these duplicate inits could be removed.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] af9033: add IT9135 tuner config "62" init table
Antti Palosaari [Fri, 8 Mar 2013 00:47:20 +0000 (21:47 -0300)]
[media] af9033: add IT9135 tuner config "62" init table

Dumped out from the Windows driver version 12.07.06.1

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] af9033: add IT9135 tuner config "61" init table
Antti Palosaari [Fri, 8 Mar 2013 00:44:30 +0000 (21:44 -0300)]
[media] af9033: add IT9135 tuner config "61" init table

Dumped out from the Windows driver version 12.07.06.1

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] af9033: add IT9135 tuner config "60" init table
Antti Palosaari [Fri, 8 Mar 2013 00:38:00 +0000 (21:38 -0300)]
[media] af9033: add IT9135 tuner config "60" init table

Dumped out from the Windows driver version 12.07.06.1

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] af9033: add IT9135 tuner config "52" init table
Antti Palosaari [Fri, 8 Mar 2013 00:29:05 +0000 (21:29 -0300)]
[media] af9033: add IT9135 tuner config "52" init table

Dumped out from the Windows driver version 12.07.06.1

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] af9033: add IT9135 tuner config "51" init table
Antti Palosaari [Fri, 8 Mar 2013 00:25:16 +0000 (21:25 -0300)]
[media] af9033: add IT9135 tuner config "51" init table

Dumped out from the Windows driver version 12.07.06.1

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] af9033: add IT9135 tuner config "38" init table
Antti Palosaari [Fri, 8 Mar 2013 00:17:55 +0000 (21:17 -0300)]
[media] af9033: add IT9135 tuner config "38" init table

Dumped out from the Windows driver version 12.07.06.1

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] af9035: change dual mode boolean to bit field
Antti Palosaari [Thu, 7 Mar 2013 22:22:52 +0000 (19:22 -0300)]
[media] af9035: change dual mode boolean to bit field

For some reason there seems to be value 0x03 in eeprom for dual mode
(and 0x00 for single mode). Boolean is not always 1 bit wide - it
could be 8 bit wide too. Storing number 0x03 to boolean causes driver
to thing there is 4 tuners in some cases :o
Add also some comments regarding to eeprom.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] af9035: enable remote controller for IT9135 too
Antti Palosaari [Thu, 7 Mar 2013 22:03:06 +0000 (19:03 -0300)]
[media] af9035: enable remote controller for IT9135 too

There is no difference towards AF9035 remote controller, so enable it.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] af9035: set demod TS mode config in read_config()
Antti Palosaari [Thu, 7 Mar 2013 21:43:51 +0000 (18:43 -0300)]
[media] af9035: set demod TS mode config in read_config()

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] af9035: use already detected eeprom base addr
Antti Palosaari [Thu, 7 Mar 2013 21:28:25 +0000 (18:28 -0300)]
[media] af9035: use already detected eeprom base addr

eeprom memory mapped base address is detected at the very first.
Use it everywhere.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] af9035: select firmware loader according to firmware
Antti Palosaari [Thu, 7 Mar 2013 20:59:55 +0000 (17:59 -0300)]
[media] af9035: select firmware loader according to firmware

AF9035 and IT9135 supports two different firmware format. Select
correct loader according to first byte of firmware file.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] it913x: remove demod init reg tables
Antti Palosaari [Thu, 7 Mar 2013 03:09:36 +0000 (00:09 -0300)]
[media] it913x: remove demod init reg tables

These are demod inits and are already done by af9033 demod driver.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] af9033: add IT9135 demod reg init tables
Antti Palosaari [Thu, 7 Mar 2013 03:03:06 +0000 (00:03 -0300)]
[media] af9033: add IT9135 demod reg init tables

Dumped out from Windows driver version 12.07.06.1, 07/06/2012.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] it913x: use dev_foo() logging
Antti Palosaari [Thu, 28 Feb 2013 23:54:44 +0000 (20:54 -0300)]
[media] it913x: use dev_foo() logging

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] it913x: include tuner IDs from af9033.h
Antti Palosaari [Thu, 28 Feb 2013 23:14:38 +0000 (20:14 -0300)]
[media] it913x: include tuner IDs from af9033.h

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] it913x: remove unused variables
Antti Palosaari [Thu, 28 Feb 2013 22:02:19 +0000 (19:02 -0300)]
[media] it913x: remove unused variables

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] it913x: get rid of it913x config struct
Antti Palosaari [Thu, 28 Feb 2013 03:14:06 +0000 (00:14 -0300)]
[media] it913x: get rid of it913x config struct

We don't need it. Tuner ID and device address are enough.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] it913x: tuner power up routines
Antti Palosaari [Thu, 28 Feb 2013 02:29:02 +0000 (23:29 -0300)]
[media] it913x: tuner power up routines

Copy forgotten power up registers from it913x-fe driver.
Remove two demod registers as those are already written
by af9033 driver.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] it913x: rename functions and variables
Antti Palosaari [Tue, 26 Feb 2013 23:57:01 +0000 (20:57 -0300)]
[media] it913x: rename functions and variables

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] it913x: merge it913x_fe_suspend() to it913x_fe_sleep()
Antti Palosaari [Tue, 26 Feb 2013 23:42:21 +0000 (20:42 -0300)]
[media] it913x: merge it913x_fe_suspend() to it913x_fe_sleep()

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] it913x: merge it913x_fe_start() to it913x_init_tuner()
Antti Palosaari [Tue, 26 Feb 2013 23:34:06 +0000 (20:34 -0300)]
[media] it913x: merge it913x_fe_start() to it913x_init_tuner()

Merge those functions to one and disable sleep.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] af9035: IT9135 dual tuner related changes
Antti Palosaari [Sun, 3 Feb 2013 16:46:56 +0000 (13:46 -0300)]
[media] af9035: IT9135 dual tuner related changes

Now it supports IT9135 based dual tuner devices.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] af9033: IT9135 v2 supported related changes
Antti Palosaari [Sun, 3 Feb 2013 16:39:55 +0000 (13:39 -0300)]
[media] af9033: IT9135 v2 supported related changes

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] af9035: basic support for IT9135 v2 chips
Antti Palosaari [Sat, 2 Feb 2013 01:23:07 +0000 (22:23 -0300)]
[media] af9035: basic support for IT9135 v2 chips

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] af9035: merge af9035 and it9135 eeprom read routines
Antti Palosaari [Sat, 12 Jan 2013 01:16:25 +0000 (22:16 -0300)]
[media] af9035: merge af9035 and it9135 eeprom read routines

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] af9035: USB1.1 support (== PID filters)
Antti Palosaari [Fri, 11 Jan 2013 23:45:11 +0000 (20:45 -0300)]
[media] af9035: USB1.1 support (== PID filters)

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] af9035: constify clock tables
Antti Palosaari [Fri, 11 Jan 2013 19:34:06 +0000 (16:34 -0300)]
[media] af9035: constify clock tables

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] af9035: [0ccd:0099] TerraTec Cinergy T Stick Dual RC (rev. 2)
Antti Palosaari [Fri, 11 Jan 2013 19:22:07 +0000 (16:22 -0300)]
[media] af9035: [0ccd:0099] TerraTec Cinergy T Stick Dual RC (rev. 2)

That same USB ID is used both AF9015 and AF9035 driver.
iManufacturer is only thing we can select correct driver without a I/O.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] af9015: reject device TerraTec Cinergy T Stick Dual RC (rev. 2)
Antti Palosaari [Mon, 7 Jan 2013 19:29:13 +0000 (16:29 -0300)]
[media] af9015: reject device TerraTec Cinergy T Stick Dual RC (rev. 2)

That same USB ID is used both AF9015 and AF9035 driver.
iManufacturer is only thing we can select correct driver without a I/O.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] af9035: fix af9033 demod sampling frequency
Antti Palosaari [Mon, 7 Jan 2013 18:26:05 +0000 (15:26 -0300)]
[media] af9035: fix af9033 demod sampling frequency

ADC needs to be also multiplied to 2 as it9135.
Fixes bug I introduced few commits ago.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] af9035: add auto configuration heuristic for it9135
Antti Palosaari [Mon, 7 Jan 2013 18:16:54 +0000 (15:16 -0300)]
[media] af9035: add auto configuration heuristic for it9135

Detect automatically multiple chip versions and select configuration
according to that.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] af9035: add support for 1st gen it9135
Antti Palosaari [Mon, 7 Jan 2013 12:51:13 +0000 (09:51 -0300)]
[media] af9035: add support for 1st gen it9135

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] af9033: support for it913x tuners
Antti Palosaari [Mon, 7 Jan 2013 12:48:03 +0000 (09:48 -0300)]
[media] af9033: support for it913x tuners

Add support for tuners integrated to the IT9135 and IT9137.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] ITE IT913X silicon tuner driver
Antti Palosaari [Mon, 7 Jan 2013 12:37:30 +0000 (09:37 -0300)]
[media] ITE IT913X silicon tuner driver

It is tuner driver for tuner integrated to the ITE IT9135 and
IT9137 chips. I split it out from the current it913x-fe driver.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] media/rc/imon.c: avoid flooding syslog with "unknown keypress" when keypad...
Kevin Baradon [Mon, 18 Feb 2013 18:10:22 +0000 (15:10 -0300)]
[media] media/rc/imon.c: avoid flooding syslog with "unknown keypress" when keypad is pressed

My 15c2:0036 device floods syslog when a keypad key is pressed:

Feb 18 19:00:57 homeserver kernel: imon 5-1:1.0: imon_incoming_packet: unknown keypress, code 0x100fff2
Feb 18 19:00:57 homeserver kernel: imon 5-1:1.0: imon_incoming_packet: unknown keypress, code 0x100fef2
Feb 18 19:00:57 homeserver kernel: imon 5-1:1.0: imon_incoming_packet: unknown keypress, code 0x100fff2
Feb 18 19:00:57 homeserver kernel: imon 5-1:1.0: imon_incoming_packet: unknown keypress, code 0x100fff2
Feb 18 19:00:57 homeserver kernel: imon 5-1:1.0: imon_incoming_packet: unknown keypress, code 0x100fff2

This patch removes those messages from imon, following suggestion from
Mauro. Unknown keys shall be correctly handled by rc/input layer.

Signed-off-by: Kevin Baradon <kevin.baradon@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] media/rc/imon.c: make send_packet() delay larger for 15c2:0036
Kevin Baradon [Mon, 18 Feb 2013 17:42:47 +0000 (14:42 -0300)]
[media] media/rc/imon.c: make send_packet() delay larger for 15c2:0036

Some imon devices (like 15c2:0036) need a higher delay between
send_packet calls.

Default value is still 5ms to avoid regressions on already working
hardware.

Also use interruptible wait to avoid load average going too high (and
let caller handle signals).

Signed-off-by: Kevin Baradon <kevin.baradon@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] Corrected Oops on omap_vout when no manager is connected
Federico Fuga [Fri, 24 Aug 2012 14:54:11 +0000 (11:54 -0300)]
[media] Corrected Oops on omap_vout when no manager is connected

If no manager is connected to the vout device, the omapvid_init() function
fails. No error condition is checked, and the device is started. Later on,
when irq is serviced, a NULL pointer dereference occurs.
Also, the isr routine must be registered only if no error occurs, otherwise
the isr triggers without the proper setup, and the kernel oops again.
To prevent this, the error condition is checked, and the streamon function
exits with error. Also the isr registration call is moved after the setup
procedure is completed.

Reviewed-by: Prabhakar Lad <prabhakar.lad@ti.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] xc5000: fix incorrect debug printnk
Dmitri Belimov [Wed, 13 Mar 2013 03:23:36 +0000 (00:23 -0300)]
[media] xc5000: fix incorrect debug printnk

I found very small bug in xc5000 source. When set option debug=1 and
listen a radio we see in dmesg xc5000: xc_SetTVStandard()
Standard = M/N-NTSC/PAL-BTSC at all times. However, it should be, instead
"FM Radio-INPUT1_MONO".

That happens because xc5000_set_radio_freq() gets the correct value for
VideoMode and AudioMode for radio and calls xc_SetTVStandard() where name
of standard comes from the incorrect place priv->video_standard.

This incorrect debug message makes debugging  a little difficult.

Signed-off-by: Dmitry Belimov <d.belimov@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] soc_camera: remove two outdated selects
Paul Bolle [Mon, 11 Mar 2013 21:30:03 +0000 (18:30 -0300)]
[media] soc_camera: remove two outdated selects

Release v2.6.30 removed the MT9M001_PCA9536_SWITCH and
MT9V022_PCA9536_SWITCH Kconfig symbols, in commits
36034dc325ecab63c8cfb992fbf9a1a8e94738a2 ("V4L/DVB (11032): mt9m001:
allow setting of bus width from board code") and
e958e27adeade7fa085dd396a8a0dfaef7e338c1 ("V4L/DVB (11033): mt9v022:
allow setting of bus width from board code").
These two commits removed all gpio related code from these two drivers.
But they skipped removing their two selects of GPIO_PCA953X. Remove
these now as they are outdated. Their dependencies can never evaluate to
true anyhow.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] sh_vou: Use module_platform_driver_probe macro
Sachin Kamat [Tue, 5 Mar 2013 04:53:37 +0000 (01:53 -0300)]
[media] sh_vou: Use module_platform_driver_probe macro

module_platform_driver_probe() eliminates the boilerplate and simplifies
the code.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] sh_veu: Use module_platform_driver_probe macro
Sachin Kamat [Tue, 5 Mar 2013 04:53:36 +0000 (01:53 -0300)]
[media] sh_veu: Use module_platform_driver_probe macro

module_platform_driver_probe() eliminates the boilerplate and simplifies
the code.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] soc_camera/mx1_camera: Use module_platform_driver_probe macro
Sachin Kamat [Tue, 5 Mar 2013 04:53:38 +0000 (01:53 -0300)]
[media] soc_camera/mx1_camera: Use module_platform_driver_probe macro

module_platform_driver_probe() eliminates the boilerplate and simplifies
the code.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] sh_veu.c: Convert to devm_ioremap_resource()
Sachin Kamat [Mon, 4 Mar 2013 08:15:18 +0000 (05:15 -0300)]
[media] sh_veu.c: Convert to devm_ioremap_resource()

Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] soc_camera/pxa_camera: Convert to devm_ioremap_resource()
Sachin Kamat [Mon, 4 Mar 2013 08:15:19 +0000 (05:15 -0300)]
[media] soc_camera/pxa_camera: Convert to devm_ioremap_resource()

Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>