git.proxmox.com Git - mirror

log: remove strerror() from SYSERROR call

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

log: change DEBUG, INFO, TRACE, NOTICE macro using strerror to SYS* macro

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

log: change WARN macro using strerror to SYSWARN

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

commit | commitdiff | tree

Christian Brauner [Mon, 25 Jun 2018 14:16:32 +0000 (16:16 +0200)]

Merge pull request #2429 from 2xsec/bugfix

log: add strerror_r macro

log: add lxc_log_strerror_r macro

Let's ensure that we always use the thread-safe strerror_r() function and add
an approriate macro.
Additionally, define SYS*() macros for all log levels. They will use the new
macro and ensure thread-safe retrieval of errno values.

Signed-off-by: 2xsec <dh48.jeong@samsung.com>
[christian.brauner@ubuntu.com: simplify lxc_log_strerror_r macro]
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Mon, 25 Jun 2018 09:14:21 +0000 (11:14 +0200)]

Merge pull request #2428 from 2xsec/bugfix

move some comments in lxc.spec.in

move some comments in lxc.spec.in

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

commit | commitdiff | tree

Stéphane Graber [Fri, 22 Jun 2018 18:06:53 +0000 (14:06 -0400)]

Merge pull request #2425 from brauner/2018-06-22/cleanups

commands: simplify lxc_cmd()

commit | commitdiff | tree

Christian Brauner [Fri, 22 Jun 2018 14:35:25 +0000 (16:35 +0200)]

Merge pull request #2426 from 2xsec/bugfix

monitor: change exit() => _exit() system call in child process

monitor: change exit() => _exit() system call in child process

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

commit | commitdiff | tree

Christian Brauner [Fri, 22 Jun 2018 12:13:06 +0000 (14:13 +0200)]

commands: simplify lxc_cmd()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Fri, 22 Jun 2018 09:25:19 +0000 (11:25 +0200)]

Merge pull request #2419 from 2xsec/bugfix

secure coding: strcat => strncat

commit | commitdiff | tree

Donghwa Jeong [Fri, 22 Jun 2018 05:56:40 +0000 (14:56 +0900)]

btrfs: add to check return size of strlcat

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

commit | commitdiff | tree

Donghwa Jeong [Thu, 21 Jun 2018 05:36:46 +0000 (14:36 +0900)]

confile: strncat => strlcat

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

commit | commitdiff | tree

Donghwa Jeong [Thu, 21 Jun 2018 04:31:43 +0000 (13:31 +0900)]

utils: strncat => strlcat

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

commit | commitdiff | tree

Donghwa Jeong [Thu, 21 Jun 2018 04:20:17 +0000 (13:20 +0900)]

tool_utils: strncat => strlcat

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

commit | commitdiff | tree

Donghwa Jeong [Thu, 21 Jun 2018 02:38:51 +0000 (11:38 +0900)]

pam_cgfs: strncat => strlcat

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

commit | commitdiff | tree

Donghwa Jeong [Thu, 21 Jun 2018 02:30:18 +0000 (11:30 +0900)]

conf: strncat => strlcat

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

commit | commitdiff | tree

Donghwa Jeong [Thu, 21 Jun 2018 02:06:04 +0000 (11:06 +0900)]

cgfsng: strncat => strlcat

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

commit | commitdiff | tree

Donghwa Jeong [Thu, 21 Jun 2018 01:58:31 +0000 (10:58 +0900)]

btrfs: fix wrong buffer size to append string

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

commit | commitdiff | tree

Donghwa Jeong [Wed, 20 Jun 2018 09:34:24 +0000 (18:34 +0900)]

secure coding: cgfsng: strncat, strlcpy

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

commit | commitdiff | tree

Donghwa Jeong [Wed, 20 Jun 2018 05:52:42 +0000 (14:52 +0900)]

secure coding: strcat => strncat

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

commit | commitdiff | tree

Stéphane Graber [Wed, 20 Jun 2018 16:12:54 +0000 (12:12 -0400)]

Merge pull request #2423 from brauner/2018-06-20/fix_arch

btrfs: s/strncat()/strlcat()/g

commit | commitdiff | tree

Christian Brauner [Wed, 20 Jun 2018 15:53:19 +0000 (17:53 +0200)]

btrfs: s/strncat()/strlcat()/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Wed, 20 Jun 2018 15:24:52 +0000 (17:24 +0200)]

Merge pull request #2422 from monstermunchkin/fix/busybox-template

templates: Fix busybox template

commit | commitdiff | tree

Stéphane Graber [Wed, 20 Jun 2018 14:57:12 +0000 (10:57 -0400)]

Merge pull request #2420 from brauner/2018-06-20/strlcat

include: add strlcat() implementation

templates: Fix busybox template

Use `busybox --list`, and exclude the `busybox` applet if necessary.

Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>

commit | commitdiff | tree

Christian Brauner [Wed, 20 Jun 2018 11:44:02 +0000 (13:44 +0200)]

include: add strlcat() implementation

CC: Donghwa Jeong <dh48.jeong@samsung.com>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Tue, 19 Jun 2018 09:30:57 +0000 (11:30 +0200)]

Merge pull request #2418 from 2xsec/bugfix

fix fd handle leak

commit | commitdiff | tree

Donghwa Jeong [Tue, 19 Jun 2018 01:37:47 +0000 (10:37 +0900)]

fix pointer c is dereferenced after checking null

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

commit | commitdiff | tree

Donghwa Jeong [Tue, 19 Jun 2018 01:27:33 +0000 (10:27 +0900)]

fix fd handle leak

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

commit | commitdiff | tree

Christian Brauner [Mon, 18 Jun 2018 09:42:59 +0000 (11:42 +0200)]

Merge pull request #2417 from 2xsec/bugfix

secure coding: #3 strcpy => strlcpy

commit | commitdiff | tree

Donghwa Jeong [Mon, 18 Jun 2018 09:21:23 +0000 (18:21 +0900)]

secure coding: #3 strcpy => strlcpy

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

commit | commitdiff | tree

Christian Brauner [Mon, 18 Jun 2018 09:14:23 +0000 (11:14 +0200)]

Merge pull request #2416 from 2xsec/bugfix

conf: remove unused argument

commit | commitdiff | tree

Christian Brauner [Mon, 18 Jun 2018 08:56:53 +0000 (10:56 +0200)]

Merge pull request #2415 from 2xsec/bugfix

secure coding: #2 strcpy => strlcpy

commit | commitdiff | tree

Donghwa Jeong [Mon, 18 Jun 2018 08:47:33 +0000 (17:47 +0900)]

conf: remove unused argument

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

commit | commitdiff | tree

Donghwa Jeong [Mon, 18 Jun 2018 08:18:14 +0000 (17:18 +0900)]

secure coding: #2 strcpy => strlcpy

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

commit | commitdiff | tree

Christian Brauner [Mon, 18 Jun 2018 08:07:11 +0000 (10:07 +0200)]

Merge pull request #2414 from 2xsec/bugfix

secure coding: strcpy => strlcpy

commit | commitdiff | tree

Donghwa Jeong [Mon, 18 Jun 2018 04:42:48 +0000 (13:42 +0900)]

secure coding: network: strcpy => strlcpy

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

commit | commitdiff | tree

Donghwa Jeong [Mon, 18 Jun 2018 02:30:41 +0000 (11:30 +0900)]

secure coding: strcpy => strlcpy

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

commit | commitdiff | tree

Serge Hallyn [Fri, 15 Jun 2018 12:49:03 +0000 (07:49 -0500)]

Merge pull request #2409 from brauner/2018-06-15/coverity

coverity

commit | commitdiff | tree

Christian Brauner [Fri, 15 Jun 2018 11:37:47 +0000 (13:37 +0200)]

coverity: #1437027

Read from pointer after free

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Fri, 15 Jun 2018 11:36:37 +0000 (13:36 +0200)]

coverity: #1425855

String not null terminated

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Fri, 15 Jun 2018 11:35:09 +0000 (13:35 +0200)]

coverity: #1425789

Unchecked return value from library

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Fri, 15 Jun 2018 11:34:04 +0000 (13:34 +0200)]

coverity: #1425748

Time of check time of use

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Stéphane Graber [Fri, 15 Jun 2018 11:23:26 +0000 (07:23 -0400)]

Merge pull request #2405 from brauner/2018-04-17/getgrgid_r

configure: check for getgrgid_r()

commit | commitdiff | tree

Christian Brauner [Fri, 15 Jun 2018 10:57:36 +0000 (12:57 +0200)]

coverity: #1425850

Insecure temporary file

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Fri, 15 Jun 2018 10:56:19 +0000 (12:56 +0200)]

coverity: #1425846

Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Fri, 15 Jun 2018 10:55:06 +0000 (12:55 +0200)]

coverity: #1425840

Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Fri, 15 Jun 2018 10:50:47 +0000 (12:50 +0200)]

coverity: #1425837

String not null terminated

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Fri, 15 Jun 2018 10:43:48 +0000 (12:43 +0200)]

coverity: #1425825

Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Fri, 15 Jun 2018 10:41:09 +0000 (12:41 +0200)]

coverity: #1425824

Missing break in switch

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Fri, 15 Jun 2018 09:54:14 +0000 (11:54 +0200)]

coverity: #1425819

Resource leak

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Fri, 15 Jun 2018 09:52:04 +0000 (11:52 +0200)]

coverity: #1425818

Dereference after null check

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Fri, 15 Jun 2018 09:49:10 +0000 (11:49 +0200)]

coverity: #1425813

Resource leak

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Fri, 15 Jun 2018 09:47:31 +0000 (11:47 +0200)]

coverity: #1425810

Explicit null dereferenced

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Fri, 15 Jun 2018 09:45:12 +0000 (11:45 +0200)]

coverity: #1425804

Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Fri, 15 Jun 2018 09:43:15 +0000 (11:43 +0200)]

coverity: #1425799

Logically dead code

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Fri, 15 Jun 2018 09:42:18 +0000 (11:42 +0200)]

coverity: #1425793

Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Fri, 15 Jun 2018 09:40:53 +0000 (11:40 +0200)]

coverity: #1425792

Insecure temporary file

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Fri, 15 Jun 2018 09:37:11 +0000 (11:37 +0200)]

coverity: #1425789

Unchecked return value from library

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Fri, 15 Jun 2018 09:35:10 +0000 (11:35 +0200)]

coverity: #1425771

Insecure temporary file

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Fri, 15 Jun 2018 09:33:34 +0000 (11:33 +0200)]

coverity: #1425770

Insecure temporary file

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Fri, 15 Jun 2018 09:29:52 +0000 (11:29 +0200)]

coverity: #1425764

Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Thu, 14 Jun 2018 22:17:01 +0000 (00:17 +0200)]

include: add getgrgid_r()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Fri, 15 Jun 2018 09:12:55 +0000 (11:12 +0200)]

Merge pull request #2406 from 2xsec/bugfix

storage: Resource leak

commit | commitdiff | tree

Donghwa Jeong [Fri, 15 Jun 2018 02:11:48 +0000 (11:11 +0900)]

storage: Resource leak

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

commit | commitdiff | tree

Stéphane Graber [Thu, 14 Jun 2018 23:03:03 +0000 (19:03 -0400)]

Merge pull request #2404 from brauner/2018-06-14/coverity

bugfixes

commit | commitdiff | tree

Christian Brauner [Thu, 14 Jun 2018 20:26:52 +0000 (22:26 +0200)]

parse: fix memory leak

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Thu, 14 Jun 2018 20:17:08 +0000 (22:17 +0200)]

coverity: #1425768

Untrusted array index read

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Thu, 14 Jun 2018 20:10:26 +0000 (22:10 +0200)]

coverity: #1425767

Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Thu, 14 Jun 2018 20:09:14 +0000 (22:09 +0200)]

coverity: #1425766

Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Thu, 14 Jun 2018 20:07:56 +0000 (22:07 +0200)]

coverity: #1425764

Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Thu, 14 Jun 2018 20:05:09 +0000 (22:05 +0200)]

coverity: #1425760

Use of untrusted scalar value

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Thu, 14 Jun 2018 20:00:22 +0000 (22:00 +0200)]

coverity: #1425758

Time of check time of use

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Thu, 14 Jun 2018 19:56:52 +0000 (21:56 +0200)]

coverity: #1425748

Time of check time of use

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Thu, 14 Jun 2018 19:02:46 +0000 (21:02 +0200)]

Merge pull request #2403 from 2xsec/coverity1

coverity: #1425778

coverity: #1425778

Out-of-bounds write

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

commit | commitdiff | tree

Christian Brauner [Thu, 14 Jun 2018 14:20:02 +0000 (16:20 +0200)]

Merge pull request #2402 from 2xsec/coverity1

coverity: #1437017

coverity: #1437017

Uninitialized pointer

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

commit | commitdiff | tree

Christian Brauner [Thu, 14 Jun 2018 11:23:59 +0000 (13:23 +0200)]

Merge pull request #2401 from 2xsec/bugfix

fix getgrgid() thread safe issue

commit | commitdiff | tree

Donghwa Jeong [Thu, 14 Jun 2018 10:06:11 +0000 (19:06 +0900)]

fix getgrgid() thread safe issue

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

commit | commitdiff | tree

Christian Brauner [Thu, 14 Jun 2018 07:17:59 +0000 (09:17 +0200)]

Merge pull request #2400 from 2xsec/bugfix

fix getpwuid() thread safe issue

commit | commitdiff | tree

Christian Brauner [Thu, 14 Jun 2018 06:37:25 +0000 (08:37 +0200)]

Merge pull request #2399 from 2xsec/bugfix

coverity: #1436916

commit | commitdiff | tree

Donghwa Jeong [Thu, 14 Jun 2018 06:32:03 +0000 (15:32 +0900)]

fix getpwuid() thread safe issue

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

commit | commitdiff | tree

Donghwa Jeong [Thu, 14 Jun 2018 01:36:46 +0000 (10:36 +0900)]

coverity: #1436916

Resource leak

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

commit | commitdiff | tree

Christian Brauner [Tue, 12 Jun 2018 13:03:38 +0000 (15:03 +0200)]

pam: fix typo

fixes commit 2dce415b621e ("fix getpwnam() thread safe issue")

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Tue, 12 Jun 2018 09:31:37 +0000 (11:31 +0200)]

Merge pull request #2397 from 2xsec/bugfix

attach: fix double free

commit | commitdiff | tree

Donghwa Jeong [Tue, 12 Jun 2018 09:16:35 +0000 (18:16 +0900)]

attach: fix double free

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

commit | commitdiff | tree

Christian Brauner [Tue, 12 Jun 2018 09:16:01 +0000 (11:16 +0200)]

Merge pull request #2396 from 2xsec/bugfix

fix getpwnam() thread safe issue

commit | commitdiff | tree

Donghwa Jeong [Tue, 12 Jun 2018 08:09:13 +0000 (17:09 +0900)]

fix getpwnam() thread safe issue

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

commit | commitdiff | tree

Stéphane Graber [Mon, 11 Jun 2018 14:56:55 +0000 (10:56 -0400)]

Merge pull request #2395 from brauner/2018-06-11/restore_old_create_behavior

tools: restore lxc-create log behavior

commit | commitdiff | tree

Christian Brauner [Mon, 11 Jun 2018 11:15:48 +0000 (13:15 +0200)]

tools: restore lxc-create log behavior

Older versions of lxc-create used to set log_file to "none" when a log priority
but no log file was specified on the command line. Let's restore this behavior.

Closes #2392.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commit | commitdiff | tree

Christian Brauner [Mon, 11 Jun 2018 10:25:40 +0000 (12:25 +0200)]

Merge pull request #2393 from 2xsec/bugfix

arguments: improve some operations

commit | commitdiff | tree

Christian Brauner [Mon, 11 Jun 2018 10:20:57 +0000 (12:20 +0200)]

Merge pull request #2394 from 2xsec/coverity

coverity: #1425747

commit | commitdiff | tree

Donghwa Jeong [Mon, 11 Jun 2018 06:13:58 +0000 (15:13 +0900)]

coverity: #1425801

Resource leak

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

commit | commitdiff | tree

Donghwa Jeong [Mon, 11 Jun 2018 05:51:16 +0000 (14:51 +0900)]

coverity: #1425781

Resource leak

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

commit | commitdiff | tree

Donghwa Jeong [Mon, 11 Jun 2018 02:24:46 +0000 (11:24 +0900)]

coverity: #1425747

Resource leak

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

commit | commitdiff | tree

Donghwa Jeong [Mon, 11 Jun 2018 02:10:58 +0000 (11:10 +0900)]

arguments: improve some operations

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

commit | commitdiff | tree

Christian Brauner [Sun, 10 Jun 2018 15:34:20 +0000 (17:34 +0200)]

Merge pull request #2389 from 3XX0/terminal-output-processing

terminal: enable local output processing