]> git.proxmox.com Git - pve-manager.git/log
pve-manager.git
5 years agoceph: add MDS create/delete/list API
Thomas Lamprecht [Fri, 23 Nov 2018 11:01:38 +0000 (12:01 +0100)]
ceph: add MDS create/delete/list API

Allow to create, list and destroy and Ceph Metadata Server (MDS) over
the API and the CLI `pveceph` tool.

Besides setting up the local systemd service template and the MDS
data directory we also add a reference to the MDS in the ceph.conf
We note the backing host (node) from the respective MDS and set up a
'mds standby for name' = 'pve' so that the PVE created ones are a
single group. If we decide to add integration for rank/path specific
MDS (possible useful for CephFS with quite a bit of load) then this
may help as a starting point.

On create, check early if a reference already exists in ceph.conf and
abort in that case. If we only see existing data directories later
on we abort but do not remove them, they could well be from an older
manual create - where it's possible dangerous to just remove it. Let
the user handle it themself in that case.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Co-authored-by: Alwin Antreich <a.antreich@proxmox.com>
5 years agoceph: move create/destroy pool to CephTools
Thomas Lamprecht [Fri, 23 Nov 2018 11:01:37 +0000 (12:01 +0100)]
ceph: move create/destroy pool to CephTools

We will reuse this in the future, e.g., when creating a data and
metadata pool for CephFS.

Allow to pass a $rados object (to reuse it, as initializing is not
that cheap) but also create it if it's undefined, fro convenience.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoapi: document default for ceph service start/stop/restart
Thomas Lamprecht [Fri, 23 Nov 2018 11:40:46 +0000 (12:40 +0100)]
api: document default for ceph service start/stop/restart

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agogui: add ceph monitor restart button
Dominik Csapak [Fri, 23 Nov 2018 10:46:45 +0000 (11:46 +0100)]
gui: add ceph monitor restart button

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agogui: add osd restart button
Dominik Csapak [Fri, 23 Nov 2018 10:46:44 +0000 (11:46 +0100)]
gui: add osd restart button

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agoceph: add service restart api call
Dominik Csapak [Fri, 23 Nov 2018 10:46:43 +0000 (11:46 +0100)]
ceph: add service restart api call

like start/stop but for restart, this makes maintenance a bit easier

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agoui: ZFS: don't use gettext for ZFS specific columuns
Thomas Lamprecht [Fri, 23 Nov 2018 06:09:49 +0000 (07:09 +0100)]
ui: ZFS: don't use gettext for ZFS specific columuns

hard to translate sensible and also better for user to have them in
english as much more can be found when searching those specific
terms. To what would one translate CKSUM for example?

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoapi/hardware: fixup: add missing file
Thomas Lamprecht [Thu, 22 Nov 2018 14:05:52 +0000 (15:05 +0100)]
api/hardware: fixup: add missing file

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agobump version to 5.2-13
Thomas Lamprecht [Thu, 22 Nov 2018 14:01:31 +0000 (15:01 +0100)]
bump version to 5.2-13

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agofix #1575: use reboot for node reboot
Thomas Lamprecht [Thu, 22 Nov 2018 13:45:42 +0000 (14:45 +0100)]
fix #1575: use reboot for node reboot

As requested by various users and also for Dominik's upcomming
restart Ceph [Mo, Mgr, ...} series where else two buttons just called
reboot would be exacly besides each other.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agobump version dependency of libpve-common-perl to 5.0-43
Thomas Lamprecht [Thu, 22 Nov 2018 13:23:57 +0000 (14:23 +0100)]
bump version dependency of libpve-common-perl to 5.0-43

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoapi: move PCI from Scan to Hardware path
Thomas Lamprecht [Thu, 22 Nov 2018 13:20:06 +0000 (14:20 +0100)]
api: move PCI from Scan to Hardware path

as discussed[0] lets move this to /nodes/{node}/hardware/pci

Put this in its own subfolder and adapt module names and paths in UI.

[0]: https://pve.proxmox.com/pipermail/pve-devel/2018-November/034694.html
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agogui: let users add PCI devices
Dominik Csapak [Thu, 22 Nov 2018 10:35:46 +0000 (11:35 +0100)]
gui: let users add PCI devices

this enables the gui part to enable the user to add a pci device
via the gui

we disable the button after 4 devices, since that is the maximum
in the backend

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agogui: add qemu/PCIEdit
Dominik Csapak [Thu, 22 Nov 2018 10:35:45 +0000 (11:35 +0100)]
gui: add qemu/PCIEdit

this patch adds the PCIEdit window and InputPanel uses PCISelector
and MDevSelector

when we detect an iommugroup of -1, we put a warning on top to inform
the user that IOMMU is not activated (but let him add the devices
regardless, so that he can use it after IOMMU is activated)

also puts a warning if he selects a device that shares an iommugroup
with a different device (but not the same device with different
function). that detection is not perfect, but we cannot do really
better

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agogui: add MDevSelector
Dominik Csapak [Thu, 22 Nov 2018 10:35:44 +0000 (11:35 +0100)]
gui: add MDevSelector

this is used to select a mediated device type

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agogui: add form/PCISelector
Dominik Csapak [Thu, 22 Nov 2018 10:35:43 +0000 (11:35 +0100)]
gui: add form/PCISelector

this adds a form field for selecting a pci device

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agoapi/Scan: allow to get a PCI device's mediated devices
Dominik Csapak [Thu, 22 Nov 2018 10:35:42 +0000 (11:35 +0100)]
api/Scan: allow to get a PCI device's mediated devices

this is for the gui to be able to select mediated devices
path ist /node/NODE/scan/pci/PCIID/mdev

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agoapi/Scan: allow to scan a nodes PCI devices
Dominik Csapak [Thu, 22 Nov 2018 10:35:41 +0000 (11:35 +0100)]
api/Scan: allow to scan a nodes PCI devices

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agoui: storage/content: reference volid in confirm window and use new task description
Thomas Lamprecht [Thu, 22 Nov 2018 12:27:34 +0000 (13:27 +0100)]
ui: storage/content: reference volid in confirm window and use new task description

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoui: storage/content: jslint and styling fixups
Thomas Lamprecht [Thu, 22 Nov 2018 12:26:56 +0000 (13:26 +0100)]
ui: storage/content: jslint and styling fixups

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoAdd imageRemoveButton
Wolfgang Link [Thu, 22 Nov 2018 10:49:37 +0000 (11:49 +0100)]
Add imageRemoveButton

If an image has a <vmid>  encoded in the image name
and the guest does not exist in the cluster
we can delete it on the GUI.

Also, if a config exists on another node and the storage is local
we can delete.

In all other cases, it is not allowed to delete it.

For safety reason the safe remove windows are used.

5 years agoCephTools: cleanup module usage
Thomas Lamprecht [Tue, 20 Nov 2018 08:34:39 +0000 (09:34 +0100)]
CephTools: cleanup module usage

as done with the api ceph modules:
most of this was imported by just copying without verifying if all is
actually required. Some lost its purpose as we re-used more from our
existing module code base (e.g., pve-common) but wasn't actually
removed.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoapi/Ceph: actually use imported file_{g,s}et_contents
Thomas Lamprecht [Tue, 20 Nov 2018 08:07:39 +0000 (09:07 +0100)]
api/Ceph: actually use imported file_{g,s}et_contents

5 years agoapi/Ceph: cleanup module usage
Thomas Lamprecht [Tue, 20 Nov 2018 07:47:09 +0000 (08:47 +0100)]
api/Ceph: cleanup module usage

most of this was imported by just copying without verifying if all is
actually required. Some lost its purpose as we re-used more from our
existing module code base (e.g., pve-common) but wasn't actually
removed.

As this file includes two perl modules you need to take a bit caution
when looking at this, as some things are used in one module but not
the other - simple grep'ing at this may give false positives.

Also add PVE::API2::Storage use which was missing here.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoapi/CephOSD: cleanup and sort module usage
Thomas Lamprecht [Tue, 20 Nov 2018 07:44:04 +0000 (08:44 +0100)]
api/CephOSD: cleanup and sort module usage

most of this was imported by just copying without verifying if all is
actually required. Some lost its purpose as we re-used more from our
existing module code base (e.g., pve-common) but wasn't actually
removed.

As this file includes two perl modules you need to take a bit caution
when looking at this, as some things are used in one module but not
the other - simple grep'ing at this may give false positives.

Also include the missing IO::File use.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoMove removeButton in a variable
Wolfgang Link [Wed, 21 Nov 2018 16:05:38 +0000 (17:05 +0100)]
Move removeButton in a variable

The move is necessary to hide the removeButton.

5 years agoAdd imagedestroy to SafeDestroy
Wolfgang Link [Wed, 21 Nov 2018 16:05:37 +0000 (17:05 +0100)]
Add imagedestroy to SafeDestroy

5 years agoAdd function guestNode
Wolfgang Link [Wed, 21 Nov 2018 16:05:36 +0000 (17:05 +0100)]
Add function guestNode

This function extracts the node where the guest resists.

5 years agoAdd function storageIsShared
Wolfgang Link [Wed, 21 Nov 2018 16:05:35 +0000 (17:05 +0100)]
Add function storageIsShared

This function extracts the shared flag of the storage state.

5 years agoAdd parameter storage shared
Wolfgang Link [Wed, 21 Nov 2018 16:05:34 +0000 (17:05 +0100)]
Add parameter storage shared

So we know in the content call if storage is shared.
This is used by removeImageButton.

5 years agoui: qemu/HW: menu setDisable mustn't ignore caps
Thomas Lamprecht [Thu, 22 Nov 2018 07:40:15 +0000 (08:40 +0100)]
ui: qemu/HW: menu setDisable mustn't ignore caps

We passed a 'disable' config to those menu items on creation, but
promptly ignored that after the first set_button_status call, which
only checked if it's possible to add another device, but not if our
capabilities heuristic is OK.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoui: lxc/net: s/i.e./e.g./ and transform to emptyText
Thomas Lamprecht [Mon, 19 Nov 2018 11:56:04 +0000 (12:56 +0100)]
ui: lxc/net: s/i.e./e.g./ and transform to emptyText

We want to name an example here, so `e.g.` would be better.

Also show that in the field if empty. No changes to gettext stuff.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agobump version to 5.2-12
Thomas Lamprecht [Mon, 19 Nov 2018 14:11:24 +0000 (15:11 +0100)]
bump version to 5.2-12

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agod/control: bump version dependency for libpve-common-perl
Thomas Lamprecht [Mon, 19 Nov 2018 13:56:59 +0000 (14:56 +0100)]
d/control: bump version dependency for libpve-common-perl

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agorename PVE::API2::Storage::Scan to PVE::API2::Scan
Dominik Csapak [Fri, 16 Nov 2018 15:17:56 +0000 (16:17 +0100)]
rename PVE::API2::Storage::Scan to PVE::API2::Scan

and use it in the API

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agoAPI/Scan: use scan_usb from PVE::SysFSTools
Dominik Csapak [Fri, 16 Nov 2018 15:17:55 +0000 (16:17 +0100)]
API/Scan: use scan_usb from PVE::SysFSTools

the code moved from PVE::Storage there

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agoAPI/Scan: remove unused HTTP::Status module
Dominik Csapak [Fri, 16 Nov 2018 15:17:54 +0000 (16:17 +0100)]
API/Scan: remove unused HTTP::Status module

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agoScan: whitespace fixes
Dominik Csapak [Fri, 16 Nov 2018 15:17:53 +0000 (16:17 +0100)]
Scan: whitespace fixes

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agocopy storage scan API from pve-storage
Dominik Csapak [Fri, 16 Nov 2018 15:17:52 +0000 (16:17 +0100)]
copy storage scan API from pve-storage

this will be used for the api endpoints in the future as
PVE::API2::Scan instead of PVE::API2::Storage::Scan since it will
contain endpoints to other modules (like qemu-server for pci/usb
scanning)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agoui: dc/storage: allow to add CephFS
Thomas Lamprecht [Thu, 15 Nov 2018 12:20:11 +0000 (13:20 +0100)]
ui: dc/storage: allow to add CephFS

Allow to add CephFS storage over GUI. Reuse viewcontroller and model from RBD
to detect if we can do a "hyper-converged" addition (with PVE maintained Ceph)
or if only external is possible.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoui: rbd: storage: obsolete strange getBinds binding assembly
Thomas Lamprecht [Thu, 15 Nov 2018 12:20:10 +0000 (13:20 +0100)]
ui: rbd: storage: obsolete strange getBinds binding assembly

this was added for our (also in other places used):
> xtype: me.isCreate ? 'pveCephPoolSelector' : 'displayfield',
construct. But as displayfield does not has a submitValue setter we
cannot bind it generally.

So add such a setter with a small override and declare the bindings
direct when declaring the items, less side effects and all the
configurations for an item stays in the same place.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoui: storage: RBD: factor out view- model/controler
Thomas Lamprecht [Thu, 15 Nov 2018 12:20:09 +0000 (13:20 +0100)]
ui: storage: RBD: factor out view- model/controler

will be reused for CephFS, look at this with git's ignore whitespace
change flag '-w' to see that the changes consist mostly of indent and
hunk movement changes

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agofix #1224: ui: ACLAdd: allow to filter by username
Thomas Lamprecht [Fri, 16 Nov 2018 11:12:57 +0000 (12:12 +0100)]
fix #1224: ui: ACLAdd: allow to filter by username

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agofix #1358: ui: show clustername besides 'Datacenter' node, if available
Thomas Lamprecht [Fri, 16 Nov 2018 09:00:00 +0000 (10:00 +0100)]
fix #1358: ui: show clustername besides 'Datacenter' node, if available

If we get the cluster name (successful login with '/' Sys.Audit
permissions) then display it in the resource tree's root node.

This updated on login and all ticket refreshs (every 15 minutes).
I currently have no functionallity to refresh it actively on cluster
create over WebUI, as it's not a straight forward change there.
Further, this is something which does not changes often (in
production), and we cannot detect CLI or API triggered (from non-pve
clients) cluster creations anyway.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agofollowup: split up and pull out html tags from gettext
Thomas Lamprecht [Fri, 16 Nov 2018 11:19:50 +0000 (12:19 +0100)]
followup: split up and pull out html tags from gettext

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agofix #1928: ct snapshot: changed rollback message to warning
Tim Marx [Fri, 16 Nov 2018 11:02:43 +0000 (12:02 +0100)]
fix #1928: ct snapshot: changed rollback message to warning

Signed-off-by: Tim Marx <t.marx@proxmox.com>
5 years agod/control: bump version dependency to pve-doc-generator
Thomas Lamprecht [Wed, 14 Nov 2018 15:20:51 +0000 (16:20 +0100)]
d/control: bump version dependency to pve-doc-generator

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoadd help button to 'My Settings' window
David Limbeck [Tue, 13 Nov 2018 12:48:26 +0000 (13:48 +0100)]
add help button to 'My Settings' window

link to 'gui_my_settings' in docs

Signed-off-by: David Limbeck <d.limbeck@proxmox.com>
5 years agoEnable "Discard" option for IDE and SATA drives
Nick Chevsky [Wed, 14 Nov 2018 04:42:05 +0000 (23:42 -0500)]
Enable "Discard" option for IDE and SATA drives

Even though QEMU supports the discard feature for both ATA [1] and
SCSI drives, the "Discard" checkbox in Proxmox VE is artificially
restricted to SCSI drives. This change expands availability of the
"Discard" checkbox to all drive types supported by QEMU, leaving
VirtIO Block as the only remaining exclusion.

Combined with the new "SSD emulation" option [2], enabling discard
on IDE/SATA drives allows reclaiming of free space on thin-provisioned
storage with guests that do not support our SCSI controllers.

[1] https://github.com/qemu/qemu/commit/d353fb72f59cd0e1f67baf773e74719cda761a89
[2] https://git.proxmox.com/?p=pve-manager.git;a=commit;h=f9261fde2134cec35a5ec7c3ebbee5daa4d67ec7

Signed-off-by: Nick Chevsky <nchevsky@gmail.com>
Tested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agofix #1959: remove invalid SLAAC option
David Limbeck [Thu, 25 Oct 2018 09:32:46 +0000 (11:32 +0200)]
fix #1959: remove invalid SLAAC option

nocloud configuration does not support SLAAC option, only static or dhcp
so this option shouldn't be available

Signed-off-by: David Limbeck <d.limbeck@proxmox.com>
5 years agoadd_storage creates only one ceph storage entry
Alwin Antreich [Fri, 9 Nov 2018 16:43:16 +0000 (17:43 +0100)]
add_storage creates only one ceph storage entry

This patch removes the separate storage entries for CT & VM to the same
ceph pool. Instead only one entry is made as we can now map/unmap
volumes actively in pve-container.

Signed-off-by: Alwin Antreich <a.antreich@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoui: node/zfs: fix up order of variable declaration to match grid order
Thomas Lamprecht [Mon, 12 Nov 2018 11:31:44 +0000 (12:31 +0100)]
ui: node/zfs: fix up order of variable declaration to match grid order

It confused me twice and I enabled autoScroll on the wrong component,
so order it as it's layouted and remove the autoscroll completely,
not needed at all...

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoui: node/zfs: fix stretch and scroll in details window
Thomas Lamprecht [Mon, 12 Nov 2018 11:26:38 +0000 (12:26 +0100)]
ui: node/zfs: fix stretch and scroll in details window

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agonode zfs: added panel to window as container for new components
Tim Marx [Mon, 12 Nov 2018 10:41:15 +0000 (11:41 +0100)]
node zfs: added panel to window as container for new components

Signed-off-by: Tim Marx <t.marx@proxmox.com>
5 years agonode zfs: added new component to display additional zfs details
Tim Marx [Mon, 12 Nov 2018 10:41:14 +0000 (11:41 +0100)]
node zfs: added new component to display additional zfs details

 ZFSStatus component got renamed to ZFSDevices to clarify that it only displays
 the device tree of the status command. The newly added component is now named
 ZFSStatus instead.

Signed-off-by: Tim Marx <t.marx@proxmox.com>
5 years agonode zfs: added read, write, cksum fields to device tree
Tim Marx [Mon, 12 Nov 2018 10:41:13 +0000 (11:41 +0100)]
node zfs: added read, write, cksum fields to device tree

Signed-off-by: Tim Marx <t.marx@proxmox.com>
5 years agobump version to 5.2-11
Thomas Lamprecht [Fri, 9 Nov 2018 16:00:30 +0000 (17:00 +0100)]
bump version to 5.2-11

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agofix #1969: increase max unused disks
David Limbeck [Mon, 5 Nov 2018 13:02:16 +0000 (14:02 +0100)]
fix #1969: increase max unused disks

Signed-off-by: David Limbeck <d.limbeck@proxmox.com>
5 years agofollowup: remove unnecessarry new line
Thomas Lamprecht [Fri, 9 Nov 2018 13:47:06 +0000 (14:47 +0100)]
followup: remove unnecessarry new line

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agonode zfs: added check for undefined & new case AVAIL
Tim Marx [Tue, 6 Nov 2018 12:48:48 +0000 (13:48 +0100)]
node zfs: added check for undefined & new case AVAIL

Signed-off-by: Tim Marx <t.marx@proxmox.com>
5 years agofixup: lxc/Resources: add missing trailing semicolon
Thomas Lamprecht [Fri, 9 Nov 2018 13:18:47 +0000 (14:18 +0100)]
fixup: lxc/Resources: add missing trailing semicolon

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agogui: let users edit the vga memory
Dominik Csapak [Fri, 9 Nov 2018 12:31:10 +0000 (13:31 +0100)]
gui: let users edit the vga memory

and show the default for each type of virtual gpu

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agofix mount point/unused disk sorting in Resources.js
David Limbeck [Fri, 9 Nov 2018 11:03:24 +0000 (12:03 +0100)]
fix mount point/unused disk sorting in Resources.js

use the same sort function as for VMs based on group and order

Signed-off-by: David Limbeck <d.limbeck@proxmox.com>
5 years agofix sorting for unused disks in HardwareView.js
David Limbeck [Fri, 9 Nov 2018 11:03:23 +0000 (12:03 +0100)]
fix sorting for unused disks in HardwareView.js

sort everything based on group and order for those with multiple numbered
entries

Signed-off-by: David Limbeck <d.limbeck@proxmox.com>
5 years agoAdd "SSD emulation" property to IDE, SATA, and SCSI drives
Nick Chevsky [Thu, 8 Nov 2018 18:17:19 +0000 (13:17 -0500)]
Add "SSD emulation" property to IDE, SATA, and SCSI drives

When enabled, the "SSD emulation" feature exposes drives as
solid-state (rather than rotational) by enabling the new `ssd`
qm.conf flag [1] on the drives, which in turn sets QEMU's
`rotation_rate` property [2, 3] on the underlying devices.

This change also moves the "Discard" option out of the advanced
section and promotes it to the top of the dialog box, as proposed
by Thomas Lamprecht [4].

[1] https://git.proxmox.com/?p=qemu-server.git;a=commit;h=6c875f9f315f2dc7a0a3a988622c2efdf089b171
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1498042
[3] https://lists.gnu.org/archive/html/qemu-devel/2017-10/msg00698.html
[4] https://pve.proxmox.com/pipermail/pve-devel/2018-November/034327.html

Signed-off-by: Nick Chevsky <nchevsky@gmail.com>
5 years agolxc/Features: not that keyctl is unnecessary for privileged
Thomas Lamprecht [Mon, 5 Nov 2018 12:02:52 +0000 (13:02 +0100)]
lxc/Features: not that keyctl is unnecessary for privileged

So that users are (hopefully) less confused why this is disabled for
privileged CTs. If we get more feature settings which only make
sense for unprivileged or privileged but not both we could split
this into sections which respective headings, but for one only I
didn't wanted to do this - so just add a boxLabel conditionally.

Cc: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agogui: expose lxc features
Dominik Csapak [Mon, 5 Nov 2018 09:07:56 +0000 (10:07 +0100)]
gui: expose lxc features

but constrain editing to root@pam
give a checkbox (for now) for nfs and cifs, but keep all that are manually set

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agovzdump: hook script example: s/openvz/lxc/
Thomas Lamprecht [Mon, 29 Oct 2018 10:09:57 +0000 (11:09 +0100)]
vzdump: hook script example: s/openvz/lxc/

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agofix wrong permissions for subscription info
Dietmar Maurer [Tue, 30 Oct 2018 10:36:14 +0000 (11:36 +0100)]
fix wrong permissions for subscription info

workaround to keep the subscription popup on login even without 'Sys.Audit'
permissions but remove the subscription details in the GUI for unauthorized
users.

5 years agofollow up: cleanup long line
Thomas Lamprecht [Wed, 24 Oct 2018 11:22:58 +0000 (13:22 +0200)]
follow up: cleanup long line

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoadd wipe_disk option when destroying ceph disk
David Limbeck [Wed, 24 Oct 2018 09:45:44 +0000 (11:45 +0200)]
add wipe_disk option when destroying ceph disk

this allows the disk to be reused as ceph disk by zeroing the first 200M
of the destroyed disk. disks are iterated separately from partitions to
prevent duplicate wipes.

Signed-off-by: David Limbeck <d.limbeck@proxmox.com>
5 years agoadd pve-edk2-firmware to pveversion package list
Thomas Lamprecht [Tue, 23 Oct 2018 11:34:26 +0000 (13:34 +0200)]
add pve-edk2-firmware to pveversion package list

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agofixup: Makefile: s/tests/test/
Thomas Lamprecht [Tue, 23 Oct 2018 10:49:10 +0000 (12:49 +0200)]
fixup: Makefile: s/tests/test/

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agodc/user: render user fullnames htmlEncoded
Dominik Csapak [Fri, 19 Oct 2018 10:36:45 +0000 (12:36 +0200)]
dc/user: render user fullnames htmlEncoded

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agobuild: use pve-doc-generator to verify API
Fabian Grünbichler [Wed, 17 Oct 2018 11:02:05 +0000 (13:02 +0200)]
build: use pve-doc-generator to verify API

and move API verification to 'check' target, where it belongs.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
5 years agobuild: use pve-doc-generator for bash-completion
Fabian Grünbichler [Wed, 17 Oct 2018 11:02:04 +0000 (13:02 +0200)]
build: use pve-doc-generator for bash-completion

and bump build-depends accordingly

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
5 years agobuild: set PERL_DOC_INC_DIRS
Fabian Grünbichler [Wed, 17 Oct 2018 11:02:03 +0000 (13:02 +0200)]
build: set PERL_DOC_INC_DIRS

this allows correct builds without pve-manager installed, with a clean
fall-back to the old behaviour in case pve-doc-generator is too old.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
5 years agobuild: pull REPOID into top-level Makefile
Fabian Grünbichler [Wed, 17 Oct 2018 11:02:02 +0000 (13:02 +0200)]
build: pull REPOID into top-level Makefile

otherwise it is missing when building in a clean chroot via a generated
source packages.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
5 years agobuild: cleanup file generation
Fabian Grünbichler [Wed, 17 Oct 2018 11:02:01 +0000 (13:02 +0200)]
build: cleanup file generation

should happen in the default 'all' target, not in 'install'.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
5 years agoclose #584: ui qemu: changed remove unused disk to asynchron call
Tim Marx [Thu, 18 Oct 2018 11:23:28 +0000 (13:23 +0200)]
close #584: ui qemu: changed remove unused disk to asynchron call

Signed-off-by: Tim Marx <t.marx@proxmox.com>
5 years agod/control: add lintian to build depends
Thomas Lamprecht [Wed, 17 Oct 2018 08:07:23 +0000 (10:07 +0200)]
d/control: add lintian to build depends

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agod/control: add libapt-pkg-perl also to build depends
Thomas Lamprecht [Wed, 17 Oct 2018 06:00:59 +0000 (08:00 +0200)]
d/control: add libapt-pkg-perl also to build depends

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoCompleting Build-Depends
Rhonda D'Vine [Thu, 11 Oct 2018 10:05:20 +0000 (12:05 +0200)]
Completing Build-Depends

These were the missing Build-Depends that were needed in building this
package.

Signed-off-by: Rhonda D'Vine <rhonda@proxmox.com>
5 years agoUpdate default CIPHERS to a more current list
Rhonda D'Vine [Thu, 11 Oct 2018 10:05:19 +0000 (12:05 +0200)]
Update default CIPHERS to a more current list

The default CIPHERS allowed for a fair amount of not really considered
secure anymore connections.  This updated cipher list is taken from
mozilla: https://wiki.mozilla.org/Security/Server_Side_TLS

Signed-off-by: Rhonda D'Vine <rhonda@proxmox.com>
5 years agobump version to 5.2-10
Thomas Lamprecht [Tue, 16 Oct 2018 09:57:20 +0000 (11:57 +0200)]
bump version to 5.2-10

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agopvesh: fix bug #1942 - add standard options conditional
Dietmar Maurer [Tue, 16 Oct 2018 08:55:05 +0000 (10:55 +0200)]
pvesh: fix bug #1942 - add standard options conditional

Do not add/extract standard options if the method itself defined properties
using the same names (like 'quiet').

Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
5 years agod/control: bump version dependency for libpve-common-perl
Thomas Lamprecht [Mon, 8 Oct 2018 12:16:11 +0000 (14:16 +0200)]
d/control: bump version dependency for libpve-common-perl

to ensure we have the /etc/hosts inotify read/write, needed for it's
gui part, methods available

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agouse 'die' instead of 'raise_param_exc'
Dietmar Maurer [Mon, 8 Oct 2018 11:14:51 +0000 (13:14 +0200)]
use 'die' instead of 'raise_param_exc'

Because there is not 'config' parameter.

5 years agoAPI2 : Network : add network config reload
Alexandre Derumier [Tue, 2 Oct 2018 07:19:38 +0000 (09:19 +0200)]
API2 : Network : add network config reload

This add a new api to online reload networking configuration
with ifupdown2.

This work with native ifupdown2 modules, as ifupdown2 have
interface dependency relationships.

Some specific interfaces options can't be reloaded online
(because kernel don't implement it), it this case, we ifdown/ifup
theses interfaces. (mainly vxlan interfaces options)

5 years agogui: dc/Tasks.js fix indentation
Dominik Csapak [Fri, 5 Oct 2018 08:19:23 +0000 (10:19 +0200)]
gui: dc/Tasks.js fix indentation

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agogui: dc/Tasks.js fix trailing whitespace
Dominik Csapak [Fri, 5 Oct 2018 08:19:22 +0000 (10:19 +0200)]
gui: dc/Tasks.js fix trailing whitespace

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agomake /etc/hosts editable via gui
Dominik Csapak [Thu, 13 Sep 2018 12:55:56 +0000 (14:55 +0200)]
make /etc/hosts editable via gui

with adding the NodeHostsView to the node tabs

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agoadd /node/{NODE}/hosts API Call
Dominik Csapak [Wed, 12 Sep 2018 08:24:13 +0000 (10:24 +0200)]
add /node/{NODE}/hosts API Call

to get and set the content of /etc/hosts

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agobump version to 5.2-9
Thomas Lamprecht [Thu, 13 Sep 2018 09:43:59 +0000 (11:43 +0200)]
bump version to 5.2-9

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoui: form/VMSelector: use SIMPLE mode for guest checkbox model
Thomas Lamprecht [Tue, 11 Sep 2018 07:48:25 +0000 (09:48 +0200)]
ui: form/VMSelector: use SIMPLE mode for guest checkbox model

Switch the default mode 'MULTI' with 'SIMPLE', the same we use in the
dc/Backup guest selector. It allows to remove the 'checkOnly'
setting, which limited selection and deselection of elements on the
checkbox it self, doing nothing when clicking on rows.

Besides the friendlier and more streamlined UX this actually fixes a
bug in Firefox (confirmed in version 62, possible in other versions
too) where select/deselect di not worked when clicking in the white
area of the checkbox, but only when clicking on the surrounding
padding.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoui: window/BulkAction: remove double '/' in api URL
Thomas Lamprecht [Tue, 11 Sep 2018 07:42:41 +0000 (09:42 +0200)]
ui: window/BulkAction: remove double '/' in api URL

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoswitch MP selector to integer input
Fabian Grünbichler [Wed, 5 Sep 2018 09:37:11 +0000 (11:37 +0200)]
switch MP selector to integer input

instead of combobox - 256 elements are too much.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
5 years agofix #1897: bump max number of mountpoints to 256
Fabian Grünbichler [Wed, 5 Sep 2018 09:37:10 +0000 (11:37 +0200)]
fix #1897: bump max number of mountpoints to 256

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
5 years agod/control: update build dependencies
Thomas Lamprecht [Thu, 6 Sep 2018 04:37:44 +0000 (06:37 +0200)]
d/control: update build dependencies

helpful for easier bootstrapping PVE, e.g., on buster.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agocpumodelselector : add EPYC
Alexandre Derumier [Sun, 2 Sep 2018 05:52:59 +0000 (07:52 +0200)]
cpumodelselector : add EPYC

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>