Add a setting to choose the scale mode of the noVNC pop-up as well as
the embedded console in the content panel to "My Settings". Having both
set to local scaling was the most important use-case for the users. One
setting for both places is the simplest solution making this possible.
The new section (fieldset) makes adding further options such as
"Local Cursor" easy.
Co-developed-by: Thomas Lamprecht <t.lamprecht@proxmox.com> Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Thomas Lamprecht [Fri, 30 Aug 2019 16:55:51 +0000 (18:55 +0200)]
ui: IPRef field: allow all valid IPs, even if not in the store
since commit 1ccb53ecdbd69a0e4c57a6d861da1918d3625e08 from widget
toolkit[0] we enforce by default that an entered value needs to be in
the backing data store, else the field is marked invalid.
But, for the firewall source/destination IP selector we do not care
if it's in the store, which is only loaded for convenience and to
allow selecting defined aliases/ipsets
Dominik Csapak [Thu, 22 Aug 2019 10:26:09 +0000 (12:26 +0200)]
fix #2340: gui: ceph: handle 'null' versions for hosts
the api returns 'null' for a host that is in the crushmap, but
without actual version information, so just check for falsyness instead
of 'undefined', else we run later into javascript exceptions and no
content on the osd page
Stefan Reiter [Wed, 14 Aug 2019 13:36:27 +0000 (15:36 +0200)]
Delete "exclude" when switching a backup job to pool mode
If you updated a job in "exclude" mode with some VMIDs specified to "pool" mode,
the backup job would retain the "exclude" section and thus not back up all VMs.
The GUI misrepresents this, showing that all VMs will be backed up or
straight up break and show "exclude" mode again, with the backend still
being on "pool" - to prevent this, we always delete a jobs "exclude" list
when it's switched to "pool".
Co-authored-by: Tim Marx <t.marx@proxmox.com> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
Stefan Reiter [Mon, 12 Aug 2019 12:50:06 +0000 (14:50 +0200)]
fix #1594: add "Run now" button to cluster backup page
Iterate all (online) nodes client-side and call vzdump with the correct
parameters (according to the job selected) for each one.
Then, show a progress bar in a non-closeable modal-dialog, to ensure the
user stays on the Backup page during the /vzdump API calls. Any errors
that occurred will be displayed in a consolidated message box.
Includes a "confirm" dialog to not accidentally run a potentially large
backup job.
Curiously, the "pve-cluster-backup" data model seems to have been broken
entirely. I'm not sure how it was working before, but the changes in
this patch need it fixed, so include that as well (use "mode" instead of
individual flags + "compress" is not a boolean).
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
Stefan Reiter [Mon, 12 Aug 2019 12:50:07 +0000 (14:50 +0200)]
fix #1594: allow skipping VMIDs on other nodes from API
This was previously gated to CLI only, but it causes a vzdump job
started with the newly introduced "Run Now" button to fail if it
includes VMIDs on other nodes.
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
Dominik Csapak [Thu, 8 Aug 2019 12:28:55 +0000 (14:28 +0200)]
gui: fix html entities in system report file
since the content of the window is encoded with 'Ext.htmlEncode'
we have to decode it with 'Ext.String.htmlDecode' (Ext.htmlDecode is
a deprecated alias for it) before downloading the file
Oguz Bektas [Wed, 24 Jul 2019 15:46:20 +0000 (17:46 +0200)]
ui: login: do not show connection failure as login failure
In case pvedaemon, pveproxy is not running or we get somehow else a
595 response (connection failure), we want to tell this to the user,
since "Login failed" doesn't help.
Handle all connection failures, leave the rest the same. We could go
into more detail (CONNECT_FAILURE, CLIENT_INVALID, LOAD_FAILURE and
SERVER_INVALID), but i didn't see any reason to make all these
distinctions now.
Thomas Lamprecht [Wed, 24 Jul 2019 08:48:15 +0000 (10:48 +0200)]
ui: vm/Hardware: convert more icons from bitmap to font awesome
since commit 03558174ef4f15f542a61584013a195481188e7f we can use the
Font Awesome icons without them being shown in the remove dialog, so
convert more to them - they are vectors and look a bit better.
Also ensure that all icons are rendered as fixed width, with fa-fw
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 23 Jul 2019 14:33:58 +0000 (16:33 +0200)]
ceph: add perl flag GET and PUT call
use PUT for setting or unsetting, as POST/DELETE (like the old node
specific API used) makes no sense. One does not creates or deletes
the flag, they are always here. One just updates their value
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
we want a GET api call where we return all available flags with
description, but the GET 'flags' api call already returns a string
and not an array, so we cannot use that
instead, we add a new api call that returns that feature and
with e.g. pve 7 we can remove the 'flags' api call and
rename 'flags2' to 'flags'
Debian Buster raised the default security level (1 -> 2) for TLS
connections.
This moves from the 80 bit security level to the 112 bit security level
and will require 2048 bit or larger RSA and DHE keys, 224 bit or larger
ECC keys, and SHA-2.
show the difference between a service where the host has outdated
packages, and where only the service runs an outdated version and only
needs to restart
we now traverse the whole tree for the versions and save not only
the maxversion but if we have mixed versions at all
the traversal contains code to inject the host versions into the treenodes
this way we can omit any icon in case everything is on the same level
and if not we:
* show a check at update hosts and services
* show a 'restart' symbol for osds that only need a restart
* show an 'upgrade' symbol (fa-upload) for osds/hosts that need
a package upgrade
Thomas Lamprecht [Fri, 19 Jul 2019 09:05:46 +0000 (11:05 +0200)]
fix #2292: ceph osd create: use size parameter for db/wal
commit 970f96fdbb20d96127ae2d738344f2c5c61b18fc did not account for
getting the correct size parameter from the api call, so we ignored
it always resulting in uses not be able to set an explicit db/wal
size
Originally-fixed-by: Dominik Csapak <d.csapak@proxmox.com> Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
setData on an 'empty' store does not work in extjs debug mode
setting store to '{}' here does create a store on component creation
so the store is not 'empty'
Thomas Lamprecht [Mon, 15 Jul 2019 18:14:37 +0000 (20:14 +0200)]
ui: window/migrate: use space separator between type and VMID
Like previous to commit 9706707d2f87edf123a12951865b667b4b2ce881
which broke this, we have some assumptions in our gui-test/screenshot
automation which lays assumptions on certain window titles, so try to
keep them stable.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
do not warn in case there exist nautilus osds
since the upgrade has to be done by the time a user should add new
osds, it does not make sense to warn in that case
ceph: mon list: show only as running when monitor is quorate
nautilus puts non running monitors also in the monmap, so only show
as running when it has quorum
this is also not 100% correct, but the only 'correct' alternative is
to try and get/parse the systemd status of the units and broadcast it
to the pmxcfs
ui: improve console fallback logic if default is not available
instead of instantly defaulting to novnc when the chosen
default is not available, try the other (better variant)
before falling back to novnc
e.g. having no default set is equivalent to having it set
to xtermjs, and having a vm with spice then previously
defaulted to novnc, now to spice (the reverse is also true)
having spice does not mean it can also have xtermjs, and
we get the information in the status call already
so give the correct parameters to openDefaultConsoleWindow