]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/log
mirror_ubuntu-bionic-kernel.git
10 years agogreybus: uart-gb: a few minor bug fixes
Alex Elder [Mon, 18 Aug 2014 23:25:12 +0000 (18:25 -0500)]
greybus: uart-gb: a few minor bug fixes

Here are a few small bug fixes in uart-gb.c:
    - In wait_serial_change():
        - Return -EINVAL if *none* of the relevant flags are set in
          the "arg" parameter.
        - Balance the spin_lock_irq() with an unlock call (not
          another lock).
        - Rearrange a nested if structure (not a bug fix).
    - In tty_gb_probe():
        - Reset the greybus_device driver data in case of error.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agogreybus: uart-gb: improve minor device number error checking
Alex Elder [Mon, 18 Aug 2014 23:25:11 +0000 (18:25 -0500)]
greybus: uart-gb: improve minor device number error checking

When alloc_minor() finds an available minor device number it
does not constrain the highest number desired.  Instead, it
relies on its caller, tty_gb_probe() to see if the returned
number indicates all minor numbers have been exhausted.

There are a couple problems with this--or rather with this
code.

First, if an allocation is attempted *after* GB_NUM_MINORS
is returned, a new number greater than (but not equal to)
GB_NUM_MINORS will be allocated, and that won't produce
any error condition.

Second, alloc_minor() can return an error code (like -ENOMEM).  And
its caller is only checking for GB_NUM_MINORS.  If an error code
is returned, tty_gb_probe() simply uses it.

Change alloc_minor() so it requests minor device numbers in the
range 0..(GB_NUM_MINORS-1), and use an error return to detect
when the minor device numbers have been exhausted.

If alloc_minor() returns -ENOSPC (from idr_alloc()), translate that
to -ENODEV.  The only other error we might see is -ENOMEM, and if
we get that, return it.

Finally, zero gb_tty->minor when it's released.  (If this is
actually important a reserved value like GB_NUM_MINORS should
be used instead to signify a gb_tty with no minor assigned.)

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agogreybus: uart-gb: now builds, more framework added
Greg Kroah-Hartman [Fri, 15 Aug 2014 11:44:32 +0000 (19:44 +0800)]
greybus: uart-gb: now builds, more framework added

10 years agogreybus: more uart work
Greg Kroah-Hartman [Fri, 15 Aug 2014 10:54:11 +0000 (18:54 +0800)]
greybus: more uart work

10 years agogreybus: uart-gb: more work on tty functions
Greg Kroah-Hartman [Fri, 15 Aug 2014 10:33:33 +0000 (18:33 +0800)]
greybus: uart-gb: more work on tty functions

10 years agogreybus: uart framework added, doesn't build
Greg Kroah-Hartman [Fri, 15 Aug 2014 08:01:23 +0000 (16:01 +0800)]
greybus: uart framework added, doesn't build

10 years agogreybus: gpio-gb.c: it now builds properly
Greg Kroah-Hartman [Tue, 12 Aug 2014 06:41:49 +0000 (14:41 +0800)]
greybus: gpio-gb.c: it now builds properly

10 years agogreybus: gpio driver
Greg Kroah-Hartman [Tue, 12 Aug 2014 04:00:16 +0000 (12:00 +0800)]
greybus: gpio driver

10 years agogreybus: add framework for 'struct gbuf'
Greg Kroah-Hartman [Mon, 11 Aug 2014 11:03:20 +0000 (19:03 +0800)]
greybus: add framework for 'struct gbuf'

This is the equlivant of sk_buf or urbs for Greybus.

10 years agogreybus: Greybus SD/MMC host driver
Greg Kroah-Hartman [Mon, 11 Aug 2014 09:27:22 +0000 (17:27 +0800)]
greybus: Greybus SD/MMC host driver

Need to add specifics, but this should be enough to hook up to the mmc
framework.

10 years agogreybus: greybus.h: tiny coding style cleanups
Greg Kroah-Hartman [Mon, 11 Aug 2014 09:27:07 +0000 (17:27 +0800)]
greybus: greybus.h: tiny coding style cleanups

10 years agogreybus: i2c-gb: actually add the i2c adapter properly...
Greg Kroah-Hartman [Mon, 11 Aug 2014 09:01:15 +0000 (17:01 +0800)]
greybus: i2c-gb: actually add the i2c adapter properly...

10 years agogreybus: update README with info on how to build and contact me.
Greg Kroah-Hartman [Mon, 11 Aug 2014 07:44:51 +0000 (15:44 +0800)]
greybus: update README with info on how to build and contact me.

10 years agogreybus: README and .gitignore updates
Greg Kroah-Hartman [Mon, 11 Aug 2014 07:32:12 +0000 (15:32 +0800)]
greybus: README and .gitignore updates

10 years agogreybus: Import most recent greybus code to new repo.
Greg Kroah-Hartman [Mon, 11 Aug 2014 07:30:45 +0000 (15:30 +0800)]
greybus: Import most recent greybus code to new repo.

10 years agogreybus: Initial commit
Greg Kroah-Hartman [Mon, 11 Aug 2014 07:29:23 +0000 (15:29 +0800)]
greybus: Initial commit