doc: Start talking about useful sysctl's for proper zebra operation

Add some color to useful sysctl's that are needed for FRR proper operation.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>

Merge pull request #8501 from ton31337/fix/replace_community_check

bgpd: Check for flag existense for community instead of `if not NULL`

Merge pull request #8373 from mjstapp/fix_ospf_timeval_dump

ospfd: show seconds in timeval_dump

Merge pull request #8503 from opensourcerouting/one-backtrace-is-enough

lib: 640k backtraces should be enough for everybody

Merge pull request #8511 from idryzhov/doc-fix-ospfd-maxpath

doc: fix ospfd maximum-paths command

Merge pull request #8500 from ton31337/fix/indentation_for_show_ip_bgp_large_community_list_cmd

bgpd: Fix clang-format/indentation for show_ip_bgp_large_community_list_cmd

doc: fix ospfd maximum-paths command

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

lib: fix bogus unlinkat() warning in zlog TLS exit

Only try to unlink the buffer if we actually set it up beforehand...

Signed-off-by: David Lamparter <equinox@diac24.net>

lib: don't print 2 backtraces for crashes

abort() raises SIGABRT, which would confusingly cause a 2nd backtrace to
be printed after the first one...

Signed-off-by: David Lamparter <equinox@diac24.net>

Merge pull request #8502 from ranjanyash54/core_dump

ospf6d: Fix coredump when "no interface IFNAME area <A.B.C.D>" is called

ospf6d: Fix coredump when "no interface IFNAME area <A.B.C.D>" is called

When oi->area == NULL, it tries to print the
interface's area name, but no area is present.
Print the area name from the command argument instead.

Signed-off-by: Yash Ranjan <ranjany@vmware.com>

Merge pull request #8491 from qlyoung/fix-alpine-libelf-dev-build

bgpd: Check for flag existense for community instead of `if not NULL`

Absolutetly cosmetic change, but let it be consistent with other checks
for optional attributes.

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>

bgpd: Fix clang-format/indentation for show_ip_bgp_large_community_list_cmd

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>

Merge pull request #8434 from donaldsharp/python_bullshit

Python pylint stuff

Merge pull request #8490 from qlyoung/fix-bgp-handle-socket-read-errors-in-main-pthread

bgpd: fix uninit value when handling bgp read errs

docker: pin alpine base image to 3.13

'latest' isn't appropriate for us

Signed-off-by: Quentin Young <qlyoung@nvidia.com>

alpine: add missing libelf-dev dependency

Signed-off-by: Quentin Young <qlyoung@nvidia.com>

Merge pull request #8465 from opensourcerouting/vtysh-scan-snafu

fix vtysh_scan SNAFUs

bgpd: fix uninit value when handling bgp read errs

Compiler warns about uninitialized value, although in practice it is
unreachable.

Also updates a function comment explaining what that value does.

Signed-off-by: Quentin Young <qlyoung@nvidia.com>

python: add demo checker tool using frr.xref

More of a demo on what to do with the frr.xref file, but also slightly
useful in finding vtysh SNAFUs :)

Signed-off-by: David Lamparter <equinox@diac24.net>

vtysh: add lib/thread.c to vtysh_scan

Signed-off-by: David Lamparter <equinox@diac24.net>

vtysh: add lib/resolver.c to vtysh_scan

Signed-off-by: David Lamparter <equinox@diac24.net>

vtysh: add lib/spf_backoff.c to vtysh_scan

Signed-off-by: David Lamparter <equinox@diac24.net>

vtysh: add lib/log_vty.c to vtysh_scan

Rather than copying everything over, include the file in vtysh_scan for
automatic pickup.

Signed-off-by: David Lamparter <equinox@diac24.net>

Merge pull request #8483 from opensourcerouting/asan-fix

lib: disable ASAN redzone around xref_p/xref_array

Merge pull request #8437 from donaldsharp/verify_bgp_community_no_sleep

tests: Do not sleep(5) when verifying bgp communities

tests: test_bgp_vrf_dynamic_route_leak_topo1.py was missing a variable

Signed-off-by: Donald Sharp <sharpd@nvidia.com>

tests: Fix test_bgp_multi_vrf_topo2.py string formatting

Signed-off-by: Donald Sharp <sharpd@nvidia.com>

tests: test_bgp_multi_vrf_topo1.py fix formatting issues pointed out by pylint

Signed-off-by: Donald Sharp <sharpd@nvidia.com>

tests: Remove unnecessary formating for strings

Signed-off-by: Donald Sharp <sharpd@nvidia.com>

tests: Remove duplicate functions in python code

We have basically two identical functions in test_bgp_gr_functionality_topo1.py
Fix.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>

Merge pull request #8477 from opensourcerouting/lib-bfd-fix

lib: disable ASAN redzone around xref_p/xref_array

The "xref_p" variables are placed in the "xref_array" section
specifically so they're next to each other and we get an array at the
end.  The ASAN redzone that is inserted around global variables is
breaks that since it'd be inserted before and after each of the array
items.  So disable the ASAN redzone for these variables (and only these
variables, nothing else should be affected.)

Signed-off-by: David Lamparter <equinox@diac24.net>

Merge pull request #8467 from idryzhov/fix-acl-delete

lib: fix access-list deletion

Merge pull request #8469 from mjstapp/fix_bgp_nhg_mpath

bgpd: don't overrun fixed zapi array of nexthops

Merge pull request #8470 from mjstapp/fix_nhrp_cov_socket

nhrpd: fix coverity warning about os_socket()

lib: fix BFD crash on interface removal

- Handle badly formatted messages (don't set `ifp` in that case)
- Handle unread messages (e.g. when family is not don't trigger `assert`)

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

Merge pull request #8003 from donaldsharp/timings

lib: Differentiate between real and cpu bound processes

Merge pull request #8356 from LabNConsulting/working/lb/docker-ci-v2

Merge pull request #8450 from ton31337/feature/frr_history_turn_on_off

vtysh: Set history file on demand

nhrpd: fix coverity warning about os_socket()

Ensure we don't try to use an invalid fd in nhrpd, reported
by coverity.

Signed-off-by: Mark Stapp <mjs@voltanet.io>

bgpd: don't overrun fixed zapi array of nexthops

Avoid overrunning the fixed-size array of nexthops in a
zapi_nhg.

Signed-off-by: Mark Stapp <mjs@voltanet.io>

Merge pull request #8320 from idryzhov/prefix-list-seqnum

lib: remove "ip prefix-list sequence-number" command

lib: fix access-list deletion

Problems with the current implementation:
* Delete hook is called before the deletion of the access-list from the
  master list, which means that daemons processing this hook successfully
  find this access-list, store a pointer to it in their structures, and
  right after that the access-list is freed. Daemons end up having stale
  pointer to the freed structure.
* Route-maps are not notified of the deletion.

This commit fixes both issues.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

Merge pull request #8446 from ton31337/fix/json_output_for_specific_vs_global_should_be_the_same

bgpd: Add `show bgp json detail` command

Merge pull request #8448 from ton31337/feature/show_rpki_state_in_global_show_bgp

bgpd: Show RPKI short state in `show bgp <afi> <safi>`

vtysh: fix extract.pl for commands with "_cmd"

If the command includes `_cmd`, hilarity ensues ;)

Signed-off-by: David Lamparter <equinox@diac24.net>

build: don't use $(top_srcdir) in vtysh_scan

It's not necessary and can confuse scripts.

Signed-off-by: David Lamparter <equinox@diac24.net>

doc: Add `show bgp json detail` command to print more verbose JSON output

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>

bgpd: Add `show bgp json detail` command

Print detailed version for JSON output when dumping ALL BGP table with
`show bgp <afi> <safi> json detail`.

This output should be at some sort of identical to show_ip_bgp_route_cmd.

To avoid breaking backward-compatibility for `show bgp json`, adding
'detail' keyword for that.

In long-term it's easier for operators to compare stuff just looking at global
view instead of per-prefix for details.

Before:

```
],"192.168.100.1/32": [
  {
    "valid":true,
    "bestpath":true,
    "selectionReason":"First path received",
    "pathFrom":"external",
    "prefix":"192.168.100.1",
    "prefixLen":32,
    "network":"192.168.100.1\/32",
    "metric":0,
    "weight":32768,
    "peerId":"(unspec)",
    "path":"",
    "origin":"incomplete",
    "nexthops":[
      {
        "ip":"0.0.0.0",
        "hostname":"exit1-debian-9",
        "afi":"ipv4",
        "used":true
      }
    ]
  }
] }  }
```

After:
```
],"192.168.100.1/32": [
  {
    "aspath":{
      "string":"Local",
      "segments":[
      ],
      "length":0
    },
    "origin":"incomplete",
    "metric":0,
    "weight":32768,
    "valid":true,
    "sourced":true,
    "bestpath":{
      "overall":true,
      "selectionReason":"First path received"
    },
    "lastUpdate":{
      "epoch":1618040124,
      "string":"Sat Apr 10 07:35:24 2021\n"
    },
    "nexthops":[
      {
        "ip":"0.0.0.0",
        "hostname":"exit1-debian-9",
        "afi":"ipv4",
        "metric":0,
        "accessible":true,
        "used":true
      }
    ],
    "peer":{
      "peerId":"0.0.0.0",
      "routerId":"192.168.100.1"
    }
  }
] }  }
```

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>

Merge pull request #8153 from reubendowle/nhrp-multicast

nhrp, ospf: add nhrp multicast for OSPF DMVPN

Merge pull request #8414 from idryzhov/fix-filter-cli

various acl/plist cli fixes

Merge pull request #8431 from ton31337/feature/show_bgp_version_per_prefix

bgpd: Add `show bgp version <version>` command

Merge pull request #8426 from idryzhov/fix-interface-nb-stale-pointers

lib: fix interface nb stale pointers

ospfd: show seconds in timeval_dump

If the number of seconds is < one minute, show seconds and
msecs.

Signed-off-by: Mark Stapp <mjs@voltanet.io>

Merge pull request #8145 from pguibert6WIND/nhrp_use_zebra

nhrp: use zebra

zebra, lib: replace ZEBRA_ROUTE_NEIGH with simplified version

do not add a new route type, and consider 0 as a value meaning
that zebra should be the owner.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

nhrpd: remove useless typedef

this typedef was useless. remote it.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

nhrp, zebra, lib: enforce usage of zapi_neigh_ip structure

zapi_nbr structure is renamed to zapi_neigh_ip.
Initially used to set a neighbor ip entry for gre interfaces, this
structure is used to get events from the zebra layer to nhrp layer.

The ndm state has been added, as it is needed on both sides.
The zebra dplane layer is slightly modified.

Also, to clarify what ZEBRA_NEIGH_ADD/DEL means, a rename is done:
it is called now ZEBRA_NEIGH_IP_ADD/DEL, and it signified that this
zapi interface permits to set link operations by associating ip
addresses to link addresses.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

Merge pull request #8389 from idryzhov/route-map-optimization-nb

lib: convert route-map optimization to NB

Merge pull request #8396 from achernavin22/ospf_fast_hello_show_run

ospfd: fix output of dead-interval in show running

Merge pull request #8288 from qlyoung/readd-space-support-to-find-command

Merge pull request #8100 from qlyoung/remove-sample-conf-files

Merge pull request #8451 from idryzhov/bfdd-fix-cli-show

bfdd: fix nb cli show with defaults

Merge pull request #8453 from idryzhov/bgpd-fix-transactional-cli

bgpd: fix pending commit check

doc: add Ubuntu18.04 and 20.04 container info to building-docker.rst

Signed-off-by: Lou Berger <lberger@labn.net>

*: add initial .travis.yml

   Supports centos7 and 8 docker builds
   and Ubuntu18.04 and 20.04 build and minimal CI

Signed-off-by: Lou Berger <lberger@labn.net>

ubuntu20-ci: create a docker 20.04 container for dev / test / ci

Signed-off-by: Lou Berger <lberger@labn.net>

ubuntu18-ci: create a docker 18.04 container for dev / test / ci

Signed-off-by: Lou Berger <lberger@labn.net>

nhrp: avoid crashing when terminating interface contexts

avoid crashing when terminating interface contexts.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

nhrpd: add a zebra api to configure neighbor table per interface

neighbor table per interface is being configured per interface, via
zebra api.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

doc: Add an option for vtysh to override history file path

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>

vtysh: Set history file on demand

It's sometimes needed to disable logging all FRR commands at all.

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>

bgpd: fix pending commit check

Calling nb_cli_pending_commit_check only makes sense after nb_cli_apply_changes.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

Merge pull request #8421 from opensourcerouting/xrelfo-arm

fix xrelfo on ARM(32) & cross-compile

bfdd: fix nb cli show with defaults

The idea of the "with-defaults" flag is to show the default values for
parameters that were not configured by the user. But bfdd incorrectly
shows the default values for all parameters, including the
user-configured ones.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

lib: fix interface nb stale pointers

The first change in this commit is the processing of the VRF termination.
When we terminate the VRF, we should not delete the underlying interfaces,
because there may be pointers to them in the northbound configuration. We
should move them to the default VRF instead.

Because of the first change, the VRF interface itself is also not deleted
when deleting the VRF. It should be handled in netlink_link_change. This
is done by the second change.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

doc: Add `show [ip] bgp version <version>` command

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>

bgpd: Filter BGP routes by prefix version

The idea is to find out prefixes including specific BGP table version and
above.

Let's say I have a converged network and suddently I noticed a couple of
prefixes seems hijacked.

I want to look what new prefixes arrived with a specific BGP table version.

```
exit1-debian-9# show ip bgp version 8
BGP table version is 9, local router ID is 192.168.100.1, vrf id 0
Default local pref 100, local AS 65534
Status codes:  s suppressed, d damped, h history, * valid, > best, = multipath,
               i internal, r RIB-failure, S Stale, R Removed
Nexthop codes: @NNN nexthop's vrf id, < announce-nh-self
Origin codes:  i - IGP, e - EGP, ? - incomplete

   Network          Next Hop            Metric LocPrf Weight Path
*  192.168.2.0/24   192.168.0.2              0             0 65030 ?
*>                  192.168.0.2              0             0 65030 ?
*  192.168.3.0/24   192.168.0.2              0             0 65030 ?
*>                  192.168.0.2              0             0 65030 ?

Displayed  2 routes and 18 total paths
exit1-debian-9#
```

```
exit1-debian-9# show ip bgp version 8 json
{
 "vrfId": 0,
 "vrfName": "default",
 "tableVersion": 9,
 "routerId": "192.168.100.1",
 "defaultLocPrf": 100,
 "localAS": 65534,
 "routes": { "192.168.2.0/24": [
  {
    "valid":true,
    "pathFrom":"external",
    "prefix":"192.168.2.0",
    "prefixLen":24,
    "network":"192.168.2.0\/24",
    "version":8,
    "metric":0,
    "weight":0,
    "peerId":"2a02:bbd::2",
    "path":"65030",
    "origin":"incomplete",
    "nexthops":[
      {
        "ip":"192.168.0.2",
        "hostname":"home-spine1.donatas.net",
        "afi":"ipv4",
        "used":true
      }
    ]
  },
  {
    "valid":true,
    "bestpath":true,
    "selectionReason":"Neighbor IP",
    "pathFrom":"external",
    "prefix":"192.168.2.0",
    "prefixLen":24,
    "network":"192.168.2.0\/24",
    "version":8,
    "metric":0,
    "weight":0,
    "peerId":"192.168.0.2",
    "path":"65030",
    "origin":"incomplete",
    "nexthops":[
      {
        "ip":"192.168.0.2",
        "hostname":"home-spine1.donatas.net",
        "afi":"ipv4",
        "used":true
      }
    ]
  }
],"192.168.3.0/24": [
  {
    "valid":true,
    "pathFrom":"external",
    "prefix":"192.168.3.0",
    "prefixLen":24,
    "network":"192.168.3.0\/24",
    "version":9,
    "metric":0,
    "weight":0,
    "peerId":"2a02:bbd::2",
    "path":"65030",
    "origin":"incomplete",
    "nexthops":[
      {
        "ip":"192.168.0.2",
        "hostname":"home-spine1.donatas.net",
        "afi":"ipv4",
        "used":true
      }
    ]
  },
  {
    "valid":true,
    "bestpath":true,
    "selectionReason":"Neighbor IP",
    "pathFrom":"external",
    "prefix":"192.168.3.0",
    "prefixLen":24,
    "network":"192.168.3.0\/24",
    "version":9,
    "metric":0,
    "weight":0,
    "peerId":"192.168.0.2",
    "path":"65030",
    "origin":"incomplete",
    "nexthops":[
      {
        "ip":"192.168.0.2",
        "hostname":"home-spine1.donatas.net",
        "afi":"ipv4",
        "used":true
      }
    ]
  }
] }  }

```

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>

tests: Add BGP RPKI show header to outputs

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>

doc: Add BGP RPKI show header to some output examples

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>

bgpd: Show BGP table version which was used for a particular prefix

This is useful to go back in the past and check when was that prefix appeared,
changed, etc.

```
exit1-debian-9# show ip bgp 172.16.16.1/32
BGP routing table entry for 172.16.16.1/32, version 6
Paths: (2 available, best #2, table default)
  Advertised to non peer-group peers:
  home-spine1.donatas.net(192.168.0.2) home-spine1.donatas.net(2a02:bbd::2)
  65030
    192.168.0.2 from home-spine1.donatas.net(2a02:bbd::2) (172.16.16.1)
      Origin incomplete, metric 0, valid, external
      Last update: Thu Apr  8 20:15:25 2021
  65030
    192.168.0.2 from home-spine1.donatas.net(192.168.0.2) (172.16.16.1)
      Origin incomplete, metric 0, valid, external, best (Neighbor IP)
      Last update: Thu Apr  8 20:15:25 2021
exit1-debian-9#
```

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>

bgpd: Show RPKI short state in `show bgp <afi> <safi>`

Just to be more informant, copying from Cisco.

```
exit1-debian-9# sh ip bgp
BGP table version is 4, local router ID is 192.168.100.1, vrf id 0
Default local pref 100, local AS 65534
Status codes:  s suppressed, d damped, h history, * valid, > best, = multipath,
               i internal, r RIB-failure, S Stale, R Removed
Nexthop codes: @NNN nexthop's vrf id, < announce-nh-self
Origin codes:  i - IGP, e - EGP, ? - incomplete
RPKI validation codes: V valid, I invalid, N Not found

   Network          Next Hop            Metric LocPrf Weight Path
N*> 10.0.2.0/24      0.0.0.0                  0         32768 ?
N*> 192.168.0.0/24   0.0.0.0                  0         32768 ?
N*> 192.168.10.0/24  0.0.0.0                  0         32768 ?
N*> 192.168.100.1/32 0.0.0.0                  0         32768 ?

Displayed  4 routes and 4 total paths
```

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>

Merge pull request #8440 from qlyoung/doc-describe-acceptable-commit-messages

doc: describe acceptable commit messages

Merge pull request #8438 from donaldsharp/doc_on_sleep

doc: Check for convergence, not sleep for convergence

Merge pull request #8444 from qlyoung/doc-system-requirements

doc: vaguely describe system requirements

Merge pull request #8445 from qlyoung/doc-bgp-timers

doc: document BGP neighbor timers

doc: document BGP neighbor timers

The keepalive, hold, and connect timers were undocumented.

Signed-off-by: Quentin Young <qlyoung@nvidia.com>

doc: vaguely describe system requirements

Lame attempt at describing the factors involved in choosing resources
for running FRR

Signed-off-by: Quentin Young <qlyoung@nvidia.com>

pceplib: add missing endian.h and config.h

endian.h supplies be*toh() and htobe*() functions.  This fixes the build
on musl libc.  On other systems it seems endian.h comes in transitively
from some other header.

(Also, all .c files should have config.h or zebra.h as the first
include, even if it works without that it's b0rked and only works due to
luck.)

Tested-by: Lucian Cristian <lucian.cristian@gmail.com>
Signed-off-by: David Lamparter <equinox@diac24.net>

Merge pull request #8429 from donaldsharp/markit

Markit

lib, doc: add "route-map NAME optimization" command

Currently we have a "route-map optimization" command which is entered
from inside the route-map entry but actually applies to the whole
route-map. In addition, this command is not shown in the running-config
and not stored to the startup-config during "write".

Let's add a new command on the config node level to control this setting
and show it in the running-config to make possible to save it during
"write".

The old command is saved for the backward compatibility but hidden and
marked as deprecated.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

Merge pull request #8435 from opensourcerouting/ospf-bfd-fix

ospfd: fix crash on interface/vrf removal

build: don't link pathd/path_main.c twice

Can't have things duplicate in libpath.a and pathd directly, they'll
crash into eath other on linking.  No idea why this doesn't error out in
our CI builds, but it definitely breaks LTO builds.

Signed-off-by: David Lamparter <equinox@diac24.net>

tools: add note to users re: frr.conf overwrite

Most software doesn't overwrite its own config files; vtysh's 'wr mem'
may be confusing, so add a note to the config file explaining changes
made may be overwritten.

Signed-off-by: Quentin Young <qlyoung@nvidia.com>

debian: install frr.conf to /etc/frr/

Signed-off-by: Quentin Young <qlyoung@nvidia.com>

*: remove *.conf.sample files

Most of these are many, many years out of date. All of them vary
randomly in quality. They show up by default in packages where they
aren't really useful now that we use integrated config. Remove them.

The useful ones have been moved to the docs.

Signed-off-by: Quentin Young <qlyoung@nvidia.com>

rpm: install frr.conf by default

Signed-off-by: Quentin Young <qlyoung@nvidia.com>

Merge pull request #8427 from mjstapp/fix_pcep_keylen

lib: use platform-neutral value for TCP MD5 signature len