Merge pull request #376 from brauner/2020-03-16/fixes

utils: shut up compiler

utils: shut up compiler

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #375 from brauner/2020-03-16/cgroup_fixes_2

cgroups: remove unused function

cgroups: remove unused function

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #374 from brauner/2020-03-16/cgroup_fixes_2

fixes

tree-wide: fix dot_or_empty()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tree-wide: memory utils improvements

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #372 from brauner/2020-03-16/cgroup_fixes

cgroup_fuse: fix cgroupfs virtualization needed on non-cgns systems

cgroup_fuse: fix cgroupfs virtualization needed on non-cgns systems

This also removes "default_permissions" again.
We can't use default_permissions since we still support systems that
don't have kernels with cgroup namespace support. On such kernels lxcfs
will provide a namespaced cgroup view and needs explicit access helpers
to make that work.
Another reason that came to me is that we can't or at least shouldn't
guarantee that we don't need more complicated access helpers for proc
and sys virtualization in the future.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #371 from brauner/master

bindings: introduce set_signal_handler

bindings: introduce set_signal_handler

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #370 from brauner/2020-03-14/64_t_conversions

test_sigusr2: improve tests

test_sigusr2: improve tests

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #369 from brauner/2020-03-14/64_t_conversions

lxcfs: allow users to switch between virtualization and non-virtualization mode

proc_fuse: remove unused variable

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

test_proc: add SIGUSR2 virtualization switch tests

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

bindings: allow users to switch between virtualization and non-virtualization mode

When LXCFS has a bug and provides wrong or inconsistent values user
often want to turn off virtualization until we have figured out a fix
and rollout an upgrade to reload the shared library. Allow them to
toggle between virtualization mode and non-virtualization mode by
sending SIGUSR2 to lxcfs:

 Kernel supports pidfds
 api_extensions:
 - cgroups
 - sys_cpu_online
 - proc_cpuinfo
 - proc_diskstats
 - proc_loadavg
 - proc_meminfo
 - proc_stat
 - proc_swaps
 - proc_uptime
 - shared_pidns
 - cpuview_daemon
 - loadavg_daemon
 - pidfds
 Switched into non-virtualization mode
 Switched into virtualization mode
 Switched into non-virtualization mode
 Switched into virtualization mode
 Switched into non-virtualization mode

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #368 from brauner/2020-03-14/64_t_conversions

tree-wide: use {u}int64_t types

tree-wide: use {u}int64_t types

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #367 from brauner/master

proc_fuse: port to uint64_t

proc_fuse: port to uint64_t

Using unsigned long and uint64_t is problematic on 32bit.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #366 from stgraber/master

usage: Fix cfs help

usage: Fix lxcfs description

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

usage: Fix cfs help

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

Merge pull request #365 from brauner/master

liblxcfs: handle broken upgrades gracefully

liblxcfs: handle broken upgrade gracefully

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

bindings: make constructor failures non-fatal

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tree-wide: mark lxcfs fuse ops

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #364 from brauner/master

lxcfs: fix shared library reload

bindings: handle current working directory on upgrade

Recenly I've made failures to run the constructor or destructor fatal.
Mostly, because we can't guarantee correct functionality if they fail.
In fact we can't do anything useful at all (Maybe I can come up with
something more useful soon.)
In any case, this surfaced a bug where on systems that replace/delete
the current workding directory of lxcfs will cause the constructor to
crash on reload because the path that getcwd() returns does not exist
anymore. Fix this by always escaping to root after the construtor has
run but also make it optional in case someone is messing with chroot()s
or other things.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tree-wide: add missing O_CLOEXEC

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #363 from brauner/master

configure: add -Wvla and -std=gnu11

configure: add -Wvla and -std=gnu11

Both are standard in LXC for a long time now. And gcc-4.8 which is the
minimal compiler version we require (same as the Linux kernel) deals
with this.

Closes #362.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #361 from 3XX0/unicg_fixups

Unified cgroup fixups

proc_fuse: fix meminfo with unified cgroup layout

Signed-off-by: Jonathan Calmels <jbjcalmels@gmail.com>

proc_cpuview: add minimal support for unified cgroup layout

Signed-off-by: Jonathan Calmels <jbjcalmels@gmail.com>

Release LXCFS 4.0.0

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

Merge pull request #358 from stgraber/master

travis: Enable all architectures

tests: Append to LD_LIBRARY_PATH

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

travis: Pass env through sudo

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

travis: Add uuid-runtime

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

tests: Don't overwrite LD_LIBRARY_PATH

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

gitignore: Add dirstamp

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

tests: Cleanup output

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

travis: Build with prefix

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

travis: Setup clone_children

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

tests: Fix uptime check

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

tests: Fix lxcfs path

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

travis: Run the tests

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

travis: Enable all architectures

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

Merge pull request #360 from brauner/master

fixes

proc_fuse: make sure file is valid

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxcfs: s/disable-cfs/--enable-cfs/g

Switch the logic.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

proc_cpuview: fix /proc/stat cpu virtualization

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

proc_cpuview: cleanup

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

proc_cpuview: cleanup

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #359 from brauner/master

proc_{cpuview,loadavg}: fix signed/unsigned check

proc_cpuview: cleanup

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

proc_cpuview: fix cpuline_in_cpuset()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

proc_{cpuview,loadavg}: fix signed/unsigned check

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #357 from brauner/2020-03-05/bugfixes_2

fixes

proc_fuse: fix identation

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

proc_cpuview: ensure NULL

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

proc_cpuview: fix whitespace error

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

macro: fix log_debug()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tree-wide: fix cpuview virtualisation

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #356 from stgraber/master

Bugfixes

tests: Fix building tests

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

gitignore: Ignore systemd service

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

Merge pull request #355 from brauner/master

lxcfs: fix help output

lxcfs: fix help output

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #354 from brauner/master

fixes

autotools: don't include lxcfs.1

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

utils: remove unused variable

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #353 from brauner/2020-03-05/bugfixes

utils: cleanup

utils: cleanup

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #352 from brauner/2020-03-05/bugfixes

sysfs_fuse: cleanup

sysfs_fuse: cleanup

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #351 from brauner/2020-03-05/bugfixes

fixes

utils: remove used variables and functions

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tree-wide: align lxcfs and lxc licensing

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

autotools: mention that authors can be gathered from git log

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

proc_loadavg: cleanup

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #349 from brauner/2020-03-05/bugfixes

bugfixes

proc_loadavg: use fdopen_cached()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cgroup_utils: only transfer ownership of fd after fdopen() has succeeded

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

proc_fuse: introduce and use fdopen_cached()

Note that in contrast to libc's fdopen() it doesn't consume the fd it is
passed.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

proc_fuse: cleanup

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #348 from brauner/2020-03-05/bugfixes

bugfixes

proc_cpuview: cleanup

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxcfs: use lxcfs_info()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cgroups: remove stray debugging statement

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

bindings: rework initpid_still_valid()

Let it fallback to stat when pidfd_send_signal() is not available.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tree-wide: handle shared pid namespaces

Closes #310.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

proc_fuse: coding style

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

proc_fuse: remove stray logging

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

proc_fuse: remove {} from single-ling if-statement

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

proc_fuse: remove stray logging

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #347 from brauner/2020-03-04/final_fixes

autotools: cleanup

autotools: cleanup

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>