Merge pull request #4151 from Teemperor/FixUninitRead

Fix uninitialized read in parse_cap when libcap is not used

Merge pull request #4161 from srd424/patch-1

Fix errors constructing mount string when extra mount options supplied

Store mount options in correct variable

This was exposed by the fix in the previous commit.

Signed-off-by: srd424 <srd424@users.noreply.github.com>

Fix off-by-one error constructing mount options

This fixes a really subtle off-by-one error constructing overlay mount options if rootfs options are provided and modern overlayfs (i.e. requiring a workdir) is used. We need to allow for the extra "," required to separate the extra options when computing the length!

Signed-off-by: srd424 <srd424@users.noreply.github.com>

Merge pull request #4159 from Blub/meson/statvfs

add check for statvfs

Merge pull request #4158 from brauner/2022-07-01.fixes

start: fix namespace sharing

add check for statvfs

we use HAVE_STATVFS in the code but with meson the check got
lost causing mount_entry to fail to remount some things such
as a bind mount of /dev/fuse via

    lxc.mount.entry = /dev/fuse dev/fuse none bind,create=file 0 0

which would cause the following log messages:

    DEBUG    conf - ../src/lxc/conf.c:mount_entry:2416 - Remounting "/dev/fuse" on "/usr/lib/x86_64-linux-gnu/lxc/rootfs/dev/fuse" to respect bind or remount options
    ERROR    conf - ../src/lxc/conf.c:mount_entry:2459 - Operation not permitted - Failed to mount "/dev/fuse" on "/usr/lib/x86_64-linux-gnu/lxc/rootfs/dev/fuse"

note that the `Flags for ... were ...` line is not showing
up there, which depends on HAVE_STATVFS

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>

Merge pull request #4147 from marcfiu/issue-4026

fix for issue #4026: set broadcast to 0.0.0.0 for /31 and /32

start: fix namespace sharing

Fixes: #4134
Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>

Merge pull request #4157 from brauner/2022-06-30.fixes

conf: fix append_ttyname()

conf: fix append_ttyname()

We appended container_tty= and then used setenv(container_tty, ...)
resulting int container_tty=container_tty=.

Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>

Merge pull request #4154 from brauner/2022-06-29.fixes

conf: startup fixes

start: record inherited namespaces earlier to make it available for idmapped rootfs setup

Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>

start: don't overwrite file descriptors during namespace preservation

Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>

conf: log file descriptors on error during idmapped mount setup

Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>

fix for issue 4026: set broadcast to 0.0.0.0 for /31 and /32

Signed-off-by: Marc E. Fiuczynski <mfiuczyn@akamai.com>

Merge pull request #4153 from brauner/2022-06-21.unprivileged-cgroup2

use systemd dbus StartTransientUnit for unpriv cgroup2

use systemd dbus StartTransientUnit for unpriv cgroup2

If, when init'ing cgroups for a container start, we detect that we
are an unprivileged user on a unified-hierarchy-only system, then we
try to request systemd, through dbus api, to create a new scope for
us with delegation.  Call the cgroup it creates for us P1.  We then
create P1/init, move ourselves into there, so we can enable the
controllers for delegation to P1's children through P1/cgroup.subtree_control.

On attach, we try to request systemd attach us to the container's
scope.  We can't do that ourselves in the normal case, as root owns
our login cgroups.

Create a new command api for the lxc monitor to tell lxc-attach the
systemd scope to which to attach.

Changelog:
 * free cgroup_meta.systemd_scope in lxc_conf_free (Thanks Tycho)
 * fix some indent
 * address some (not all) of brauner's feedback

Signed-off-by: Serge Hallyn <serge@hallyn.com>

Fix uninitialized read in parse_cap when libcap is not used

fuzz-lxc-cgroup-init currently fails for me with the input
```
 lxc.cap.keep=0
```

with this report:

```
==640655==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x833c77 in parse_cap /src/lxc/san_build/../src/lxc/conf.c:3161:6
    #1 0xaa5fd6 in add_cap_entry /src/lxc/san_build/../src/lxc/confile.c:2462:9
    #2 0x9eb69c in set_config_cap_keep /src/lxc/san_build/../src/lxc/confile.c:2503:8
    #3 0x974a76 in parse_line /src/lxc/san_build/../src/lxc/confile.c:3115:9
    #4 0xea8cac in lxc_file_for_each_line_mmap /src/lxc/san_build/../src/lxc/parse.c:123:9
    #5 0x9700a1 in lxc_config_read /src/lxc/san_build/../src/lxc/confile.c:3192:9
    #6 0x4a3b50 in LLVMFuzzerTestOneInput /src/lxc/san_build/../src/tests/fuzz-lxc-cgroup-init.c:40:8
    #7 0x10556e3 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:611:15
    #8 0x1041372 in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:324:6
    #9 0x1046bbc in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:860:9
    #10 0x106f7b2 in main /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerMain.cpp:20:10
    #11 0x7ffff7bc00b2 in __libc_start_main /build/glibc-sMfBJT/glibc-2.31/csu/../csu/libc-start.c:308:16
    #12 0x420a9d in _start (/home/fuzzer/oss-fuzz/build/out/lxc/fuzz-lxc-cgroup-init+0x420a9d)

  Uninitialized value was created by an allocation of 'last_cap' in the stack frame of function 'parse_cap'
    #0 0x832e30 in parse_cap /src/lxc/san_build/../src/lxc/conf.c:3131
```

The reason is that without libcap we parse_cap ends up comparing two
uninitialized values. See the snippet below:

```
int parse_cap(const char *cap_name, __u32 *cap)
{
int ret;
unsigned int res;
__u32 last_cap;

  [...]

ret = lxc_caps_last_cap(&last_cap); // NOTE: 1. Call here.
if (ret) // Not taken as dummy lxc_caps_last_cap returned 0.
return -1;

if ((__u32)res > last_cap) // last_cap is uninitialized.
return -1;

*cap = (__u32)res;
return 0;
}
```

Root cause seems to be that the dummy `lxc_caps_last_cap` returns 0 but
doesn't set the last_cap value. This patch just returns -1 as an error code
to avoid the uninitialized read.

Note: When reproducing the bug you need to compile with O0 and *not* with O1
otherwise you will not see the report.

Signed-off-by: Raphael Isemann <teemperor@gmail.com>

Merge pull request #4149 from petris/lxc_multicall

tools: Provide multicall lxc binary

meson: Set DEVEL flag post release

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

Release LXC 5.0.0

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

tools: Provide multicall lxc binary

Create a binary, which embeds all lxc tools similar way as busybox
embeds its applets. This is handy for embedded systems as it saves
roughly 90% of the disk space.

To disable normal tools and use multicall binary exclusively use the
following meson setup options:
  -Dtools=false -Dtools-multicall=true

Signed-off-by: Petr Malat <oss@malat.biz>

meson: Generate compile commands by iterating over an array

This makes it possible to add a new command without updating multiple
places in the meson file.

Signed-off-by: Petr Malat <oss@malat.biz>

Merge pull request #4148 from stgraber/master

meson: Fix bad strerror_r check

meson: Fix bad strerror_r check

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

Merge pull request #4146 from brauner/2022-06-13.fixes

build: fixes

build: map autotools options to meson options in meson_options.txt

Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>

README: reflect meson in the documentation

Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>

build: add missing memfd-rexec option

Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>

build: support thread-safety enforcement as option

Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>

build: use cc.links() to check for static libcap

Fixes: #4144
Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>

Merge pull request #4142 from brauner/2022-06-09.build.fixes

tests: fix oss-fuzz port to meson

oss-fuzz: cleanup build flags

Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>

oss-fuzz: ensure binaries are zipped

Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>

oss-fuzz: adapt options to oss-fuzz build

Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>

oss-fuzz: handle dependencies

Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>

build: separate oss-fuzz tests from regular test builds

Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>

github/workflows/cifuzz: update to Ubuntu 22.04

Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>

build: add oss-fuzz switch

Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>

build: add seccomp build option

Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>

build: fix build with various options turned off

Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>

build: tweak build flags

Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>

Merge pull request #4141 from lxc/dependabot/github_actions/actions/upload-artifact-3

build(deps): bump actions/upload-artifact from 1 to 3

build(deps): bump actions/upload-artifact from 1 to 3

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 1 to 3.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/v1...v3)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Merge pull request #4140 from turrisxyz/Dependabot-GitHub-Actions

chore: Included githubactions in the dependabot config

chore: Included githubactions in the dependabot config

This should help with keeping the GitHub actions updated on new releases. This will also help with keeping it secure.

Dependabot helps in keeping the supply chain secure https://docs.github.com/en/code-security/dependabot

GitHub actions up to date https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot

https://github.com/ossf/scorecard/blob/main/docs/checks.md#dependency-update-tool
Signed-off-by: naveen <172697+naveensrinivasan@users.noreply.github.com>

Merge pull request #4139 from stgraber/master

Github workflow fixes

github: Fix compiler version task for coverity

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

github: Fix bad syntax in cifuzz

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

Merge pull request #4137 from brauner/2022-06-08.stgraber.master

build: remove autotools and finish meson port

github/workflows/sanitizers: port sanitizers builds to meson

Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>

github/workflows: port all workflows to Ubuntu 22.04

So we have a new enough meson version everywhere.

Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>

github/workflows/cifuzz: ensure necessary paths are added

Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>

github/workflows/build: remove sanitizer build

We have a separate workflow for this.

Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>

github/workflows/build: add -Db_lto_mode=default

Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>

github/workflows/build: install lvvm as well

Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>

oss-fuzz: more meson options

Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>

build: lxc-init doesn't need to build the whole config infra

Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>

build: add additional command line switches

In order to compile for fuzzers where we will need and want to turn a
bunch of things off add command line switches that allow us to do so.

Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>

build: use liblxc_sources everywhere

The old split didn't buy us a lot and causes problems when buidling with
sanitizers enabled so just use the full sources.

Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>

config: make lxc-{containers,net}.in executable

Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>

Merge pull request #4136 from turrisxyz/Pinned-Dependencies-GitHub

chore: Set permissions for GitHub actions

meson: Always defined IS_BIONIC

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

src: Don't use ifdef/defined for config.h

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

github: Update coverity workflow for meson

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

github: Update build test for meson

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

README: Update for meson

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

doc: Update for meson

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

meson: Add basic Makefile

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

Remove autotools

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

chore: Set permissions for GitHub actions

 Restrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in compromising your workflow, they won’t be able to do much.

- Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions

https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs

[Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/)

Signed-off-by: neilnaveen <42328488+neilnaveen@users.noreply.github.com>

Merge pull request #4135 from stgraber/meson

More meson fixes

meson: Fix mntent include condition

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

lxc/rexec: Use HAVE_FEXECVE

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

meson: Add lxcmntent to unmount-namespace hook

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

meson: Add missing prlimit include

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

meson: Only build seccomp and selinux when needed

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

meson: Always define HAVE_LIBURING

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

meson: seccomp is optional

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

meson: Fix on shallow git trees

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

meson: Add bionic detection

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

meson: Fix RPM spec variables

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

meson: Make lxc-user-nic setuid

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

meson: Don't include lxc-test-fuzzers

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

meson: Skip static library when using sanitizer

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

meson: Cleanup and fix includes

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

meson: Add coverity flag

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

Merge pull request #4133 from dasteihn/sta/fallthrough

CODING_STYLE: add forgotten fallthrough

CODING_STYLE: add forgotten fallthrough

Signed-off-by: Philipp Stanner <stanner@posteo.de>

Merge pull request #4130 from stgraber/master

Finalize the meson port

meson: Add RPM spec

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

meson: Rework configuration variables

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

meson: Tweak config for manpages

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

meson: Export more variables to doc

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

meson: Export LXC_DISTRO_SYSCONF

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

Merge pull request #4126 from stgraber/master

Complete meson port

meson: Add apparmor profiles

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

meson: Add sysconfig

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

meson: Add init scripts

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>