]>
git.proxmox.com Git - proxmox.git/log
Wolfgang Bumiller [Sat, 28 Sep 2019 08:10:05 +0000 (10:10 +0200)]
remove async_await feature gate
then we can build with beta as well
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Sat, 28 Sep 2019 07:54:52 +0000 (09:54 +0200)]
fixups for new hyper alpha
Body's Streawm impl was put behind the 'unstable-stream'
feature, so we won't be using it for now.
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Sat, 28 Sep 2019 07:53:40 +0000 (09:53 +0200)]
put api macro crate behind 'api-macro' feature
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Wed, 11 Sep 2019 12:40:42 +0000 (14:40 +0200)]
tools: io::read: introduce read_host_value_boxed
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Wed, 11 Sep 2019 07:26:00 +0000 (09:26 +0200)]
remove Cargo.lock as we currently have no git dependencies
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Fri, 6 Sep 2019 08:08:34 +0000 (10:08 +0200)]
update hyper & tokio to alpha releases
tokio: alpha.2 to alpha.4
hyper: git alpha.0 to crates.io alpha.1
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Fri, 23 Aug 2019 14:47:53 +0000 (16:47 +0200)]
cargo update
Signed-off-by: Wolfgang Bumiller <w.bumiller@errno.eu>
Wolfgang Bumiller [Fri, 23 Aug 2019 14:47:27 +0000 (16:47 +0200)]
tools: tests for static_assert_size macro
Signed-off-by: Wolfgang Bumiller <w.bumiller@errno.eu>
Wolfgang Bumiller [Fri, 23 Aug 2019 09:26:57 +0000 (11:26 +0200)]
tools: add a static size assertion
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Thu, 22 Aug 2019 07:53:39 +0000 (09:53 +0200)]
tools: borrow: use ManuallyDrop
While Option serves a similar purpose, ManuallyDrop is an
api more directed at what we're actually doing here.
Note that Option<Box<>> is sort of guaranteed to have the
same layout as Box<> mostly due to the fact that Box<>
cannot be null, whereas ManuallyDrop is always guaranteed to
be the same layout as the inner type.
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Thu, 22 Aug 2019 07:45:39 +0000 (09:45 +0200)]
[clippy] api: mostly noise reduction
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Thu, 22 Aug 2019 07:42:05 +0000 (09:42 +0200)]
[clippy] tools: lifetimes and constants
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Thu, 22 Aug 2019 07:28:44 +0000 (09:28 +0200)]
[clippy] sys: simplifications and optimizations
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Thu, 22 Aug 2019 07:24:37 +0000 (09:24 +0200)]
[clippy] macro: remaining clippy lints
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Thu, 22 Aug 2019 07:20:28 +0000 (09:20 +0200)]
[clippy] macro: ident implements comparsion with strings
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Thu, 22 Aug 2019 07:15:03 +0000 (09:15 +0200)]
[clippy] api-test: remove unnecessary lifetimes
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Thu, 22 Aug 2019 07:09:41 +0000 (09:09 +0200)]
[clippy] api-test: remaining changes to memory.rs
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Thu, 22 Aug 2019 07:07:07 +0000 (09:07 +0200)]
[clippy] api-test: more int by value passing
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Thu, 22 Aug 2019 07:04:38 +0000 (09:04 +0200)]
[clippy] api-test: simplify some loops
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Thu, 22 Aug 2019 07:02:36 +0000 (09:02 +0200)]
[clippy] api-test: generalize HashSet impls and closure cleanups
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Wed, 21 Aug 2019 14:59:15 +0000 (16:59 +0200)]
[clippy]: api-test: fix unsuffixed memory values
Clippy actually noticed that the else branch was the same as
the one for the 'b' suffix...
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Wed, 21 Aug 2019 14:56:22 +0000 (16:56 +0200)]
[clippy] api-test: use trailing zeros, pattern efficiency
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Wed, 21 Aug 2019 14:53:19 +0000 (16:53 +0200)]
[clippy] api-test: pass Copy integer by value
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Wed, 21 Aug 2019 14:49:12 +0000 (16:49 +0200)]
replace std::mem::uninitialized
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Wed, 21 Aug 2019 10:01:43 +0000 (12:01 +0200)]
tools: fs: rename CreateOptions::empty to new
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Wed, 21 Aug 2019 09:50:32 +0000 (11:50 +0200)]
tools: fs: add create_path and CreateOptions
To allow creating paths recursively with options. (Basically
extends `std::fs::create_dir_all`.)
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Wed, 21 Aug 2019 09:17:11 +0000 (11:17 +0200)]
update nix to 0.15 for mkdirat
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Wed, 21 Aug 2019 08:52:37 +0000 (10:52 +0200)]
tools: fd: improve drop handler and add some helpers
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Wed, 21 Aug 2019 08:15:42 +0000 (10:15 +0200)]
formatting cleanup
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Wed, 21 Aug 2019 08:15:21 +0000 (10:15 +0200)]
tools: fs: import unistd::{Uid,Gid} fully
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Tue, 20 Aug 2019 10:22:13 +0000 (12:22 +0200)]
upgrade to tokio-0.2.0-alpha.2
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Mon, 19 Aug 2019 10:21:04 +0000 (12:21 +0200)]
use tokio's current alpha.1 release
one less git dependency to track for now
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Fri, 16 Aug 2019 11:15:39 +0000 (13:15 +0200)]
cleanup
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Fri, 16 Aug 2019 10:36:27 +0000 (12:36 +0200)]
tools: add borrow::Tied with example docs
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Fri, 16 Aug 2019 10:21:31 +0000 (12:21 +0200)]
api-macro: fix non-async test case after adding verifiers
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Fri, 16 Aug 2019 08:20:26 +0000 (10:20 +0200)]
api-test: update curl examples
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Fri, 16 Aug 2019 08:18:33 +0000 (10:18 +0200)]
macro: functions: call verify() on all parameters
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Fri, 16 Aug 2019 07:49:22 +0000 (09:49 +0200)]
api-test: add a short example shell script for now
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Fri, 16 Aug 2019 07:44:40 +0000 (09:44 +0200)]
api-test: add example with a more complex struct
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Fri, 16 Aug 2019 07:44:25 +0000 (09:44 +0200)]
api: allow () type, but panic when used as CLI input
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Thu, 15 Aug 2019 18:26:18 +0000 (20:26 +0200)]
fixup tests for router change
Signed-off-by: Wolfgang Bumiller <w.bumiller@errno.eu>
Wolfgang Bumiller [Thu, 15 Aug 2019 09:03:10 +0000 (11:03 +0200)]
api-test: add a json-body multi-parameter test method
Signed-off-by: Wolfgang Bumiller <w.bumiller@errno.eu>
Wolfgang Bumiller [Thu, 15 Aug 2019 09:02:08 +0000 (11:02 +0200)]
api: router: return Map on lookup
Instead of a Value, makes it easier to use the parameters
later on.
Signed-off-by: Wolfgang Bumiller <w.bumiller@errno.eu>
Wolfgang Bumiller [Thu, 15 Aug 2019 08:27:25 +0000 (10:27 +0200)]
api-test: comments/cleanup
Signed-off-by: Wolfgang Bumiller <w.bumiller@errno.eu>
Wolfgang Bumiller [Mon, 12 Aug 2019 12:34:23 +0000 (14:34 +0200)]
formatting fixup
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Mon, 12 Aug 2019 12:01:21 +0000 (14:01 +0200)]
macro: support deriving Display for newtypes
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Mon, 12 Aug 2019 12:00:59 +0000 (14:00 +0200)]
macro: fix enum verify method
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Mon, 12 Aug 2019 11:30:34 +0000 (13:30 +0200)]
macro: fixup previous commit: remove hardcoded error
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Mon, 12 Aug 2019 10:00:11 +0000 (12:00 +0200)]
macro: experimental support for enums with values
enum Foo {
Variant1(Type), // allowed
Variant2(Type, Type), // not allowed
Variant3 { name: Type }, // not allowed
}
In the simple case of a single type we simply drop the
automatically derived `FromStr`/`Display` impls and expect
the user to implement them manually, while in the `verify()`
method we simply match on self and forward to the inner
verifier.
So to get "tagged unions" in the API, implement a proper
API type for each variant, then add an enum with 1-tuple
variants.
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Mon, 12 Aug 2019 08:42:18 +0000 (10:42 +0200)]
macro: remove exact futures-preview version
Otherwise we have .16 and .17 in the same project. And we
can't go to .18 currently until hyper/tokio git-master are
in sync again.
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Fri, 9 Aug 2019 10:41:53 +0000 (12:41 +0200)]
formatting cleanup
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Fri, 9 Aug 2019 10:40:43 +0000 (12:40 +0200)]
macro: split enum handler into separate module
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Fri, 9 Aug 2019 10:36:12 +0000 (12:36 +0200)]
macro: split struct handlers into separate submodules
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Fri, 9 Aug 2019 07:18:02 +0000 (09:18 +0200)]
macro: split function handler into separate file
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Fri, 9 Aug 2019 06:44:48 +0000 (08:44 +0200)]
import Cargo.lock
We use some crates from their git-master branch and they can
sometimes conflict, so this should pin working revisions of
all crates.
Furthermore, when we start packaging things we'll need to
keep the lock file around as a reference to know the exact
sources we built packages from.
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Thu, 8 Aug 2019 12:04:27 +0000 (14:04 +0200)]
macro: errors shouldn't discard the code
Otherwise we'll get even more errors.
Consider this example:
#[api(...)]
struct Foo { ... }
impl MyTrait for Foo { ... }
If the #[api] macro fails and does not at least produce the
`struct Foo{}` along with its `compile_error!()` output,
then in addition to our macro errors, we'll see errors about
trying to implement `MyTrait` for an unknown thing called
`Foo`.
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Thu, 8 Aug 2019 11:53:24 +0000 (13:53 +0200)]
macro: implement #[derive(FromStr)] for newtypes
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Thu, 8 Aug 2019 11:13:35 +0000 (13:13 +0200)]
formatting cleanup
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Thu, 8 Aug 2019 11:13:19 +0000 (13:13 +0200)]
cleanup
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Thu, 8 Aug 2019 09:29:12 +0000 (11:29 +0200)]
macro: derive ser/de for newtypes just like structs
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Thu, 8 Aug 2019 09:17:37 +0000 (11:17 +0200)]
macro: make sure errors are separated
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Thu, 8 Aug 2019 09:12:07 +0000 (11:12 +0200)]
macro: factor out newtype handler
Reuse verifier code of structs fields. Add handling of
'validate' methods for fields.
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Thu, 8 Aug 2019 09:09:58 +0000 (11:09 +0200)]
macro: more quote -> quote_spanned changes
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Thu, 8 Aug 2019 09:09:29 +0000 (11:09 +0200)]
macro: remove unused add_verifiers
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Mon, 5 Aug 2019 12:14:09 +0000 (14:14 +0200)]
formatting fixup
make fmt
(cargo fmt --all)
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Mon, 5 Aug 2019 12:13:37 +0000 (14:13 +0200)]
whitespace cleanup
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Mon, 5 Aug 2019 12:12:49 +0000 (14:12 +0200)]
cleanup use statements
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Mon, 5 Aug 2019 12:09:54 +0000 (14:09 +0200)]
cleanup Cargo.toml files
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Mon, 5 Aug 2019 10:46:21 +0000 (12:46 +0200)]
sys: rustfmt workaround
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Mon, 5 Aug 2019 10:36:35 +0000 (12:36 +0200)]
tools: Cargo.toml: cleanup
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Mon, 5 Aug 2019 10:36:24 +0000 (12:36 +0200)]
rename tools::raw to tools::fd
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Dietmar Maurer [Mon, 5 Aug 2019 08:11:45 +0000 (10:11 +0200)]
proxmox-tools/src/lib.rs: fix doc test
Wolfgang Bumiller [Fri, 2 Aug 2019 09:26:40 +0000 (11:26 +0200)]
formatting fixup
add #[rustfmt::skip] to our macros...
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Dietmar Maurer [Sat, 3 Aug 2019 15:00:02 +0000 (17:00 +0200)]
add nodename helper (copied from proxmox-backup)
Dietmar Maurer [Sat, 3 Aug 2019 14:19:11 +0000 (16:19 +0200)]
src/linux/procfs.rs: moved from proxmox-backup
Dietmar Maurer [Sat, 3 Aug 2019 10:21:20 +0000 (12:21 +0200)]
new helper create_dir_chown
moved from proxmox-backup.
Dietmar Maurer [Sat, 3 Aug 2019 09:49:14 +0000 (11:49 +0200)]
src/fs.rs: new module for fs related helpers
Dietmar Maurer [Sat, 3 Aug 2019 07:19:32 +0000 (09:19 +0200)]
add src/linux/magic.rs - moved from proxmox-backup
Wolfgang Bumiller [Thu, 1 Aug 2019 12:40:12 +0000 (14:40 +0200)]
api-test: import struct tests
This is a bigger set of tests for the type-side (mostly for
`struct`s) of the #[api] macro, tasting serialization and
verifiers in various forms.
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Thu, 1 Aug 2019 09:20:10 +0000 (11:20 +0200)]
api: support HashSet<String> as api type
This is just an array of strings in json, or a
semicolon-separated string on the command line.
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Wed, 31 Jul 2019 13:42:05 +0000 (15:42 +0200)]
macro: improve error output
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Wed, 31 Jul 2019 12:39:18 +0000 (14:39 +0200)]
macro: clear a warning
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Wed, 31 Jul 2019 12:35:00 +0000 (14:35 +0200)]
macro: recurse into struct field verifiers
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Wed, 31 Jul 2019 12:32:35 +0000 (14:32 +0200)]
macro: support 'pattern' verifier in structs
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Wed, 31 Jul 2019 09:45:45 +0000 (11:45 +0200)]
tools: add remaining common regexps
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Wed, 31 Jul 2019 09:45:21 +0000 (11:45 +0200)]
tools: add common_regex with IP_REGEX for now
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Tue, 30 Jul 2019 13:20:55 +0000 (15:20 +0200)]
formatting fixup
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Tue, 30 Jul 2019 13:19:51 +0000 (15:19 +0200)]
macro: support serialize_with and deserialize_with
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Tue, 30 Jul 2019 08:33:07 +0000 (10:33 +0200)]
macro: don't enforce the AsOptionStr type on formats
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Tue, 30 Jul 2019 08:06:32 +0000 (10:06 +0200)]
api, macro: implement 'format' verifier for structs
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Mon, 29 Jul 2019 12:40:04 +0000 (14:40 +0200)]
api: macro: implement minimum/maximum_length checks
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Mon, 29 Jul 2019 12:30:32 +0000 (14:30 +0200)]
api: verify: rename Verify to TestMinMax
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Mon, 29 Jul 2019 12:16:04 +0000 (14:16 +0200)]
api: add helper module for verifiers
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Mon, 29 Jul 2019 10:00:51 +0000 (12:00 +0200)]
refactor struct handling
less spaghetti code accumulation, more purpose oriented
functions
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Fri, 19 Jul 2019 13:24:39 +0000 (15:24 +0200)]
macro: disable derive_default for now
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Fri, 19 Jul 2019 13:20:45 +0000 (15:20 +0200)]
macro: fixup: don't create unwanted default impl snippets
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Fri, 19 Jul 2019 13:17:25 +0000 (15:17 +0200)]
macro: partial support for automatic Default derivation
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Fri, 19 Jul 2019 12:50:23 +0000 (14:50 +0200)]
macro: support Option in deserialization
When deserializing we currently expect all fields to be
available, but we actually want Option types to be truly
optional...
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Fri, 19 Jul 2019 12:30:48 +0000 (14:30 +0200)]
formatting cleanup
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Fri, 19 Jul 2019 12:09:15 +0000 (14:09 +0200)]
implement accessors for types with defaults
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>