]> git.proxmox.com Git - cargo.git/log
cargo.git
5 years agoUpdate git2-curl requirement from 0.8.1 to 0.9.0
dependabot[bot] [Fri, 14 Dec 2018 16:30:00 +0000 (16:30 +0000)]
Update git2-curl requirement from 0.8.1 to 0.9.0

Updates the requirements on [git2-curl](https://github.com/alexcrichton/git2-rs) to permit the latest version.
- [Release notes](https://github.com/alexcrichton/git2-rs/releases)
- [Commits](https://github.com/alexcrichton/git2-rs/commits)

Signed-off-by: dependabot[bot] <support@dependabot.com>
5 years agoAuto merge of #6438 - rust-lang:dependabot/cargo/git2-0.8.0, r=alexcrichton
bors [Fri, 14 Dec 2018 15:50:31 +0000 (15:50 +0000)]
Auto merge of #6438 - rust-lang:dependabot/cargo/git2-0.8.0, r=alexcrichton

Update git2 requirement from 0.7.5 to 0.8.0

Updates the requirements on [git2](https://github.com/alexcrichton/git2-rs) to permit the latest version.
<details>
<summary>Commits</summary>

- See full diff in [compare view](https://github.com/alexcrichton/git2-rs/commits/git2-curl-0.8.0)
</details>
<br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>

5 years agoUpdate git2 requirement from 0.7.5 to 0.8.0
dependabot[bot] [Fri, 14 Dec 2018 05:51:03 +0000 (05:51 +0000)]
Update git2 requirement from 0.7.5 to 0.8.0

Updates the requirements on [git2](https://github.com/alexcrichton/git2-rs) to permit the latest version.
- [Release notes](https://github.com/alexcrichton/git2-rs/releases)
- [Commits](https://github.com/alexcrichton/git2-rs/commits/git2-curl-0.8.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
5 years agoAuto merge of #6419 - ehuss:fix-show-errors, r=alexcrichton
bors [Fri, 14 Dec 2018 00:11:15 +0000 (00:11 +0000)]
Auto merge of #6419 - ehuss:fix-show-errors, r=alexcrichton

Display errors when `cargo fix` fails.

It can be difficult to figure out what's wrong when a user reports that `cargo fix` fails. It can be hard to figure out which suggestion caused a compile error, especially if the error is in another file/location.

5 years agoAuto merge of #6434 - ehuss:fix-fix-concurrent, r=dwijnand
bors [Thu, 13 Dec 2018 23:31:39 +0000 (23:31 +0000)]
Auto merge of #6434 - ehuss:fix-fix-concurrent, r=dwijnand

cargo fix: fix targets with shared sources.

If `cargo fix` attempts to fix multiple targets concurrently that have shared
source files, it would apply fixes multiple times causing corruption of the
source code. Fix this by locking on the package path instead of the target
filename, essentially serializing all targets within a package.

Fixes #6415.

5 years agocargo fix: fix targets with shared sources.
Eric Huss [Thu, 13 Dec 2018 22:29:26 +0000 (14:29 -0800)]
cargo fix: fix targets with shared sources.

If `cargo fix` attempts to fix multiple targets concurrently that have shared
source files, it would apply fixes multiple times causing corruption of the
source code. Fix this by locking on the package path instead of the target
filename, essentially serializing all targets within a package.

5 years agoUpdate rustfix to 0.4.4.
Eric Huss [Thu, 13 Dec 2018 22:01:44 +0000 (14:01 -0800)]
Update rustfix to 0.4.4.

5 years agoDisplay errors when `cargo fix` fails.
Eric Huss [Wed, 12 Dec 2018 00:24:20 +0000 (16:24 -0800)]
Display errors when `cargo fix` fails.

It can be difficult to figure out what's wrong when a user reports that
`cargo fix` fails. There's often a large list of warnings, and it can
be hard to figure out which one caused a compile error.

5 years agoAuto merge of #6431 - ehuss:panic-in-panic, r=nrc
bors [Thu, 13 Dec 2018 20:12:04 +0000 (20:12 +0000)]
Auto merge of #6431 - ehuss:panic-in-panic, r=nrc

Fix panic-in-panic in tests.

There are some very rare circumstances that can cause a double panic during
development. For example, `.with_json("")` (or any invalid JSON) will panic, and then the drop
will also panic.  This can cause a confusing SIGILL.

5 years agoFix panic-in-panic in tests.
Eric Huss [Thu, 13 Dec 2018 19:55:38 +0000 (11:55 -0800)]
Fix panic-in-panic in tests.

There are some very rare circumstances that can cause a double panic during
development. For example, `.with_json("")` will panic, and then the drop
will also panic.

5 years agoAuto merge of #6422 - dwijnand:more-rust-2018, r=alexcrichton
bors [Thu, 13 Dec 2018 19:10:10 +0000 (19:10 +0000)]
Auto merge of #6422 - dwijnand:more-rust-2018, r=alexcrichton

More Rust 2018 edition cleanups

None

5 years agoAuto merge of #6429 - dwijnand:cleanup-SourceId-trait-impls, r=alexcrichton
bors [Thu, 13 Dec 2018 16:26:17 +0000 (16:26 +0000)]
Auto merge of #6429 - dwijnand:cleanup-SourceId-trait-impls, r=alexcrichton

Cleanup some trait impls for SourceId

None

5 years agoCleanup some trait impls for SourceId
Dale Wijnand [Sun, 25 Nov 2018 12:15:57 +0000 (12:15 +0000)]
Cleanup some trait impls for SourceId

5 years agoRemove trailing extern crate usage
Dale Wijnand [Wed, 12 Dec 2018 21:20:44 +0000 (21:20 +0000)]
Remove trailing extern crate usage

5 years agoRemove trailing cfg_attr feature = "cargo-clippy" usage
Dale Wijnand [Wed, 12 Dec 2018 21:20:55 +0000 (21:20 +0000)]
Remove trailing cfg_attr feature = "cargo-clippy" usage

5 years agoAuto merge of #6427 - phansch:remove_nightly_check_in_test, r=dwijnand
bors [Thu, 13 Dec 2018 07:40:41 +0000 (07:40 +0000)]
Auto merge of #6427 - phansch:remove_nightly_check_in_test, r=dwijnand

Remove a nightly check from doc tests

None

5 years agoRemove a nightly check from doc tests
Philipp Hansch [Thu, 13 Dec 2018 06:55:08 +0000 (07:55 +0100)]
Remove a nightly check from doc tests

5 years agoAuto merge of #6425 - dwijnand:promote-failure-error, r=alexcrichton
bors [Thu, 13 Dec 2018 06:10:04 +0000 (06:10 +0000)]
Auto merge of #6425 - dwijnand:promote-failure-error, r=alexcrichton

Replace CargoError with failure::Error

None

5 years agoAuto merge of #6426 - dwijnand:allow-testsuite-warnings-in-dev, r=nrc
bors [Thu, 13 Dec 2018 01:10:43 +0000 (01:10 +0000)]
Auto merge of #6426 - dwijnand:allow-testsuite-warnings-in-dev, r=nrc

Allow testsuite warnings in dev

This makes the deny(warnings) in the testsuite conditional on a new
"deny-warnings" feature, that is then enabled in CI.

Ideally I could use the (reasonably well established) CI env var (like
we do for proptests), but I don't know how to get the attribute to be
defined in terms of an env var.

5 years agoAllow testsuite warnings in dev
Dale Wijnand [Thu, 13 Dec 2018 01:00:27 +0000 (01:00 +0000)]
Allow testsuite warnings in dev

This makes the deny(warnings) in the testsuite conditional on a new
"deny-warnings" feature, that is then enabled in CI.

Ideally I could use the (reasonably well established) CI env var (like
we do for proptests), but I don't know how to get the attribute to be
defined in terms of an env var.

5 years agoReplace CargoError with failure::Error
Dale Wijnand [Wed, 12 Dec 2018 23:23:49 +0000 (23:23 +0000)]
Replace CargoError with failure::Error

5 years agoMerge pull request #6371 from matklad/update-dry-run
Nick Cameron [Wed, 12 Dec 2018 21:32:39 +0000 (16:32 -0500)]
Merge pull request #6371 from matklad/update-dry-run

add `--dry-run` option to cargo update

5 years agoAuto merge of #6416 - alexcrichton:idioms, r=dwijnand
bors [Tue, 11 Dec 2018 13:56:34 +0000 (13:56 +0000)]
Auto merge of #6416 - alexcrichton:idioms, r=dwijnand

Migrate to some Rust 2018 idioms

Run a few lints, hand-edit a few things, otherwise try to help push Cargo into the 2018 edition!

5 years agoReformat after idiom lints
Alex Crichton [Tue, 11 Dec 2018 01:58:06 +0000 (17:58 -0800)]
Reformat after idiom lints

5 years agoTurn on Rust 2018 idiom warnings unconditionally
Alex Crichton [Tue, 11 Dec 2018 01:57:10 +0000 (17:57 -0800)]
Turn on Rust 2018 idiom warnings unconditionally

It may take us awhile to get used to them, so let's see how this goes!

5 years agoRun `cargo fix --edition-idioms` and fixup output
Alex Crichton [Tue, 11 Dec 2018 01:55:13 +0000 (17:55 -0800)]
Run `cargo fix --edition-idioms` and fixup output

This gets Cargo passing the `--edition-idioms` lints and more down the
road of the 2018 edition!

5 years agoStart using 2018 idioms in Cargo
Alex Crichton [Sat, 8 Dec 2018 16:19:56 +0000 (08:19 -0800)]
Start using 2018 idioms in Cargo

Remove a number of `extern crate` directives and tweak a number of
imports. Not all `extern crate` is gone yet but this is the bulk of
them!

5 years agoAuto merge of #6417 - alexcrichton:deprecated, r=ehuss
bors [Tue, 11 Dec 2018 03:44:04 +0000 (03:44 +0000)]
Auto merge of #6417 - alexcrichton:deprecated, r=ehuss

Migrate from trim_right to trim_end

The `trim_right` method is soon to be deprecated!

5 years agoAuto merge of #6409 - spk:add-dev-deps-metadata-test, r=ehuss
bors [Tue, 11 Dec 2018 03:16:36 +0000 (03:16 +0000)]
Auto merge of #6409 - spk:add-dev-deps-metadata-test, r=ehuss

Add dev-dependencies test on cargo_metadata_with_deps_and_version

Hi, this just add some test for `dev-dependencies` on metadata with some registery update for others tests `+https://github.com/rust-lang/crates.io-index` (let me know if I should do another PR), cheers

5 years agoMigrate from trim_right to trim_end
Alex Crichton [Tue, 11 Dec 2018 02:00:43 +0000 (18:00 -0800)]
Migrate from trim_right to trim_end

The `trim_right` method is soon to be deprecated!

5 years agoUse correct registry on tests/testsuite/metadata.rs
Laurent Arnoud [Mon, 10 Dec 2018 22:10:43 +0000 (23:10 +0100)]
Use correct registry on tests/testsuite/metadata.rs

5 years agoAuto merge of #6402 - pietroalbini:fix-cargofix, r=alexcrichton
bors [Mon, 10 Dec 2018 03:44:17 +0000 (03:44 +0000)]
Auto merge of #6402 - pietroalbini:fix-cargofix, r=alexcrichton

Only ensure solutions are in the same file in cargo fix

This PR changes `cargo fix` to avoid rejecting machine-applicable lints with multiple suggestions. Instead, now it only checks the solutions are in the same file.

I don't know how to write a test for this, since no lint in rustc relies on the new behavior and the existing `cargo fix` tests just invoke lints in rustc. Any idea on that would be appreciated.

r? @alexcrichton
cc @killercup
fixes https://github.com/rust-lang/cargo/issues/6401

5 years agoAuto merge of #6407 - sinkuu:redundant_clone, r=dwijnand
bors [Sun, 9 Dec 2018 22:59:01 +0000 (22:59 +0000)]
Auto merge of #6407 - sinkuu:redundant_clone, r=dwijnand

Remove redundant clones

5 years agofix: refactor same-file check
Pietro Albini [Sun, 9 Dec 2018 18:24:00 +0000 (19:24 +0100)]
fix: refactor same-file check

Co-Authored-By: Pascal Hertleif <killercup@gmail.com>
5 years agoAuto merge of #6411 - ehuss:fix-bfbo, r=alexcrichton
bors [Sun, 9 Dec 2018 21:09:50 +0000 (21:09 +0000)]
Auto merge of #6411 - ehuss:fix-bfbo, r=alexcrichton

Fix flakey broken_fixes_backed_out test.

Since `fix` does `--all-targets` there is a race condition as to which target goes first. This has less than a 1% failure rate on CI, but it has been seen several times lately:

https://ci.appveyor.com/project/rust-lang-libs/cargo/builds/20878003/job/v01k5j14od50mghw
https://ci.appveyor.com/project/rust-lang-libs/cargo/builds/18699824/job/465w7uav7ew24yka
https://ci.appveyor.com/project/rust-lang-libs/cargo/builds/17283788/job/7cxp8bwm4d3i1xgl

5 years agoFix flakey broken_fixes_backed_out test.
Eric Huss [Sun, 9 Dec 2018 19:59:42 +0000 (11:59 -0800)]
Fix flakey broken_fixes_backed_out test.

Since `fix` does `--all-targets` there is a race condition as to which target goes first. This has less than a 1% failure rate on CI, but it has been seen several times lately:

https://ci.appveyor.com/project/rust-lang-libs/cargo/builds/20878003/job/v01k5j14od50mghw
https://ci.appveyor.com/project/rust-lang-libs/cargo/builds/18699824/job/465w7uav7ew24yka
https://ci.appveyor.com/project/rust-lang-libs/cargo/builds/17283788/job/7cxp8bwm4d3i1xgl

5 years agoMerge pull request #6410 from spk/readme-add-git
Nick Cameron [Sun, 9 Dec 2018 19:20:49 +0000 (14:20 -0500)]
Merge pull request #6410 from spk/readme-add-git

README: add git as required package

5 years agoREADME: add git as required package
Laurent Arnoud [Sun, 9 Dec 2018 18:39:55 +0000 (19:39 +0100)]
README: add git as required package

5 years agoAdd dev-dependencies test on cargo_metadata_with_deps_and_version
Laurent Arnoud [Sun, 9 Dec 2018 18:35:34 +0000 (19:35 +0100)]
Add dev-dependencies test on cargo_metadata_with_deps_and_version

5 years agoRemove redundant clones
Shotaro Yamada [Sun, 9 Dec 2018 13:03:34 +0000 (22:03 +0900)]
Remove redundant clones

5 years agoAuto merge of #6403 - ehuss:doc-config-update, r=alexcrichton
bors [Sun, 9 Dec 2018 02:56:05 +0000 (02:56 +0000)]
Auto merge of #6403 - ehuss:doc-config-update, r=alexcrichton

Minor update to config docs.

5 years agoAuto merge of #6404 - ehuss:fix-install-link, r=alexcrichton
bors [Sun, 9 Dec 2018 02:31:17 +0000 (02:31 +0000)]
Auto merge of #6404 - ehuss:fix-install-link, r=alexcrichton

Fix install link.

The new website broke the old links. They are setting up redirects (https://github.com/rust-lang/www.rust-lang.org/pull/597), but I figured may as well use the new location to avoid the redirect.

5 years agoFix install link.
Eric Huss [Sun, 9 Dec 2018 01:34:48 +0000 (17:34 -0800)]
Fix install link.

The new website broke the old links. They are setting up redirects (https://github.com/rust-lang/www.rust-lang.org/pull/597), but I figured may as well use the new location to avoid the redirect.

5 years agoMinor update to config docs.
Eric Huss [Sun, 9 Dec 2018 00:45:52 +0000 (16:45 -0800)]
Minor update to config docs.

5 years agofix: only check solutions are in the same file
Pietro Albini [Sat, 8 Dec 2018 20:49:40 +0000 (21:49 +0100)]
fix: only check solutions are in the same file

5 years agoAdd a test for update --dry-run
Aleksey Kladov [Thu, 6 Dec 2018 18:28:07 +0000 (21:28 +0300)]
Add a test for update --dry-run

5 years agoadd `--dry-run` option to cargo update
Aleksey Kladov [Sun, 2 Dec 2018 11:41:16 +0000 (14:41 +0300)]
add `--dry-run` option to cargo update

5 years agoAuto merge of #6399 - alexcrichton:bump, r=alexcrichton
bors [Sat, 8 Dec 2018 17:14:20 +0000 (17:14 +0000)]
Auto merge of #6399 - alexcrichton:bump, r=alexcrichton

Bump to 0.34.0

5 years agoAuto merge of #6400 - alexcrichton:fmt, r=dwijnand
bors [Sat, 8 Dec 2018 16:22:03 +0000 (16:22 +0000)]
Auto merge of #6400 - alexcrichton:fmt, r=dwijnand

Format with `cargo fmt`

5 years agoRemove unused imports
Alex Crichton [Sat, 8 Dec 2018 16:21:33 +0000 (08:21 -0800)]
Remove unused imports

5 years agoFormat with `cargo fmt`
Alex Crichton [Sat, 8 Dec 2018 11:19:47 +0000 (03:19 -0800)]
Format with `cargo fmt`

5 years agoBump to 0.34.0
Alex Crichton [Sat, 8 Dec 2018 11:07:46 +0000 (03:07 -0800)]
Bump to 0.34.0

5 years agoAuto merge of #6387 - dwijnand:rust-2018, r=dwijnand
bors [Fri, 7 Dec 2018 16:37:19 +0000 (16:37 +0000)]
Auto merge of #6387 - dwijnand:rust-2018, r=dwijnand

Upgrade to Rust 2018 & fix edition idioms

None

5 years agoFinish pushing the minimum Rust to 1.31.0
Dale Wijnand [Fri, 7 Dec 2018 16:36:54 +0000 (17:36 +0100)]
Finish pushing the minimum Rust to 1.31.0

5 years agoFix Rust 2018 code in Windows code
Dale Wijnand [Fri, 7 Dec 2018 16:06:09 +0000 (17:06 +0100)]
Fix Rust 2018 code in Windows code

5 years agoAuto merge of #6393 - dwijnand:add-an-array-of-tables-example-to-manifest-docs, r...
bors [Fri, 7 Dec 2018 13:51:31 +0000 (13:51 +0000)]
Auto merge of #6393 - dwijnand:add-an-array-of-tables-example-to-manifest-docs, r=alexcrichton

Add an array of tables example to the manifest docs

Fixes #2992

5 years agoAuto merge of #6391 - ehuss:fix-jaitf, r=alexcrichton
bors [Fri, 7 Dec 2018 13:23:40 +0000 (13:23 +0000)]
Auto merge of #6391 - ehuss:fix-jaitf, r=alexcrichton

Fix spurious error for test json_artifact_includes_test_flag

There is a race condition for which job finishes first. On CI I am able
to reproduce the error about 1% of the time.

Recent failures:
- https://ci.appveyor.com/project/rust-lang-libs/cargo/builds/20151768/job/oghwemec7b19turs
- https://travis-ci.org/rust-lang/cargo/jobs/464717439

5 years agoAdd an array of tables example to the manifest docs
Dale Wijnand [Fri, 7 Dec 2018 09:14:41 +0000 (10:14 +0100)]
Add an array of tables example to the manifest docs

5 years agoUpgrade the minimum supported Rust to 1.31.0
Dale Wijnand [Fri, 7 Dec 2018 09:05:52 +0000 (10:05 +0100)]
Upgrade the minimum supported Rust to 1.31.0

5 years agoAuto merge of #6392 - rust-lang:dependabot/cargo/pretty_env_logger-0.3, r=dwijnand
bors [Fri, 7 Dec 2018 09:03:57 +0000 (09:03 +0000)]
Auto merge of #6392 - rust-lang:dependabot/cargo/pretty_env_logger-0.3, r=dwijnand

Update pretty_env_logger requirement from 0.2 to 0.3

Updates the requirements on [pretty_env_logger](https://github.com/seanmonstar/pretty-env-logger) to permit the latest version.
<details>
<summary>Commits</summary>

- See full diff in [compare view](https://github.com/seanmonstar/pretty-env-logger/commits/v0.3.0)
</details>
<br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>

5 years agoUpdate pretty_env_logger requirement from 0.2 to 0.3
dependabot[bot] [Fri, 7 Dec 2018 06:48:49 +0000 (06:48 +0000)]
Update pretty_env_logger requirement from 0.2 to 0.3

Updates the requirements on [pretty_env_logger](https://github.com/seanmonstar/pretty-env-logger) to permit the latest version.
- [Release notes](https://github.com/seanmonstar/pretty-env-logger/releases)
- [Commits](https://github.com/seanmonstar/pretty-env-logger/commits/v0.3.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
5 years agoFix spurious error for test json_artifact_includes_test_flag
Eric Huss [Fri, 7 Dec 2018 04:44:45 +0000 (20:44 -0800)]
Fix spurious error for test json_artifact_includes_test_flag

There is a race condition for which job finishes first. On CI I am able
to reproduce the error about 1% of the time.

Recent failures:
- https://ci.appveyor.com/project/rust-lang-libs/cargo/builds/20151768/job/oghwemec7b19turs
- https://travis-ci.org/rust-lang/cargo/jobs/464717439

5 years agoAuto merge of #6383 - ehuss:try-old-curl, r=alexcrichton
bors [Fri, 7 Dec 2018 01:16:34 +0000 (01:16 +0000)]
Auto merge of #6383 - ehuss:try-old-curl, r=alexcrichton

Fix fetching crates on old versions of libcurl.

CURLOPT_PIPEWAIT was added in 7.43 but MacOS 10.9 has 7.30.

Fixes #6155

5 years agoAuto merge of #6380 - fbunt:issue-6370, r=alexcrichton
bors [Fri, 7 Dec 2018 00:39:58 +0000 (00:39 +0000)]
Auto merge of #6380 - fbunt:issue-6370, r=alexcrichton

Warn if feature is called "default-features"

Fixes #6370.

I'm new to Rust and Cargo so any tips or critiques are welcome!

5 years agoAuto merge of #6388 - LucianBuzzo:patch-1, r=alexcrichton
bors [Fri, 7 Dec 2018 00:06:47 +0000 (00:06 +0000)]
Auto merge of #6388 - LucianBuzzo:patch-1, r=alexcrichton

Make it clearer that rustup will also install cargo

Make it clearer that cargo is automatically installed when installing Rust using `rustup`.

5 years agoMake it clearer that rustup will also install cargo
Lucian Buzzo [Thu, 6 Dec 2018 19:51:52 +0000 (19:51 +0000)]
Make it clearer that rustup will also install cargo

Make it clearer that cargo is automatically installed when installing Rust using `rustup`.

5 years agoFix 2018 edition idioms
Dale Wijnand [Thu, 6 Dec 2018 19:21:24 +0000 (20:21 +0100)]
Fix 2018 edition idioms

5 years agoUpgrade to Rust 2018
Dale Wijnand [Thu, 6 Dec 2018 19:17:36 +0000 (20:17 +0100)]
Upgrade to Rust 2018

5 years agoAuto merge of #6382 - ehuss:fix-builtin-alias, r=alexcrichton
bors [Thu, 6 Dec 2018 14:35:08 +0000 (14:35 +0000)]
Auto merge of #6382 - ehuss:fix-builtin-alias, r=alexcrichton

Fix built-in aliases taking arguments.

The built-in aliases weren't parsing their arguments. Change implementation to treat built-in aliases the same as user aliases.

Fixes #6381

5 years agoFix fetching crates on old versions of libcurl.
Eric Huss [Thu, 6 Dec 2018 08:14:37 +0000 (00:14 -0800)]
Fix fetching crates on old versions of libcurl.

5 years agoClean up pattern string
Fred Bunt [Thu, 6 Dec 2018 00:07:53 +0000 (17:07 -0700)]
Clean up pattern string

5 years agoPush warning directly to warning vec
Fred Bunt [Wed, 5 Dec 2018 18:45:30 +0000 (11:45 -0700)]
Push warning directly to warning vec

5 years agoFix built-in aliases taking arguments.
Eric Huss [Wed, 5 Dec 2018 17:29:10 +0000 (09:29 -0800)]
Fix built-in aliases taking arguments.

5 years agoAdd delayed warning to manifest. Pass test
Fred Bunt [Wed, 5 Dec 2018 09:46:33 +0000 (02:46 -0700)]
Add delayed warning to manifest. Pass test

5 years agoAdd failing test for issue #6370
Fred Bunt [Wed, 5 Dec 2018 09:29:03 +0000 (02:29 -0700)]
Add failing test for issue #6370

5 years agoAuto merge of #6372 - dwijnand:bin_dst, r=dwijnand
bors [Mon, 3 Dec 2018 19:29:24 +0000 (19:29 +0000)]
Auto merge of #6372 - dwijnand:bin_dst, r=dwijnand

Split OutputFile::bindst into OutputFile::bin_dst

None

5 years agoSplit OutputFile::bindst into OutputFile::bin_dst
Dale Wijnand [Mon, 3 Dec 2018 19:07:14 +0000 (19:07 +0000)]
Split OutputFile::bindst into OutputFile::bin_dst

5 years agoAuto merge of #6363 - dwijnand:add-executable-in-json-output, r=matklad
bors [Mon, 3 Dec 2018 18:44:13 +0000 (18:44 +0000)]
Auto merge of #6363 - dwijnand:add-executable-in-json-output, r=matklad

Include executable in JSON output.

Fixes #5426
Rebase of @patriksvensson's #5517
CC @matklad

I didn't really get into the issue or the code, I just interatively rebased Patrik's branch and then massaged and cleaned up the code until the tests passed.  So please double check it for code correctness, test case correctness and test case coverage.

Particularly the branch changed an if condition according to [this suggestion](https://github.com/rust-lang/cargo/pull/5517#issuecomment-388557248) by Aleksey.  I rolled that back because at one point it helped fix a series of tests.  But let me know if that should be included here.

5 years agoAuto merge of #6366 - Eh2406:faster-filtered-search, r=alexcrichton
bors [Sun, 2 Dec 2018 14:37:25 +0000 (14:37 +0000)]
Auto merge of #6366 - Eh2406:faster-filtered-search, r=alexcrichton

ConflictStoreTrie: Faster filtered search

This is an optimization that I was thinking of doing in #6283. I did not then as this is optimizing a not particularly hot path. I wish to do it now as it is stuck in my head, and I need that head space for more important things.

This also "accidentally" fixes the [indeterminacy](https://github.com/rust-lang/cargo/pull/6283#issuecomment-443358988) introduced in #6283, by replacing the `HashMap.iter().find()` like code with `BTreeMap.iter().find()` like code. This is not strictly needed, as @alexcrichton pointed out (In most use cases the index will change between any two invocations anyway), but does make it much easier to deal with (fuzz) test cases.

5 years agoAuto merge of #6368 - RandomInsano:patch-1, r=alexcrichton
bors [Sun, 2 Dec 2018 13:47:56 +0000 (13:47 +0000)]
Auto merge of #6368 - RandomInsano:patch-1, r=alexcrichton

Remove `cmake` as a requirement

No longer needed as outlined in https://github.com/rust-lang/cargo/issues/6367

5 years agoAuto merge of #6369 - matthiaskrgr:1_crates, r=dwijnand
bors [Sun, 2 Dec 2018 12:00:16 +0000 (12:00 +0000)]
Auto merge of #6369 - matthiaskrgr:1_crates, r=dwijnand

progress: display "Downloading 1 crate" instead of "Downloading 1 crates"

5 years agoprogress: display "Downloading 1 crate" instead of "Downloading 1 crates"
Matthias Krüger [Sun, 2 Dec 2018 11:28:56 +0000 (12:28 +0100)]
progress: display "Downloading 1 crate" instead of "Downloading 1 crates"

5 years agoRemove `cmake` as a requirement
Edwin Amsler [Sun, 2 Dec 2018 07:36:12 +0000 (01:36 -0600)]
Remove `cmake` as a requirement

No longer needed as outlined in https://github.com/rust-lang/cargo/issues/6367

5 years agooops...
Eh2406 [Sun, 2 Dec 2018 00:08:12 +0000 (19:08 -0500)]
oops...

5 years agofuzzer found a bad case
Eh2406 [Sat, 1 Dec 2018 20:01:34 +0000 (15:01 -0500)]
fuzzer found a bad case

5 years agoAuto merge of #6364 - dwijnand:test-json-parse-expect-over-unwrap, r=alexcrichton
bors [Sat, 1 Dec 2018 19:19:18 +0000 (19:19 +0000)]
Auto merge of #6364 - dwijnand:test-json-parse-expect-over-unwrap, r=alexcrichton

Use expect over unwrap, for panic-in-panic aborts

... doesn't help, but it can't hurt either, right?

5 years agoTrim the bench test so it cannot be non-deterministic
Dale Wijnand [Sat, 1 Dec 2018 18:35:31 +0000 (18:35 +0000)]
Trim the bench test so it cannot be non-deterministic

5 years agoSimplify & fix int test test
Dale Wijnand [Sat, 1 Dec 2018 16:52:20 +0000 (16:52 +0000)]
Simplify & fix int test test

5 years agowe only need to search the part of the Trie that may contain the filler
Eh2406 [Sat, 1 Dec 2018 15:42:56 +0000 (10:42 -0500)]
we only need to search the part of the Trie that may contain the filler

5 years agoinline the filter
Eh2406 [Sat, 1 Dec 2018 15:17:26 +0000 (10:17 -0500)]
inline the filter

5 years agoregain determinism
Eh2406 [Sat, 1 Dec 2018 15:04:03 +0000 (10:04 -0500)]
regain determinism

5 years agoI think this shrinks better.
Eh2406 [Wed, 14 Nov 2018 22:31:49 +0000 (17:31 -0500)]
I think this shrinks better.

5 years agoUse expect over unwrap, for panic-in-panic aborts
Dale Wijnand [Fri, 30 Nov 2018 16:48:22 +0000 (16:48 +0000)]
Use expect over unwrap, for panic-in-panic aborts

... doesn't help, but it can't hurt either, right?

5 years agoFix message order
Dale Wijnand [Fri, 30 Nov 2018 23:16:34 +0000 (23:16 +0000)]
Fix message order

5 years agoIgnore filenames, to avoid extra Windows file
Dale Wijnand [Fri, 30 Nov 2018 23:15:31 +0000 (23:15 +0000)]
Ignore filenames, to avoid extra Windows file

Apparently on Windows it creates an .exe & a .pdb.

5 years agoInclude executable in JSON output.
Dale Wijnand [Fri, 30 Nov 2018 14:31:01 +0000 (14:31 +0000)]
Include executable in JSON output.

5 years agoSwitch Artifacts.filenames to paths
Dale Wijnand [Fri, 30 Nov 2018 21:58:18 +0000 (21:58 +0000)]
Switch Artifacts.filenames to paths

5 years agoAuto merge of #6362 - dwijnand:pretty_env_logger, r=alexcrichton
bors [Fri, 30 Nov 2018 15:55:34 +0000 (15:55 +0000)]
Auto merge of #6362 - dwijnand:pretty_env_logger, r=alexcrichton

Switch to pretty_env_logger, under --features pretty-env-logger

Fixes #6348

5 years agoSwitch to pretty_env_logger, under --features pretty-env-logger
Dale Wijnand [Fri, 30 Nov 2018 14:13:30 +0000 (14:13 +0000)]
Switch to pretty_env_logger, under --features pretty-env-logger

5 years agoAuto merge of #6280 - zachreizner:master, r=dwijnand
bors [Thu, 29 Nov 2018 09:07:16 +0000 (09:07 +0000)]
Auto merge of #6280 - zachreizner:master, r=dwijnand

use allow-dirty option in `cargo package` to skip vcs checks

If `cargo package` is run for a crate that is not version controlled in
a way that cargo expects, git2 will overreach upwards and grab a
irrelevant .git repo. This change uses `--allow-dirty` to imply to `cargo package` that it should not be checking for version control information, fixing this issue.