]>
git.proxmox.com Git - mirror_lxc.git/log
Josh Soref [Tue, 30 Oct 2018 07:01:26 +0000 (07:01 +0000)]
spelling: explicitly
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 07:01:12 +0000 (07:01 +0000)]
spelling: exiting
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 07:00:01 +0000 (07:00 +0000)]
spelling: device
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:59:37 +0000 (06:59 +0000)]
spelling: describing
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:54:56 +0000 (06:54 +0000)]
spelling: could
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:55:05 +0000 (06:55 +0000)]
spelling: convenience
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:54:21 +0000 (06:54 +0000)]
spelling: control
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:53:11 +0000 (06:53 +0000)]
spelling: container
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:54:44 +0000 (06:54 +0000)]
spelling: constant
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:52:44 +0000 (06:52 +0000)]
spelling: configuration
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:52:23 +0000 (06:52 +0000)]
spelling: committer
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:52:09 +0000 (06:52 +0000)]
spelling: command
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:51:58 +0000 (06:51 +0000)]
spelling: comma
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:50:25 +0000 (06:50 +0000)]
spelling: checkpoint
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:50:12 +0000 (06:50 +0000)]
spelling: character
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:49:52 +0000 (06:49 +0000)]
spelling: capabilities
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:49:12 +0000 (06:49 +0000)]
spelling: backingstorage
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:48:09 +0000 (06:48 +0000)]
spelling: asynchronous
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:47:57 +0000 (06:47 +0000)]
spelling: array
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:47:09 +0000 (06:47 +0000)]
spelling: architecture
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:46:40 +0000 (06:46 +0000)]
spelling: answer
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:45:53 +0000 (06:45 +0000)]
spelling: ambiguous
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:45:18 +0000 (06:45 +0000)]
spelling: allocate
Signed-off-by: Josh Soref <jsoref@gmail.com>
Serge Hallyn [Mon, 22 Oct 2018 16:07:21 +0000 (11:07 -0500)]
Merge pull request #2707 from brauner/2018-10-20/code_quality
tree-wide: bugfixes
Christian Brauner [Sat, 20 Oct 2018 10:04:33 +0000 (12:04 +0200)]
coverity: #
1426130
Bad bit shift operation
Fixes: commit b5b12b9e759 ("criu: add feature check capability")
Cc: Adrian Reber <areber@redhat.com>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:59:48 +0000 (11:59 +0200)]
coverity: #
1440389
Logically dead code
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:57:02 +0000 (11:57 +0200)]
coverity: #
1440391
Dereference null return value
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:49:47 +0000 (11:49 +0200)]
cmd/lxc_init: do not hide global variable
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:48:06 +0000 (11:48 +0200)]
tools/lxc_stop: use correct check
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:39:28 +0000 (11:39 +0200)]
start: prevent values smaller 0
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:37:39 +0000 (11:37 +0200)]
lxccontainer: remove check from goto target
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:36:26 +0000 (11:36 +0200)]
conf: remove tautological check
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:35:41 +0000 (11:35 +0200)]
conf: use O_CLOEXEC in lxc_pivot_root()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:34:35 +0000 (11:34 +0200)]
conf: remove tautological check
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:32:04 +0000 (11:32 +0200)]
state: remove tautological check
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:30:12 +0000 (11:30 +0200)]
tools/lxc_info: do not hide global variable
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:28:11 +0000 (11:28 +0200)]
tools/lxc_top: do not hide global variable
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:23:55 +0000 (11:23 +0200)]
tools/lxc_copy: do not hide global variable
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:22:02 +0000 (11:22 +0200)]
monitord: do not hide global variable
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:13:59 +0000 (11:13 +0200)]
cgfsng: move increment out of branch
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:09:54 +0000 (11:09 +0200)]
commands: simplify
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:03:41 +0000 (11:03 +0200)]
confile: do not overwrite global variable
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Sun, 21 Oct 2018 18:40:44 +0000 (14:40 -0400)]
Merge pull request #2705 from brauner/2018-10-20/bugfixes
start: simplify
Stéphane Graber [Sun, 21 Oct 2018 18:40:18 +0000 (14:40 -0400)]
Merge pull request #2706 from brauner/2018-10-20/compiler_hardening
autotools: compiler based hardening
Christian Brauner [Fri, 19 Oct 2018 23:57:40 +0000 (01:57 +0200)]
coverity: update .travis.yml
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Fri, 19 Oct 2018 23:54:55 +0000 (01:54 +0200)]
coverity: update .travis.yml
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Fri, 19 Oct 2018 23:48:39 +0000 (01:48 +0200)]
coverity: update .travis.yml
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Fri, 19 Oct 2018 23:42:56 +0000 (01:42 +0200)]
coverity: update .travis.yml
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Fri, 19 Oct 2018 23:34:15 +0000 (01:34 +0200)]
coverity: update .travis.yml
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Fri, 19 Oct 2018 22:22:18 +0000 (00:22 +0200)]
autotools: compiler based hardening
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Fri, 19 Oct 2018 22:06:32 +0000 (00:06 +0200)]
start: simplify
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Fri, 19 Oct 2018 09:47:06 +0000 (11:47 +0200)]
Merge pull request #2703 from 2xsec/asan1
cleanups
2xsec [Fri, 19 Oct 2018 05:34:13 +0000 (14:34 +0900)]
tree-wide: coding style fixes
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
[christian.brauner@ubuntu.com: cleanup if-branches in confile.c]
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Fri, 19 Oct 2018 05:02:41 +0000 (07:02 +0200)]
Merge pull request #2702 from 2xsec/asan1
parse: fix uninitialized value
2xsec [Fri, 19 Oct 2018 02:51:51 +0000 (11:51 +0900)]
parse: fix uninitialized value
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
Wolfgang Bumiller [Thu, 18 Oct 2018 19:55:44 +0000 (21:55 +0200)]
Merge pull request #2696 from brauner/2018-10-17/fix_append_config_line
confile: fix append_unexp_config_line()
Wolfgang Bumiller [Thu, 18 Oct 2018 17:38:38 +0000 (19:38 +0200)]
Merge pull request #2698 from brauner/2018-10-17/config_parsing
parse: protect against config updates during parse
Christian Brauner [Wed, 17 Oct 2018 16:36:28 +0000 (18:36 +0200)]
parse: protect against config updates during parse
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 17 Oct 2018 13:16:27 +0000 (15:16 +0200)]
confile: fix append_unexp_config_line()
Reported-by: 2xsec dh48.jeong@samsung.com
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Wolfgang Bumiller [Thu, 18 Oct 2018 13:43:30 +0000 (15:43 +0200)]
Merge pull request #2697 from brauner/2018-10-17/fix_disable_commands_build
autotools: fix --disable-commands builds
Wolfgang Bumiller [Thu, 18 Oct 2018 13:08:42 +0000 (15:08 +0200)]
Merge pull request #2701 from brauner/2018-10-18/fix_raw_syscalls
raw_syscalls: ensure function always returns value
Wolfgang Bumiller [Thu, 18 Oct 2018 13:08:06 +0000 (15:08 +0200)]
Merge pull request #2700 from brauner/2018-10-18/simplify_strlcpy
include: simplify strlcpy()
Christian Brauner [Thu, 18 Oct 2018 12:38:09 +0000 (14:38 +0200)]
raw_syscalls: ensure function always returns value
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 18 Oct 2018 10:53:23 +0000 (12:53 +0200)]
Merge pull request #2699 from 2xsec/asan1
string_utils: fix global buffer overflow issue
Christian Brauner [Thu, 18 Oct 2018 10:50:13 +0000 (12:50 +0200)]
include: simplify strlcpy()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2xsec [Thu, 18 Oct 2018 06:16:54 +0000 (15:16 +0900)]
string_utils: fix global buffer overflow issue
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
Christian Brauner [Wed, 17 Oct 2018 13:23:41 +0000 (15:23 +0200)]
autotools: fix --disable-commands builds
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Mon, 15 Oct 2018 14:44:04 +0000 (10:44 -0400)]
Merge pull request #2694 from brauner/2018-10-14/lxc_init_logging
lxc-init: log to /dev/console
Christian Brauner [Sun, 14 Oct 2018 20:22:21 +0000 (22:22 +0200)]
lxc-init: log to /dev/console
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 13 Oct 2018 05:47:34 +0000 (07:47 +0200)]
Merge pull request #2693 from stgraber/master
checkconfig: Handle missing kernel version
Stéphane Graber [Sat, 13 Oct 2018 02:32:08 +0000 (22:32 -0400)]
checkconfig: Handle missing kernel version
https://github.com/lxc/lxd/issues/5151
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
Stéphane Graber [Fri, 12 Oct 2018 23:26:43 +0000 (19:26 -0400)]
Merge pull request #2692 from brauner/2018-10-12/no_strict_aliasing
autools: use -fno-strict-aliasing
Christian Brauner [Fri, 12 Oct 2018 19:23:07 +0000 (21:23 +0200)]
autools: use -fno-strict-aliasing
The gcc implementation and the C standard are not to be considered sane
in this respect. We don't want to risk reordering of writes when the
compiler incorrectly *thinks* two types do not alias each other.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Fri, 12 Oct 2018 08:39:57 +0000 (10:39 +0200)]
Merge pull request #2691 from 2xsec/bugfix
Some redundancy codes of abstract unix socket are removed with log cleanups.
2xsec [Fri, 12 Oct 2018 07:05:31 +0000 (16:05 +0900)]
monitor: fix coding standard
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2xsec [Fri, 12 Oct 2018 06:05:43 +0000 (15:05 +0900)]
commands_utils: improve code redundancy to make abstract unix socket name
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2xsec [Fri, 12 Oct 2018 02:19:04 +0000 (11:19 +0900)]
monitor: checking name too long to make monitor sock name
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2xsec [Fri, 12 Oct 2018 01:36:42 +0000 (10:36 +0900)]
monitor: log cleanups
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
Christian Brauner [Thu, 11 Oct 2018 13:58:20 +0000 (15:58 +0200)]
Merge pull request #2690 from adrianreber/master
checkpoint: fix running do_dump()
Adrian Reber [Thu, 11 Oct 2018 13:10:12 +0000 (13:10 +0000)]
checkpoint: fix running do_dump()
Testing 'lxc <container> stop --stateful' crashed LXD:
fatal error: unexpected signal during runtime execution
[signal SIGSEGV: segmentation violation code=0x1 addr=0xe8 pc=0x7f3198ff0592]
runtime stack:
runtime.throw(0x117fe4a, 0x2a)
/opt/rh/go-toolset-1.10/root/usr/lib/go-toolset-1.10-golang/src/runtime/panic.go:616 +0x81
runtime.sigpanic()
/opt/rh/go-toolset-1.10/root/usr/lib/go-toolset-1.10-golang/src/runtime/signal_unix.go:372 +0x28e
goroutine 375 [syscall]:
runtime.cgocall(0xef38e3, 0xc420731630, 0x29)
/opt/rh/go-toolset-1.10/root/usr/lib/go-toolset-1.10-golang/src/runtime/cgocall.go:128 +0x64 fp=0xc4207315f0 sp=0xc4207315b8 pc=0x410fc4
gopkg.in/lxc/go-lxc%2ev2._Cfunc_go_lxc_migrate(0x7f316c001220, 0xc400000001, 0xc420302460, 0xc4205d6080, 0x0)
_cgo_gotypes.go:752 +0x4d fp=0xc420731630 sp=0xc4207315f0 pc=0x909d7d
gopkg.in/lxc/go-lxc%2ev2.(*Container).Migrate.func4(0x7f316c001220, 0xc400000001, 0xc420302460, 0xc4205d6080, 0x0)
/share/go/src/gopkg.in/lxc/go-lxc.v2/container.go:1798 +0x160 fp=0xc420731668 sp=0xc420731630 pc=0x91b970
gopkg.in/lxc/go-lxc%2ev2.(*Container).Migrate(0xc4207a52f0, 0x1, 0xc42051ec00, 0x20, 0x0, 0x0, 0x0, 0x0, 0x101, 0x10000000, ...)
/share/go/src/gopkg.in/lxc/go-lxc.v2/container.go:1798 +0x29f fp=0xc420731760 sp=0xc420731668 pc=0x9160ef
The commit
5a087e056f94 introduced a second parameter (conf) to the
cgroup escape() function which was never set in do_dump(). Instead of
taking it from opts->handler->conf it is now used from c->lxc_conf.
Fixes: 5a087e056f94 ("cgroups: don't escape if lxc.cgroup.keep is true")
Suggested-by: Christian Brauner <christian.brauner@ubuntu.com>
Signed-off-by: Adrian Reber <areber@redhat.com>
Stéphane Graber [Wed, 10 Oct 2018 15:04:42 +0000 (11:04 -0400)]
Merge pull request #2687 from brauner/2018-10-10/fix_verify_start_hooks
conf: verify_start_hooks() after lxc.mount.entry
Christian Brauner [Wed, 10 Oct 2018 11:06:21 +0000 (13:06 +0200)]
conf: verify_start_hooks() after lxc.mount.entry
Fixes: https://discuss.linuxcontainers.org/t/are-lxc-mount-entry-available-when-lxc-hook-start-is-validated/2906/3
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Wed, 10 Oct 2018 14:34:58 +0000 (10:34 -0400)]
Merge pull request #2688 from brauner/2018-10-10/cgfsng_fix_monitor_cpuset_deletion
cgfsng: ensure initialized cpuset controller
Stéphane Graber [Wed, 10 Oct 2018 14:34:35 +0000 (10:34 -0400)]
Merge pull request #2689 from brauner/2018-10-10/log_prlimit
conf: log prlimit setup
Christian Brauner [Wed, 10 Oct 2018 11:53:00 +0000 (13:53 +0200)]
conf: log prlimit setup
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 10 Oct 2018 11:43:10 +0000 (13:43 +0200)]
Merge pull request #2686 from 2xsec/rpm
fix rpm packaging error for static library
Christian Brauner [Wed, 10 Oct 2018 11:27:45 +0000 (13:27 +0200)]
cgfsng: ensure initialized cpuset controller
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2xsec [Wed, 10 Oct 2018 09:51:26 +0000 (18:51 +0900)]
fix post section script error for rpm install
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2xsec [Wed, 10 Oct 2018 09:21:41 +0000 (18:21 +0900)]
fix rpm packaging error for static library
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2xsec [Wed, 10 Oct 2018 06:00:45 +0000 (15:00 +0900)]
parse: fix uninitialized pointer access
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2xsec [Wed, 10 Oct 2018 05:50:32 +0000 (14:50 +0900)]
confile: remove unused variable
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
Stéphane Graber [Tue, 9 Oct 2018 23:23:55 +0000 (19:23 -0400)]
Merge pull request #2684 from brauner/2018-10-10/cgfsng_improve_logging
cgfsng: improve deletion and logging
Christian Brauner [Tue, 9 Oct 2018 22:03:13 +0000 (00:03 +0200)]
cgfsng: improve loggin on monitor cgroup destroy
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Tue, 9 Oct 2018 22:02:46 +0000 (00:02 +0200)]
cgfsng: fix lxc.pivot directory creation
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Mon, 8 Oct 2018 21:06:58 +0000 (17:06 -0400)]
Merge pull request #2681 from brauner/2018-10-08/adapt_netns_ifaddrs_to_new_kernel
netns_ifaddrs: support NETLINK_DUMP_STRICT_CHK
Stéphane Graber [Mon, 8 Oct 2018 21:05:43 +0000 (17:05 -0400)]
Merge pull request #2682 from brauner/2018-10-08/fix_config_parsing
parse: do not mask failed parse
Christian Brauner [Mon, 8 Oct 2018 20:53:16 +0000 (22:53 +0200)]
test: test invalid config keys
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 8 Oct 2018 20:49:57 +0000 (22:49 +0200)]
parse: do not mask failed parse
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 8 Oct 2018 19:08:10 +0000 (21:08 +0200)]
netns_ifaddrs: check for NETLINK_DUMP_STRICT_CHK
Make use of the new socket option, NETLINK_DUMP_STRICT_CHK, that
userspace can use via setsockopt to request strict checking of headers
and attributes on dump requests.
To get dump features such as kernel side filtering based on data in
the header or attributes appended to the dump request, userspace
must call setsockopt() for NETLINK_DUMP_STRICT_CHK and a non-zero
value. This is necessary to make use of the IFA_TARGET_NETNSID property.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 8 Oct 2018 19:10:29 +0000 (21:10 +0200)]
macro: add SOL_NETLINK
This allows to set netlink socket properties.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>