Thomas Lamprecht [Fri, 19 May 2023 07:47:19 +0000 (09:47 +0200)]
avoid global $cmap variable and refactor use sites
While we still rely on the global $env, that is more contained and
capsuled, and with moving over to that a further split, or move to a
singleton, is easier in the future.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
When using the module -init switch, the init method was called in
module import method, which means every time this was loaded, even if
just for a quick syntax+ check using `perl -I. -wc`, failing then if
no X11 connection was available.
Calling this manually after module load finished should have no
consequences, and if, that should be fixed there, without going back
to doing GUI init in module load/import steps - that's just ugly.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
The assignment to () is confusing, as that's effectively identical
with not assigning it at all and later auto-vivify it to an array
ref, make that more explicit instead.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
buildsys: depend on full known-to-git file list for installer sources
basically only used for change-tracking on what targets to rebuild,
so avoid the need to have the list here duplicated, most files known
to git are installer files
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Make it clearer that we actually pass one, or a list of, test-images
as CLI option and move the is-test-mode state into the setup module
(not enough code/reason to make a separate "env" or so module) in
preparation of further splitting out code into separate modules where
we then need to have the info about test-mode state available there
too.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Christoph Heiss [Thu, 16 Mar 2023 10:01:36 +0000 (11:01 +0100)]
fix #4430: add UTC timezone as option to installer
Adds 'Etc/UTC' as option to the timezone selection, regardless of what
country is selected.
The 'Etc/' prefix needs to be stripped for the installation, as this
value is written to /etc/timezone. PVE/PMG/PBS already use 'UTC' without
the prefix, so avoid regressing them.
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
Thomas Lamprecht [Tue, 29 Nov 2022 06:10:21 +0000 (07:10 +0100)]
compute swap size: align down to 4 MB
For one as this just avoids very oddly specific swap size values, and
more importantly, storage systems like LVM that need to align their
sizes to their internal extent size won't round up on odd numbers
anymore.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Stoiko Ivanov [Mon, 28 Nov 2022 20:41:10 +0000 (21:41 +0100)]
create lvm: align LV size down to 4MB boundary for non-pve products
Following commit 1a5fa7b0936381314f613e525255078093f7f258 but for
the non-PVE code path we also need to align down to 4 MB with the
adapted auto-sizing, especially on smaller disks.
For PMG and PBS installations. Without it installation fails due to
one missing extent when creating the root LV. Minimally tested on a
VM of mine
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
[ T: reworded commit message a bit ] Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Fri, 18 Nov 2022 15:29:17 +0000 (16:29 +0100)]
create lvm: improve rounding/alignment
stay in MB size range for longer to have some accuracy level we need
and mask the last 2 bits (= 4 MB) to align down to a level that
should not interfere with LVM anymore.
Otherwise, with $rest sizes that hit the second if branch < 48
regressed on LVM due to missing one extend of expected space.
Dominik verified this off-list to fix the case Stefan run into.
Reported-by: Stefan Hanreich <s.hanreich@proxmox.com> Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 14 Sep 2022 13:47:23 +0000 (15:47 +0200)]
fix #4236: split disk space check into soft and hard limits
Make the 8 GB disk check a soft limit, as most products are still
installable with less space, even though it may need some special
options in the disk selection. Still notify the user with a prompt to
avoid an expected possible error seem like it was unexpected.
Keep 2 GB as hard limit for now, makes no sense to install on such
small devices, only pain.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Mon, 25 Apr 2022 15:49:33 +0000 (17:49 +0200)]
drop enabling timesyncd, wrong since chrony switch & unnecessary anyway
It should actually fail since the switch to chrony, but syscmd only
returns the exit code and we did not check it.
Shortly thought about checking for the existence of
"$targetdir/lib/systemd/system/chrony.service" and enable
chrony.service in that case, but that is unnecessary too, as we know
due to this bogus enable timesyncd which never stopped chrony to run
happily enabled after installation anyway.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Mon, 25 Apr 2022 15:41:21 +0000 (17:41 +0200)]
disks: raid: avoid restting hdsize when reopening options
The"auto get lowest disk size from selected set" logic also reset it
to that if the previously chosen value was already lower on reopening
the disk dialogue.
That can be rather surprising for an user as the hdsize field is a
bit hidden in the advanced dialogue, so just reopening to ensure the
correct disks are selected may interfere with a previously lowered
hdsize.
Reported-by: Fabian Ebner <f.ebner@proxmox.com> Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 20 Apr 2022 11:12:30 +0000 (13:12 +0200)]
hd size: defuse, rework and comment hd size computation
we explicitly have an "Deselect All" Button if we got more than 4
disks, and if that's hit nothing is selected and we'd die with an
internal error in an normal, to be expected case; which must not
happen.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
fix #3587: make hdsize configurable for btrfs setups
as described in the bug-entry it is still not possible to have a
swapfile on general btrfs setups (only on single disk (single data
profile - documented in [0,1], and my quick tests confirmed it).
Users who still need/want swap can now set a hdsize smaller than their
disk-size to keep a part unpartitioned for adding a swap-partition
after installation (like with ZFS).
I quickly considered sticking with a single 'advanced raid' tab and
adapting the visibility of the individual lines, but did not see an
elegant way (as far as this is possible with GUI code) of doing that.
fix #3188: update hdsize spin-button on disk-selection change
the patch splits get_hdsize_spinbtn into a sub for generating the adjustment
gtk-element and one for the button itself and moves them above
create_raid_disk_raid (so that the adjustment sub can be called)
The adjustment gets it's data from the disks selected for installation
in the GUI, if a size is not provided.
Additionally the bogus 'zfs' argument to the create_raid_advanced_grid
was dropped.
Tested with a VM with 2x 100G disks, and one with 20G
Stefan Reiter [Thu, 24 Jun 2021 12:30:13 +0000 (14:30 +0200)]
zfs: allow RAID0 with different-sized disks
zfs_mirror_size_check is already called in get_zfs_raid_setup when
necessary, so don't call it unconditionally, as this will cause a
false-positive error on RAID0 devices (where size mismatches are fine).
Thomas Lamprecht [Fri, 10 Sep 2021 12:11:29 +0000 (14:11 +0200)]
init: do not sync on actual reboot
we actively synced two times already at this point, immediately after
the installer GUI exited and before starting to unmount stuff, so
reboot should not be required to sync and may even hang if trying to
do
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
projects / pve-installer.git / log