]>
git.proxmox.com Git - pve-manager-legacy.git/log
Aaron Lauterer [Mon, 1 Feb 2021 14:21:29 +0000 (15:21 +0100)]
ui: qemu/HardwareView: change heuristic perms to const
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
Aaron Lauterer [Mon, 1 Feb 2021 14:21:25 +0000 (15:21 +0100)]
ui: qemu/HardwareView: eslint: enforce "no-mixed-operators" rule
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
Dominik Csapak [Wed, 2 Dec 2020 09:21:12 +0000 (10:21 +0100)]
ui: dc/MetricServerView: add onlineHelp to edit windows
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Wed, 2 Dec 2020 09:21:11 +0000 (10:21 +0100)]
ui: add necessary fields for influxdb http api
and en/disable them accordingly to the selected mode
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Wed, 2 Dec 2020 09:21:10 +0000 (10:21 +0100)]
status/influxdb: remove unnecessary comment
we already have that information in the reference docs, no need to
have it here as well
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Wed, 2 Dec 2020 09:21:09 +0000 (10:21 +0100)]
status/influxdb: implement influxdb 2.x http api
needs an organization/bucket (previously db) and an optional token
the http client does not fit exactly in the connect/send/disconnect
scheme, so it simply creates a request in 'connect',
does the actual http connection in 'send' and nothing in 'disconnect'
max-body-size is set to 25.000.000 bytes by default (the influxdb default)
and the timeout to 1 second (same as default graphite tcp timeout)
the token (if given) gets saved in /etc/pve/priv/metricserver/$ID.pw
it is optional, because the 1.8.x compatibility api does not need
authentication (in contrast to influxdb 2.x)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Wed, 2 Dec 2020 09:21:08 +0000 (10:21 +0100)]
status/plugin: extend with add/update/delete hooks
like we do in it for the storage section configs
we will need this to store the token for influxdbs http api
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Wed, 2 Dec 2020 09:21:07 +0000 (10:21 +0100)]
status/plugin: extend send/_connect/_disconnect/test_connection
by providing the id or cfg to have better context in those methods
we will need that for influxdb http api
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Wed, 2 Dec 2020 09:21:06 +0000 (10:21 +0100)]
api: cluster/metricserver: prevent simultaneosly setting and deleting of property
like we do in other apis of section configs (e.g. storage)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Fabian Ebner [Wed, 27 Jan 2021 10:43:20 +0000 (11:43 +0100)]
pvereport: also add .sources files
while this format is probably not much in use currently, the plan is to make it
the default format in Debian, see 'man 5 sources.list'.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Fabian Ebner [Fri, 15 Jan 2021 12:49:05 +0000 (13:49 +0100)]
vzdump: avoid parsing already parsed option
When a job is updated, verify_vzdump_parameters() is called twice. This led to
parse_property_string being called with the already parsed option.
Reported on the pve-user mailing list:
https://lists.proxmox.com/pipermail/pve-user/2021-January/172258.html
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Stoiko Ivanov [Tue, 26 Jan 2021 17:31:38 +0000 (18:31 +0100)]
pvereport: add apt sources
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Fabian Ebner [Tue, 26 Jan 2021 13:01:12 +0000 (14:01 +0100)]
ui: ceph: fix keeping selection after operation
Found by having the console open and getting a message that 'me' (the
controller) does not have a method getRootNode()
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Thomas Lamprecht [Tue, 19 Jan 2021 16:48:50 +0000 (17:48 +0100)]
ui: eslint: some more trailing comma fixes
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 19 Jan 2021 16:45:01 +0000 (17:45 +0100)]
ui: eslint: enforce "dot-notation" rule
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 19 Jan 2021 16:43:40 +0000 (17:43 +0100)]
ui: eslint: enforce "no-extra-boolean-cast" rule
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 19 Jan 2021 16:42:36 +0000 (17:42 +0100)]
ui: eslint: enforce "no-extra-parens" rule
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 19 Jan 2021 16:41:11 +0000 (17:41 +0100)]
ui: eslint: enforce "no-unneeded-ternary" rule
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 19 Jan 2021 16:39:15 +0000 (17:39 +0100)]
ui: eslint: fix various spacing related issues
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 19 Jan 2021 16:31:03 +0000 (17:31 +0100)]
ui: eslint: fix trailing comma and comma related whitespaces errors
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 19 Jan 2021 16:29:55 +0000 (17:29 +0100)]
ui: eslint: fix trailing spaces
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Mon, 18 Jan 2021 15:29:51 +0000 (16:29 +0100)]
ui: tfa/totp: fix setting issuer in secret URL
it's recommended to set the issuer for both, the get parameter and
the initial issuer label prefix[0].
[0]:
https://github.com/google/google-authenticator/wiki/Key-Uri-Format#label
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 12 Jan 2021 12:09:33 +0000 (13:09 +0100)]
ui: qemu/audio: improve displayed text for backend drivers
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 12 Jan 2021 12:08:02 +0000 (13:08 +0100)]
ui: qemu/audio: submitValue is default true for combobox
this was previously a display field, where submitValue defaults to
false, so we required to enable it explicitly. As it changed to a
combo box we can drop that.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Gilles Pietri [Thu, 7 Jan 2021 17:02:44 +0000 (18:02 +0100)]
ui: qemu: add the none audio driver as an option
Signed-off-by: Gilles Pietri <contact+dev@gilouweb.com>
Dominic Jäger [Thu, 7 Jan 2021 10:04:38 +0000 (11:04 +0100)]
ui: add netdevice: fix #3203: Use OS default model
In the VM create wizard we automatically set e1000 for Windows and virtio for
Linux. We should also do this when adding a network device in the hardware
view.
OSDefaults.generic.networkCard (=e1000) is always available. Hence, leave this
as default value for the field and then try to get the ostype via API and
overwrite the default e1000.
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Dominic Jäger [Thu, 7 Jan 2021 08:32:13 +0000 (09:32 +0100)]
ui: acme: Remove false gettexts
Translating these is not useful; e.g. API would be translated to API in German.
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Thomas Lamprecht [Mon, 21 Dec 2020 16:00:46 +0000 (17:00 +0100)]
report: fix separation of commands over multiple lines
once we get over the allowed line length we must move each atom
(e.g., argument or other value) to a separate line, not pairing a
few.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Aaron Lauterer [Mon, 21 Dec 2020 15:13:51 +0000 (16:13 +0100)]
pvereport: code cleanup, line length
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
Aaron Lauterer [Mon, 21 Dec 2020 15:13:50 +0000 (16:13 +0100)]
pvereport: rework report contents
add:
* HA status
* ceph osd df tree
* ceph conf file and conf db
* ceph versions
removed:
* ceph status, as pveceph status is now printing the same information
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
Aaron Lauterer [Mon, 21 Dec 2020 15:13:49 +0000 (16:13 +0100)]
pvereport: fix multipath inclusion
we now push it to the correct hash if it is installed
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
Fabian Ebner [Mon, 21 Dec 2020 13:48:18 +0000 (14:48 +0100)]
vzdump: fix error format for errors coming from storage_info
Errors from storage_info() are newline-terminated, because perl would append
the line number otherwise. Chomp those errors, because sendmail() relies
on the presence of a newline to decide if it's multiple problems or only one.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Fabian Ebner [Mon, 21 Dec 2020 13:48:17 +0000 (14:48 +0100)]
vzdump: sendmail: fix html by closing the tags
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Fabian Ebner [Mon, 21 Dec 2020 13:48:16 +0000 (14:48 +0100)]
vzdump: defaults: convert to prune-backups early enough
Fixes the case where reading from /etc/vzdump.conf fails.
Also convert the options read from /etc/vzdump.conf before the loop. That
avoids showing a wrong warning when 'prune-backups' is configured in
/etc/vzdump.conf, and maxfiles isn't. Previously, because 'maxfiles' from the
schema defaults was automatically set, the call to parse_prune_backups_maxfiles
after the loop threw the warning that both options are defined.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Thomas Lamprecht [Mon, 21 Dec 2020 14:19:40 +0000 (15:19 +0100)]
pveceph: add timeout to status command
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Aaron Lauterer [Mon, 21 Dec 2020 10:07:54 +0000 (11:07 +0100)]
pveceph: change status from long JSON to ceph -s
Printing a lot of very detailed JSON output on the CLI is not very
useful.
Printing the `ceph -s` overview is much more suited to give an overview
of the ceph cluster status.
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
Dominic Jäger [Thu, 10 Dec 2020 08:16:00 +0000 (09:16 +0100)]
safe destroy: Add HA to purge tooltip
This makes the enumeration complete.
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Aaron Lauterer [Tue, 15 Dec 2020 15:22:04 +0000 (16:22 +0100)]
ui: improve description of guest-fstrim checkbox
The phrasing left some room to speculation when this would actually be
run, e.g. after cloning a full VM?
Currently the only instances where it is used is after moving a disk or
migrating a VM.
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
Stoiko Ivanov [Wed, 16 Dec 2020 11:46:11 +0000 (12:46 +0100)]
ceph: extend error for wrong config-file link
Since I had to look up the cause of the error-message in our source
explaining why exactly ceph-operations fail, because
/etc/ceph/ceph.conf exists.
reported via our community forum:
https://forum.proxmox.com/threads/osd-ersetzen-neu-erstellen.80793/
quickly tested on a virtual ceph cluster
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Thomas Lamprecht [Fri, 11 Dec 2020 08:59:25 +0000 (09:59 +0100)]
update aplinfo
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominik Csapak [Mon, 7 Dec 2020 14:37:07 +0000 (15:37 +0100)]
status/plugin: do not test connection if disabled
so that if one disables the plugin (e.g. because it is offline),
it will work even when the server is not reachable
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Fabian Ebner [Fri, 4 Dec 2020 09:15:18 +0000 (10:15 +0100)]
vzdump: use debugmsg instead of warn
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Fabian Ebner [Fri, 4 Dec 2020 09:15:17 +0000 (10:15 +0100)]
vzdump: warn when both storage and dumpdir are defined in vzdump.conf
and prefer storage, because the storage configuration might contain more
settings. Warning is preferable over dying, because all backups would be
affected (even if they don't use the vzdump.conf parameters) and the settings
could've been compatible (i.e. dumpdir being the storage's dump dir). Previously
one of the two options would randomly be chosen in the loop in new(), because of
perl hash iteration.
Reported here: https://forum.proxmox.com/threads/vzdump-times-out-very-often-on-zfs-storage-pool.80035/post-354277
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Thomas Lamprecht [Thu, 3 Dec 2020 17:14:49 +0000 (18:14 +0100)]
bump version to 6.3-3
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominik Csapak [Thu, 3 Dec 2020 15:01:40 +0000 (16:01 +0100)]
pvestatd: fix container cpuset scheduling
Since pve-container commit
c48a25452dccca37b3915e49b7618f6880aeafb1
the code to get the cpuset controller path lives in pve-commons PVE::CGroup.
Use that and improve the logging in case some error happens in the future.
Such an error will only be logged once per pvestatd run,
so it does not spam the log.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Wed, 2 Dec 2020 12:56:31 +0000 (13:56 +0100)]
fix #3182 #3183: change backup retention mask logic
instead of relying on the contentTypeField (which does not need to
exists, e.g. for iscsi), explicitely write it into the panel/icon
mapping and check that
better would be if we query the backend about storage capabilities,
but such an api call does not exist yet, so this should be ok for now
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Thomas Lamprecht [Wed, 2 Dec 2020 17:00:44 +0000 (18:00 +0100)]
test: allow running replication tests in parallel
running multiple workers reduces built time from >3s to ~0.6s here.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 2 Dec 2020 16:57:18 +0000 (17:57 +0100)]
test: replication: cleanup use statements
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 2 Dec 2020 15:19:34 +0000 (16:19 +0100)]
test: buildsys: allow to execute vzdump tests in parallel
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 2 Dec 2020 15:18:41 +0000 (16:18 +0100)]
test: buildsys: rework target names, prefix with test
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Fabian Ebner [Tue, 1 Dec 2020 08:24:21 +0000 (09:24 +0100)]
vzdump: defaults: correctly parse prune-backups and convert maxfiles
Also simplify handling in new(), now that we never have maxfiles there anymore.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Fabian Ebner [Tue, 1 Dec 2020 08:24:20 +0000 (09:24 +0100)]
vzdump: convert maxfiles CLI parameter to prune-backups
in preparation to clean up handling in new().
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Fabian Ebner [Tue, 1 Dec 2020 08:24:19 +0000 (09:24 +0100)]
vzdump: storage_info: adapt to new maxfiles backend behavior
It's automatically converted to prune-backups when using storage_config() now.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Fabian Ebner [Tue, 1 Dec 2020 08:24:18 +0000 (09:24 +0100)]
test: add tests for retention parameters for vzdump's new()
To get a more complete picture, instead of mocking storage_config,
PVE::Cluster's get_config is mocked. This ensures that the prune-backups
validation and the maxfiles conversion are also called.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Thomas Lamprecht [Wed, 2 Dec 2020 10:45:33 +0000 (11:45 +0100)]
api: fixup: commit change to storage module
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 2 Dec 2020 10:28:39 +0000 (11:28 +0100)]
ui: USB selector: use new API endpoint
so that we can sunset the usbscan from pve-storage's scan API, which
was never fitting there anyway.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 2 Dec 2020 10:26:57 +0000 (11:26 +0100)]
api: add usb list in hardware endpoint
As envisioned in[0][1], better late than never.
[0]: commit
3bca5efd9c219d97c2eac5685bf6cac579a3b0f1
[1]: https://lists.proxmox.com/pipermail/pve-devel/2018-November/034694.html
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 1 Dec 2020 18:30:13 +0000 (19:30 +0100)]
api: use storage scan module from pve-storage
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominik Csapak [Thu, 26 Nov 2020 08:19:53 +0000 (09:19 +0100)]
ui: fix usage of findRecord
findRecord does not match exactly, but only at the beginning and
case insensitive, by default. Change all calls to be case sensitive
and an exactmatch (we never want the default behaviour afaics).
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Thu, 26 Nov 2020 07:58:25 +0000 (08:58 +0100)]
ui: storage: find the correct storage record
by default, findRecord only anchors at the beginning, e.g.
findRecord('id', 'foo');
could find either an entry with id 'foo', 'foobar', 'foobaz', etc.
extend the call to set 'exactMatch' to true, else we sometimes
used the content types of storage e.g., 'local-lvm' for showing
the panels for 'local'
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Fabian Grünbichler [Thu, 26 Nov 2020 09:42:18 +0000 (10:42 +0100)]
ui: don't refer to enc key as 'master key'
the master key is something entirely different, this might confuse
users..
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
Thomas Lamprecht [Wed, 25 Nov 2020 15:19:56 +0000 (16:19 +0100)]
bump version to 6.3-2
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 25 Nov 2020 15:19:50 +0000 (16:19 +0100)]
ui: pbs: set onlineHelp (again)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Stefan Reiter [Tue, 24 Nov 2020 16:52:05 +0000 (17:52 +0100)]
ui: bootorder: add onlineHelp link
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
Dominik Csapak [Wed, 25 Nov 2020 12:56:40 +0000 (13:56 +0100)]
api: metrics/server: test connection on add/update
just a basic check, but better than not checking at all
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Thomas Lamprecht [Wed, 25 Nov 2020 13:49:23 +0000 (14:49 +0100)]
ui: storage edit: ensure to set keep-all by default
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominik Csapak [Wed, 25 Nov 2020 12:04:37 +0000 (13:04 +0100)]
ui: pbs key show: improve labelWidth for 'Key' in translations
it is not that short in other languages, e.g. German
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominic Jäger [Wed, 25 Nov 2020 12:15:19 +0000 (13:15 +0100)]
ui: storage: pbsedit: Fix spelling
No e in unusable.
to loose means to free from restraint, or to make less tight or strict [1].
to lose means to fail to keep, or to miss something from one's possession [2].
So "losing" (instead of "loosing") would be bad.
[0] https://www.merriam-webster.com/dictionary/unusable
[1] https://www.merriam-webster.com/dictionary/loose
[2] https://www.merriam-webster.com/dictionary/lose
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Thomas Lamprecht [Wed, 25 Nov 2020 12:15:19 +0000 (13:15 +0100)]
ui: storage edit: avoid returning prune values if unsupported
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Wolfgang Bumiller [Wed, 25 Nov 2020 10:36:43 +0000 (11:36 +0100)]
ad #3140: allow interface suffix in dns entries
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Dominic Jäger [Wed, 25 Nov 2020 10:29:24 +0000 (11:29 +0100)]
ui: metrics: Link help button to correct chapter
... instead of generic PVE admin guide.
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Dominik Csapak [Wed, 25 Nov 2020 11:06:26 +0000 (12:06 +0100)]
api: metrics/server: add minimum and maximum to port schema
we just added the api, so it would be good to only accept valid ports
(they were wrapped before)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 22:45:11 +0000 (23:45 +0100)]
bump version to 6.3-1
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Stoiko Ivanov [Tue, 24 Nov 2020 18:55:47 +0000 (19:55 +0100)]
api2: osd destroy: untaint device before pvremove
We get the device list from ceph-volume lvm list, and decode the json
output, which at that point is tainted (perlsec (1)).
Untaint it here before calling, because it is currently the only
call-site using the information in a problematic way (run_command).
(the only other call-site being in pve5to6)
Alternatively we could untaint while reading the information, but then
should only return a small subset of the ceph-volume output.
The issue is most likely due to
cb9db10c1a9855cf40ff13e81f9dd97d6a9b2698 in pve-common ('run_command:
improve performance for logging and long lines'),
Tested on a virtual testsetup by creating OSDs with second DB disk,
and destroying it via GUI (did not manage to get the error without the
DB disk)
Reported via our community forum:
https://forum.proxmox.com/threads/insecure-dependency-in-exec-during-osd-destroy.79574/
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Stoiko Ivanov [Tue, 24 Nov 2020 18:55:46 +0000 (19:55 +0100)]
api2: osd destroy: fix error function
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 22:36:02 +0000 (23:36 +0100)]
ui: storage content: add encryption and verification columns for PBS
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 22:35:39 +0000 (23:35 +0100)]
ui: factor out backup verification renderer
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 22:35:15 +0000 (23:35 +0100)]
ui: guest backup view: add encrypted column for PBS storages
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 22:34:25 +0000 (23:34 +0100)]
ui: storage content: allow to specify extraColumns (again)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 22:33:53 +0000 (23:33 +0100)]
ui: storage/browser: pass storage plugin type to content panels
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 22:32:20 +0000 (23:32 +0100)]
ui: storage: pbs paperkey: print short fingerprint in heading
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 22:09:36 +0000 (23:09 +0100)]
ui: storage: pbs: move datastore field to right column for balance
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 22:07:32 +0000 (23:07 +0100)]
ui: storage: pbs: improve encryption key handling
Move encryption key handling in its own tab.
Allow uploads, warn more visible on edit/remove
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 22:08:43 +0000 (23:08 +0100)]
ui: utils: add more generic loadTextFromFile upload helper
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 22:06:21 +0000 (23:06 +0100)]
ui: storage: base: allow adding extra tab panels
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 22:01:53 +0000 (23:01 +0100)]
api: resources: return plugin type
The storage one for now.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 16:09:51 +0000 (17:09 +0100)]
ui: dc/storage: set onlineHelp for prune tab in edit window
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 15:01:48 +0000 (16:01 +0100)]
bump version to 6.2-17
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominik Csapak [Tue, 24 Nov 2020 14:32:55 +0000 (15:32 +0100)]
API2/Ceph: fix createpools 'add_storages' parameter
by deleteing it from $ceph_param we deleted it also from
$param since it was only a reference
fix it by extracting it beforehand
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Fabian Ebner [Tue, 24 Nov 2020 14:31:36 +0000 (15:31 +0100)]
ui: storage: show no-keeps hint exactly when needed
extracting the logic from the previous checkbox listener into a function, which
is also called on field changes and once in afterrender. Calling it initially
makes sure the hint is also displayed at the beginning when editing a storage
with no retention options configured, and the initial disabling of the input
fields for the isCreate case now also happens through that call.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 13:26:18 +0000 (14:26 +0100)]
ui: guest backups: add separator, fix left-over Comments title
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Fabian Ebner [Tue, 24 Nov 2020 13:00:53 +0000 (14:00 +0100)]
ui: storage backup view: add prune window
adapted from PBS. Main differences are:
* API has GET/DELETE distinction instead of 'dry-run'
* API expects a single property string for the prune options
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Dominik Csapak [Tue, 24 Nov 2020 09:09:35 +0000 (10:09 +0100)]
ui: add ability to show and edit comments for backups
for now we filter out pbs storages
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Tue, 24 Nov 2020 09:09:34 +0000 (10:09 +0100)]
ui: change comment column to notes
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 12:38:50 +0000 (13:38 +0100)]
followup code cleanup
actually cleaning up the initial state, the last patch was OK as is..
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominic Jäger [Tue, 24 Nov 2020 12:15:58 +0000 (13:15 +0100)]
storage: base edit: Don't send delete during creation
... as this is now allowed by the API (createSchema() in PVE::SectionConfig).
It is only allowed by the update API call (updateSchema()).
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Dylan Whyte [Tue, 24 Nov 2020 10:14:47 +0000 (11:14 +0100)]
UI: Ceph Wizard: language fixup
Improve the language found in the ceph install Wizard.
Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
Thomas Lamprecht [Tue, 24 Nov 2020 08:27:18 +0000 (09:27 +0100)]
ui: wizard: fix ceph docs link
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Mon, 23 Nov 2020 19:12:56 +0000 (20:12 +0100)]
ui: avoid ||=
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Mon, 23 Nov 2020 13:01:54 +0000 (14:01 +0100)]
bump version to 6.2-16
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>