]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/log
mirror_ubuntu-eoan-kernel.git
15 years agoStaging: rt2870: remove dead CARRIER_DETECTION_SUPPORT code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:05:02 +0000 (16:05 +0200)]
Staging: rt2870: remove dead CARRIER_DETECTION_SUPPORT code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt2860: remove dead CARRIER_DETECTION_SUPPORT code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:05:01 +0000 (16:05 +0200)]
Staging: rt2860: remove dead CARRIER_DETECTION_SUPPORT code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt3070: remove dead DFS_SUPPORT code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:05:00 +0000 (16:05 +0200)]
Staging: rt3070: remove dead DFS_SUPPORT code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt2870: remove dead DFS_SUPPORT code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:59 +0000 (16:04 +0200)]
Staging: rt2870: remove dead DFS_SUPPORT code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt2860: remove dead DFS_SUPPORT code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:58 +0000 (16:04 +0200)]
Staging: rt2860: remove dead DFS_SUPPORT code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt3070: remove dead BLOCK_NET_IF code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:57 +0000 (16:04 +0200)]
Staging: rt3070: remove dead BLOCK_NET_IF code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt2870: remove dead BLOCK_NET_IF code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:56 +0000 (16:04 +0200)]
Staging: rt2870: remove dead BLOCK_NET_IF code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt2860: remove dead BLOCK_NET_IF code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:54 +0000 (16:04 +0200)]
Staging: rt2860: remove dead BLOCK_NET_IF code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt3070: remove dead RALINK_ATE code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:53 +0000 (16:04 +0200)]
Staging: rt3070: remove dead RALINK_ATE code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt2870: remove dead RALINK_ATE code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:52 +0000 (16:04 +0200)]
Staging: rt2870: remove dead RALINK_ATE code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt2860: remove dead RALINK_ATE code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:50 +0000 (16:04 +0200)]
Staging: rt2860: remove dead RALINK_ATE code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt3070: remove dead BIN_IN_FILE code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:48 +0000 (16:04 +0200)]
Staging: rt3070: remove dead BIN_IN_FILE code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt2870: remove dead BIN_IN_FILE code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:47 +0000 (16:04 +0200)]
Staging: rt2870: remove dead BIN_IN_FILE code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt2860: remove dead BIN_IN_FILE code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:47 +0000 (16:04 +0200)]
Staging: rt2860: remove dead BIN_IN_FILE code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt3070: remove dead NINTENDO_AP code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:46 +0000 (16:04 +0200)]
Staging: rt3070: remove dead NINTENDO_AP code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt2870: remove dead NINTENDO_AP code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:46 +0000 (16:04 +0200)]
Staging: rt2870: remove dead NINTENDO_AP code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt2860: remove dead NINTENDO_AP code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:45 +0000 (16:04 +0200)]
Staging: rt2860: remove dead NINTENDO_AP code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt3070: remove dead UCOS code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:44 +0000 (16:04 +0200)]
Staging: rt3070: remove dead UCOS code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt2870: remove dead UCOS code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:43 +0000 (16:04 +0200)]
Staging: rt2870: remove dead UCOS code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt2860: remove dead UCOS code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:42 +0000 (16:04 +0200)]
Staging: rt2860: remove dead UCOS code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt3070: remove dead CONFIG_APSTA_MIXED_SUPPORT code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:41 +0000 (16:04 +0200)]
Staging: rt3070: remove dead CONFIG_APSTA_MIXED_SUPPORT code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt2870: remove dead CONFIG_APSTA_MIXED_SUPPORT code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:40 +0000 (16:04 +0200)]
Staging: rt2870: remove dead CONFIG_APSTA_MIXED_SUPPORT code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt2860: remove dead CONFIG_APSTA_MIXED_SUPPORT code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:38 +0000 (16:04 +0200)]
Staging: rt2860: remove dead CONFIG_APSTA_MIXED_SUPPORT code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt2870: remove dead APCLI_SUPPORT code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:37 +0000 (16:04 +0200)]
Staging: rt2870: remove dead APCLI_SUPPORT code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt2860: remove dead APCLI_SUPPORT code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:36 +0000 (16:04 +0200)]
Staging: rt2860: remove dead APCLI_SUPPORT code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt3070: remove dead MLME_EX code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:35 +0000 (16:04 +0200)]
Staging: rt3070: remove dead MLME_EX code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt3070: remove dead WDS_SUPPORT code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:34 +0000 (16:04 +0200)]
Staging: rt3070: remove dead WDS_SUPPORT code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt2870: remove dead WDS_SUPPORT code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:33 +0000 (16:04 +0200)]
Staging: rt2870: remove dead WDS_SUPPORT code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt2860: remove dead WDS_SUPPORT code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:33 +0000 (16:04 +0200)]
Staging: rt2860: remove dead WDS_SUPPORT code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt3070: remove dead *WSC_INCLUDED code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:32 +0000 (16:04 +0200)]
Staging: rt3070: remove dead *WSC_INCLUDED code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt2870: remove dead WSC_AP_SUPPORT code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:31 +0000 (16:04 +0200)]
Staging: rt2870: remove dead WSC_AP_SUPPORT code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt2860: remove dead WSC_AP_SUPPORT code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:30 +0000 (16:04 +0200)]
Staging: rt2860: remove dead WSC_AP_SUPPORT code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt3070: remove dead UNDER_CE code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:30 +0000 (16:04 +0200)]
Staging: rt3070: remove dead UNDER_CE code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt2870: remove dead UNDER_CE code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:29 +0000 (16:04 +0200)]
Staging: rt2870: remove dead UNDER_CE code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt2860: remove dead UNDER_CE code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:28 +0000 (16:04 +0200)]
Staging: rt2860: remove dead UNDER_CE code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt2860: remove dead WIN_NDIS code
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:27 +0000 (16:04 +0200)]
Staging: rt2860: remove dead WIN_NDIS code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt2870: remove IWE_STREAM_ADD_*() macros
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:26 +0000 (16:04 +0200)]
Staging: rt2870: remove IWE_STREAM_ADD_*() macros

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt2860: remove IWE_STREAM_ADD_*() macros
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:25 +0000 (16:04 +0200)]
Staging: rt2860: remove IWE_STREAM_ADD_*() macros

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt3070: remove kernel version compatibility wrappers
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:23 +0000 (16:04 +0200)]
Staging: rt3070: remove kernel version compatibility wrappers

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt2870: remove kernel version compatibility wrappers
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:22 +0000 (16:04 +0200)]
Staging: rt2870: remove kernel version compatibility wrappers

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt2870: remove unused files
Bartlomiej Zolnierkiewicz [Sun, 26 Apr 2009 14:04:20 +0000 (16:04 +0200)]
Staging: rt2870: remove unused files

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: pohmelfs: Storage class should be before const qualifier
Tobias Klauser [Sun, 26 Apr 2009 13:06:09 +0000 (15:06 +0200)]
Staging: pohmelfs: Storage class should be before const qualifier

The C99 specification states in section 6.11.5:

The placement of a storage-class specifier other than at the beginning
of the declaration specifiers in a declaration is an obsolescent
feature.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: pohmelfs: Remove braces around single statements
Bill Pemberton [Wed, 22 Apr 2009 12:59:15 +0000 (08:59 -0400)]
Staging: pohmelfs: Remove braces around single statements

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: pohmelfs: Remove C99 comments
Bill Pemberton [Wed, 22 Apr 2009 12:59:14 +0000 (08:59 -0400)]
Staging: pohmelfs: Remove C99 comments

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Evgeniy Polyakov <zbr@ioremap.net>
15 years agoStaging: pohmelfs: move open brace to same line on structs
Bill Pemberton [Wed, 22 Apr 2009 12:59:13 +0000 (08:59 -0400)]
Staging: pohmelfs: move open brace to same line on structs

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: wlan-ng: Update README file. Remove Lindent task
Mithlesh Thukral [Fri, 5 Jun 2009 10:03:59 +0000 (15:33 +0530)]
Staging: wlan-ng: Update README file. Remove Lindent task

Remove Lindent changes as a TODO item in the wlan-ng directory of staging tree.

Signed-off-by: Mithlesh Thukral <mithlesh@linsyssoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: wlan-ng: Lindent cleanups
Mithlesh Thukral [Mon, 25 May 2009 13:36:16 +0000 (19:06 +0530)]
Staging: wlan-ng: Lindent cleanups

Lindent script cleanups in wlan-ng driver in the staging tree.
This is a item in the TODO list.

Signed-off-by: Mithlesh Thukral <mithlesh@linsyssoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: wlan-ng: p80211wext.c: problem with IW_ENCODE_ALG_WEP
Julia Lawall [Tue, 5 May 2009 13:47:06 +0000 (15:47 +0200)]
Staging: wlan-ng: p80211wext.c: problem with IW_ENCODE_ALG_WEP

The expression !(ext->alg & IW_ENCODE_ALG_WEP) appears to be incorrect,
because there are several possible values for ext->alg that give 1 when
bit-anded with IW_ENCODE_ALG_WEP.  Therefore Richard Kennedy suggested to
rewrite the code with !=

Added \n at the end of the debug string as well.

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: wlan-ng: Change KERN_DEBUG or pr_debug to match orig driver
Karl Relton [Fri, 8 May 2009 19:54:17 +0000 (20:54 +0100)]
Staging: wlan-ng: Change KERN_DEBUG or pr_debug to match orig driver

Change uses of KERN_DEBUG over to pr_debug to match original driver
where messages are only needed during driver development.

Signed-off-by: Karl Relton <karllinuxtest.relton@ntlworld.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: wlan-ng: Move firmware loading into driver
Karl Relton [Fri, 17 Apr 2009 09:15:34 +0000 (10:15 +0100)]
Staging: wlan-ng: Move firmware loading into driver

Move prism2 firmware loading from userspace into driver, using linux
request_firmware(). Firmware is now loaded (if available) on device
probing, before it is registered as a netdevice and advertised to userspace.

Signed-off-by: Karl Relton <karllinuxtest.relton@ntlworld.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: winbond: mac80211 - unify config_interface and bss_info_changed
Tim Gardner [Wed, 29 Apr 2009 21:01:42 +0000 (15:01 -0600)]
Staging: winbond: mac80211 - unify config_interface and bss_info_changed

The commit 'mac80211: unify config_interface and bss_info_changed' from
Johannes Berg <johannes@sipsolutions.net> removed the config_interface structure
tag from struct ieee80211_ops. The BSSID detection functionality migrated to
ieee80211_ops.bss_info_changed.

Since wbsoft_config_interface() was largely empty, there wasn't much to do
other then to remove the function itself. There is currently no support
for BSSID change detection.

Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: w35und: merge rest of wbhal.c to phy_calibration.c
Pekka Enberg [Wed, 8 Apr 2009 08:51:22 +0000 (11:51 +0300)]
Staging: w35und: merge rest of wbhal.c to phy_calibration.c

Impact: cleanup

The remaining functions are local to phy_calibration.c so move them
there and remove wbhal.c.

Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: w35und: inline hal_set_rf_power() to mto.c
Pekka Enberg [Wed, 8 Apr 2009 08:51:21 +0000 (11:51 +0300)]
Staging: w35und: inline hal_set_rf_power() to mto.c

Impact: cleanup

It's a trivial wrapper that is used in only one place, so lets inline it.

Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: w35und: merge wbhal.c to wbusb.c
Pekka Enberg [Wed, 8 Apr 2009 08:51:20 +0000 (11:51 +0300)]
Staging: w35und: merge wbhal.c to wbusb.c

Impact: cleanup

This patch moves all the functions in wbhal.c that are used only in
wbusb.c to the latter file.

Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: w35und: reformat wbhal.c
Pekka Enberg [Wed, 8 Apr 2009 08:51:19 +0000 (11:51 +0300)]
Staging: w35und: reformat wbhal.c

Impact: cleanup

In preparation for merging wbhal.c with wbusb.c, use Lindet to reformat
the file.

Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: w35und: make led lookup tables static
Pekka Enberg [Wed, 8 Apr 2009 08:14:06 +0000 (11:14 +0300)]
Staging: w35und: make led lookup tables static

Impact: cleanup

No need to keep read-only data on the stack.

Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: w35und: remove MODULE_AUTHOR
Pekka Enberg [Wed, 8 Apr 2009 08:14:05 +0000 (11:14 +0300)]
Staging: w35und: remove MODULE_AUTHOR

Impact: cleanup

The contact details in MODULE_AUTHOR do not reflect current state of
affairs so remove it.

Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: w35und: reformat wbusb.c
Pekka Enberg [Wed, 8 Apr 2009 08:14:04 +0000 (11:14 +0300)]
Staging: w35und: reformat wbusb.c

Impact: cleanup

Use scripts/Lindent on the file and clean up the rest by hand.

Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: w35und: inline hal_set_phy_type() to wb35_hw_init()
Pekka Enberg [Wed, 8 Apr 2009 08:14:03 +0000 (11:14 +0300)]
Staging: w35und: inline hal_set_phy_type() to wb35_hw_init()

Impact: cleanup

The hal_set_phy_type() is called in wb35_hw_init() only so inline the
function there. Also remove a redundant assignment of ->phy_type to
RF_WB_242_1.

Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: w35und: clean up comments in wbusb.c
Pekka Enberg [Wed, 8 Apr 2009 08:14:02 +0000 (11:14 +0300)]
Staging: w35und: clean up comments in wbusb.c

Impact: cleanup

Remove some useless comments and clean up others.

Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: w35und: simplify hal_init_hardware() and hal_halt()
Pekka Enberg [Wed, 8 Apr 2009 08:14:01 +0000 (11:14 +0300)]
Staging: w35und: simplify hal_init_hardware() and hal_halt()

Impact: cleanup

Now that hal_halt() is called from wb35_hw_halt() only where
->InitialResource is always set to 4, we can simplify
hal_init_hardware() and hal_halt().

Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: w35und: more simplify hal_init_hardware() error handling
Pekka Enberg [Wed, 8 Apr 2009 08:14:00 +0000 (11:14 +0300)]
Staging: w35und: more simplify hal_init_hardware() error handling

Impact: fix, cleanup

If initialization in hal_init_hardware() fails, we call hal_halt() to
clean up and release resource. However, hal_halt() will attempt to
call del_timer_sync() on ->LEDTimer on "stage 3" although it's not
initialized at that point. Fix that up by simplifying error handling
logic in hal_init_hardware() with gotos.

Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: w35und: simplify hal_init_hardware() error handling
Pekka Enberg [Wed, 8 Apr 2009 08:13:59 +0000 (11:13 +0300)]
Staging: w35und: simplify hal_init_hardware() error handling

Impact: cleanup

Use gotos to simplify the deep if-statement nesting in
hal_init_hardware().

Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: w35und: simplify error handling in wb35_hw_init()
Pekka Enberg [Wed, 8 Apr 2009 08:13:58 +0000 (11:13 +0300)]
Staging: w35und: simplify error handling in wb35_hw_init()

Impact: cleanup

Change hal_init_hardware() to return an error code rather than a boolean
to simplify error handling in wb35_hw_init().

Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: w35und: move hal_init_hardware() and hal_halt() int wbusb.c
Pekka Enberg [Wed, 8 Apr 2009 08:13:57 +0000 (11:13 +0300)]
Staging: w35und: move hal_init_hardware() and hal_halt() int wbusb.c

Impact: cleanup

The hal_init_hardware() and hal_halt() functions are only used in
wbusb.c so move them there.

Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: w35und: replace switch error handling with gotos in wb35_hw_init()
Pekka Enberg [Wed, 8 Apr 2009 08:13:56 +0000 (11:13 +0300)]
Staging: w35und: replace switch error handling with gotos in wb35_hw_init()

Impact: cleanup

This patch replaces the switch-based error handling in wb35_hw_init()
with regular gotos.

Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: w35und: remove unused code from wbsoft_configure_filter()
Pekka Enberg [Fri, 27 Mar 2009 17:46:45 +0000 (19:46 +0200)]
Staging: w35und: remove unused code from wbsoft_configure_filter()

We don't initialize hardware multicast filter in the driver nor do we know how
to do that. Therefore, remove some code that isn't actually used from
wbsoft_configure_filter().

Cc: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging winbond: boolean negation and bitwise operation in wrong order
Diego Liziero [Tue, 14 Apr 2009 02:33:54 +0000 (04:33 +0200)]
Staging winbond: boolean negation and bitwise operation in wrong order

The semantic patch that makes this change is:
(http://www.emn.fr/x-info/coccinelle/)

@@ expression E; constant C; @@
(
- !E == C
+ E != C
)

Signed-off-by: Diego Liziero <diegoliz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: otus: beyond ARRAY_SIZE of wd->ap.wds.encryMode
Roel Kluin [Wed, 20 May 2009 00:36:29 +0000 (02:36 +0200)]
Staging: otus: beyond ARRAY_SIZE of wd->ap.wds.encryMode

Do not go beyond ARRAY_SIZE of wd->ap.wds.encryMode

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: otus: 80211core/ccmd.c: Fix Coding Style
Dragoslav Zaric [Sun, 26 Apr 2009 08:19:02 +0000 (10:19 +0200)]
Staging: otus: 80211core/ccmd.c: Fix Coding Style

Signed-off-by: Dragoslav Zaric <dragoslav.zaric.kd@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: remove driver_data direct access of struct device
Greg Kroah-Hartman [Thu, 30 Apr 2009 21:43:31 +0000 (14:43 -0700)]
Staging: remove driver_data direct access of struct device

In the near future, the driver core is going to not allow direct access
to the driver_data pointer in struct device.  Instead, the functions
dev_get_drvdata() and dev_set_drvdata() should be used.  These functions
have been around since the beginning, so are backwards compatible with
all older kernel versions.

Cc: Leon Woestenberg <leon@sidebranch.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: fix operator precedence errors
Roel Kluin [Thu, 16 Apr 2009 20:22:40 +0000 (22:22 +0200)]
Staging: fix operator precedence errors

`!' has a higher precedence than `&' and `|' has a higher precedence than `?'

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: stlc45xx: replace print_mac with %pM
Alexander Beregalov [Sat, 11 Apr 2009 19:03:04 +0000 (23:03 +0400)]
Staging: stlc45xx: replace print_mac with %pM

Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: remove unused #include <linux/version.h>'s
Huang Weiyi [Mon, 6 Apr 2009 09:20:29 +0000 (17:20 +0800)]
Staging: remove unused #include <linux/version.h>'s

Remove unused #include <linux/version.h>'s.

Signed-off-by: Huang Weiyi <weiyi.huang@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt3070: remove dupilcated #include
Huang Weiyi [Mon, 6 Apr 2009 09:20:23 +0000 (17:20 +0800)]
Staging: rt3070: remove dupilcated #include

Remove dupilcated #include in drivers/staging/rt3070/rt_linux.h.

Signed-off-by: Huang Weiyi <weiyi.huang@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rtl8187se: wmm_param[1].ac_aci_acm_aifsn tested twice
Roel Kluin [Mon, 18 May 2009 15:31:36 +0000 (17:31 +0200)]
Staging: rtl8187se: wmm_param[1].ac_aci_acm_aifsn tested twice

wmm_param[1].ac_aci_acm_aifsn was tested twice, the second should have been
wmm_param[3].ac_aci_acm_aifsn.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rtl8187se: convert to net_device_ops
Alexander Beregalov [Sat, 9 May 2009 23:06:54 +0000 (03:06 +0400)]
Staging: rtl8187se: convert to net_device_ops

Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
Acked-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rtl8187se: Use to_delayed_work
Jean Delvare [Fri, 3 Apr 2009 15:46:49 +0000 (17:46 +0200)]
Staging: rtl8187se: Use to_delayed_work

Use the recently added to_delayed_work() helper function.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt2870: Don't call sprintf() with overlapping input and output.
Anders Kaseorg [Tue, 24 Mar 2009 20:41:55 +0000 (16:41 -0400)]
Staging: rt2870: Don't call sprintf() with overlapping input and output.

The use of sprintf() to append to a buffer, as in
  sprintf(buf, "%sEntry: %d\n", buf, i)
is not valid according to C99 ("If copying takes place between objects
that overlap, the behavior is undefined.").  It breaks at least in
userspace under gcc -D_FORTIFY_SOURCE.  Replace this construct with
  sprintf(buf + strlen(buf), "Entry: %d\n", i)

This patch was automatically generated using
  perl -0pe 's/(sprintf\s*\(\s*([^,]*))(\s*,\s*")%s((?:[^"\\]|\\.)*"\s*,)\s*\2\s*,/$1 + strlen($2)$3$4/g'
  perl -0pe 's/(snprintf\s*\(\s*([^,]*))(\s*,[^,]*?)(\s*,\s*")%s((?:[^"\\]|\\.)*"\s*,)\s*\2\s*,/$1 + strlen($2)$3 - strlen($2)$4$5/g'

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt2860: Don't call sprintf() with overlapping input and output.
Anders Kaseorg [Tue, 24 Mar 2009 20:40:41 +0000 (16:40 -0400)]
Staging: rt2860: Don't call sprintf() with overlapping input and output.

The use of sprintf() to append to a buffer, as in
  sprintf(buf, "%sEntry: %d\n", buf, i)
is not valid according to C99 ("If copying takes place between objects
that overlap, the behavior is undefined.").  It breaks at least in
userspace under gcc -D_FORTIFY_SOURCE.  Replace this construct with
  sprintf(buf + strlen(buf), "Entry: %d\n", i)

This patch was automatically generated using
  perl -0pe 's/(sprintf\s*\(\s*([^,]*))(\s*,\s*")%s((?:[^"\\]|\\.)*"\s*,)\s*\2\s*,/$1 + strlen($2)$3$4/g'
  perl -0pe 's/(snprintf\s*\(\s*([^,]*))(\s*,[^,]*?)(\s*,\s*")%s((?:[^"\\]|\\.)*"\s*,)\s*\2\s*,/$1 + strlen($2)$3 - strlen($2)$4$5/g'

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: rt3070: replace __FUNCTION__ usages
Alessio Igor Bogani [Tue, 24 Mar 2009 18:30:26 +0000 (19:30 +0100)]
Staging: rt3070: replace __FUNCTION__ usages

__FUNCTION__ is gcc-specific, use __func__

Signed-off-by: Alessio Igor Bogani <abogani@texware.it>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: sxg: Add missing __devexit_p()
Jean Delvare [Thu, 4 Jun 2009 11:35:15 +0000 (13:35 +0200)]
Staging: sxg: Add missing __devexit_p()

The remove function uses __devexit, so the .remove assignment needs
__devexit_p() to fix a build error with hotplug disabled.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: sxg: replace __FUNCTION__ usages
Alessio Igor Bogani [Tue, 24 Mar 2009 18:29:45 +0000 (19:29 +0100)]
Staging: sxg: replace __FUNCTION__ usages

__FUNCTION__ is gcc-specific, use __func__

Signed-off-by: Alessio Igor Bogani <abogani@texware.it>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: meilhaus: fix build warnings
Greg Kroah-Hartman [Thu, 4 Jun 2009 18:29:54 +0000 (11:29 -0700)]
Staging: meilhaus: fix build warnings

This fixes some build warnings in the meilhaus driver.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: meilhaus: Remove long-deprecated SA_* interrupt macros.
Robert P. J. Day [Sat, 9 May 2009 13:40:14 +0000 (09:40 -0400)]
Staging: meilhaus: Remove long-deprecated SA_* interrupt macros.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agostaging: meilhaus, move tables to .c
Jiri Slaby [Thu, 26 Mar 2009 08:34:13 +0000 (09:34 +0100)]
staging: meilhaus, move tables to .c

Remove pci and usb tables from the header and place them directly in
the code.

While at it, use PCI_VDEVICE() to shorten the code.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: David Kiliani <mail@davidkiliani.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agostaging: meilhaus, annotate cpi functions
Jiri Slaby [Thu, 26 Mar 2009 08:34:12 +0000 (09:34 +0100)]
staging: meilhaus, annotate cpi functions

Add __devinit and __devexit to pci probe/remove. Also make pci_driver
static.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: David Kiliani <mail@davidkiliani.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agostaging: meilhaus, switch to misc device
Jiri Slaby [Thu, 26 Mar 2009 08:34:11 +0000 (09:34 +0100)]
staging: meilhaus, switch to misc device

There is no need to occupy one major number because of one device.

Switch to misc device, which also emits uevent, so that the dev node
is also created by udev.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: David Kiliani <mail@davidkiliani.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: agnx: fix build warnings
Greg Kroah-Hartman [Thu, 4 Jun 2009 18:29:54 +0000 (11:29 -0700)]
Staging: agnx: fix build warnings

This fixes some build warnings in the agnx driver.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: agnx: replace print_mac with %pM
Alexander Beregalov [Sat, 11 Apr 2009 19:01:21 +0000 (23:01 +0400)]
Staging: agnx: replace print_mac with %pM

Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agostaging: agnx, fix bssid compiler warnings
Jiri Slaby [Thu, 26 Mar 2009 08:34:10 +0000 (09:34 +0100)]
staging: agnx, fix bssid compiler warnings

conf->bssid is const. Propagate const to not get compiler warnings:
agnx/pci.c: In function ‘agnx_config_interface’:
agnx/pci.c:319: warning: passing argument 2 of ‘agnx_set_bssid’ discards qualifiers from pointer target type
agnx/pci.c:321: warning: passing argument 2 of ‘hash_write’ discards qualifiers from pointer target type

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agostaging: agnx, fix fail paths in probe
Jiri Slaby [Thu, 26 Mar 2009 08:34:09 +0000 (09:34 +0100)]
staging: agnx, fix fail paths in probe

Return error on fail paths instead of 0.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agostaging: agnx, remove memlens from probe
Jiri Slaby [Thu, 26 Mar 2009 08:34:08 +0000 (09:34 +0100)]
staging: agnx, remove memlens from probe

Pass 0 to pci_iomap instead. It will cope with that per se.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agostaging: agnx, probe cleanup
Jiri Slaby [Thu, 26 Mar 2009 08:34:07 +0000 (09:34 +0100)]
staging: agnx, probe cleanup

- switch printks to dev_*
- remove useless comments
- remove useless prints (for info we can obtain from lspci or /sys)

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: comedi: uses udelay, needs delay.h
Randy Dunlap [Fri, 5 Jun 2009 18:10:42 +0000 (11:10 -0700)]
Staging: comedi: uses udelay, needs delay.h

comedi driver(s) use udelay() so they need to #include delay.h.

drivers/staging/comedi/drivers/adq12b.c: In function 'adq12b_ai_rinsn':
drivers/staging/comedi/drivers/adq12b.c:328: error: implicit declaration of function 'udelay'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: comedi: cb_pcidas.c: Fix build warning (type mismatch)
Gerard Lledo [Wed, 27 May 2009 14:35:19 +0000 (17:35 +0300)]
Staging: comedi: cb_pcidas.c: Fix build warning (type mismatch)

spin_lock_irqsave expects flags to be unsigned long, not unsigned int.

Signed-off-by: Gerard Lledo <gerard.lledo@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: comedi: usbdux: buffer overflow error handling
Bernd Porr [Sun, 24 May 2009 19:36:09 +0000 (20:36 +0100)]
Staging: comedi: usbdux: buffer overflow error handling

These changes guarantee that the URBs are not resubmitted in case of a
comedi buffer overflow.  Otherwise this runs in the background even when
the userspace program has terminated.

From: Bernd Porr <BerndPorr@f2s.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agostaging: comedi: Move pcm do_cmdtest function into a single source file
Bill Pemberton [Thu, 14 May 2009 19:24:29 +0000 (15:24 -0400)]
staging: comedi: Move pcm do_cmdtest function into a single source file

Many of the comedi source code has functions that were created with
cut and paste, this moves the do_cmdtest function into a single file.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agostaging: comedi: Remove MIN macro
Bill Pemberton [Thu, 14 May 2009 19:24:28 +0000 (15:24 -0400)]
staging: comedi: Remove MIN macro

Remove the MIN() macro and instead use the min() provided by kernel.h

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agostaging: comedi: fix missing parentheses
Roel Kluin [Thu, 14 May 2009 11:58:26 +0000 (13:58 +0200)]
staging: comedi: fix missing parentheses

Add missing parentheses.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>