Hangbin Liu [Wed, 18 Jan 2023 02:09:27 +0000 (10:09 +0800)]
selftests/net: mv bpf/nat6to4.c to net folder
There are some issues with the bpf/nat6to4.c building.
1. It use TEST_CUSTOM_PROGS, which will add the nat6to4.o to
kselftest-list file and run by common run_tests.
2. When building the test via `make -C tools/testing/selftests/
TARGETS="net"`, the nat6to4.o will be build in selftests/net/bpf/
folder. But in test udpgro_frglist.sh it refers to ../bpf/nat6to4.o.
The correct path should be ./bpf/nat6to4.o.
3. If building the test via `make -C tools/testing/selftests/ TARGETS="net"
install`. The nat6to4.o will be installed to kselftest_install/net/
folder. Then the udpgro_frglist.sh should refer to ./nat6to4.o.
To fix the confusing test path, let's just move the nat6to4.c to net folder
and build it as TEST_GEN_FILES.
Fixes: edae34a3ed92 ("selftests net: add UDP GRO fraglist + bpf self-tests") Tested-by: Björn Töpel <bjorn@kernel.org> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Juerg Haefliger [Tue, 7 Feb 2023 10:08:17 +0000 (11:08 +0100)]
UBUNTU: [Packaging] annotations: Check validity of FLAVOUR_DEP
FLAVOUR_DEP is used to map flavors from the main annotations file to
flavors from includes. Currently, there is no check that any of the
listed flavors exists or is valid so the resulting behavior is
(probably) undefined/unexpected. Add a sanity check to verify the
FLAVOUR_DEP flavors.
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Juerg Haefliger [Tue, 7 Feb 2023 07:36:07 +0000 (08:36 +0100)]
UBUNTU: [Packaging] annotations: Write out annotations with notes first
When writing the annotations file, separate them into two groups: With
and without a note. Write the group with notes first and separate the
other group with a visual marker.
The idea is that all configs that are set/modified manually should have
an annotation note and putting them at the top of the annotations file
should make it easier to figure out what the config of this kernel is
about.
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Juerg Haefliger [Tue, 7 Feb 2023 07:36:06 +0000 (08:36 +0100)]
UBUNTU: [Packaging] annotations: Fail on invalid lines
Currently, invalid lines are silently ignored, which is not good.
Fix this by raising an exception if the line can't be parsed. While at
it, remove one level of nesting by using if-continue.
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Juerg Haefliger [Tue, 7 Feb 2023 07:36:05 +0000 (08:36 +0100)]
UBUNTU: [Packaging] annotations: Handle tabs in annotations file
Handle tabs in the annotations file by replacing them with spaces.
While at make the parsing more robust by removing leading and trailing
whitespaces and ignoring empty lines.
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Juerg Haefliger [Tue, 7 Feb 2023 07:36:04 +0000 (08:36 +0100)]
UBUNTU: [Packaging] annotations: Clean up policy writes
The logic to determine if policy lines need to be written to the output
file is a little convoluted. Basically, if there is no 'policy' key in
a config, there is nothing to do, so put that check at the beginning of
the loop.
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Fix the following flake8 errors:
- E127 continuation line over-indented for visual indent
- E722 do not use bare 'except'
- E203 whitespace before ':'
- E201 whitespace after '{'
- E202 whitespace before '}'
- E713 test for membership should be 'not in'
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Currently, rules with notes are written out as separate lines, i. e.,
one line for the policy and one line for the note, followed by an
empty line. The parser now supports single line rules so preserve that
style when writting out the rules.
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Andy Whitcroft [Fri, 3 Feb 2023 14:24:08 +0000 (14:24 +0000)]
UBUNTU: [Packaging] rsync no longer available on lunar
rsync is no longer available on i386. In lunar we only produce
linux-libc-dev from the kernel package on i386. We only use rsync when
building tools and when building documentation; we do neither on i386.
Architecture limit our dependency.
Signed-off-by: Andy Whitcroft <apw@canonical.com>
[changed subject Config->Packaging, and lucid->lunar in body] Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Francis Ginther [Thu, 2 Feb 2023 15:24:24 +0000 (09:24 -0600)]
UBUNTU: [Debian] Use a python3 compatable kernel-testing repo
BugLink: https://bugs.launchpad.net/bugs/2004429
Switch to using a python3 compatible branch for the kernel-testing
scripts used for running autopkgtest. This in turn uses a python3
compatible fork of autotest.
Remove the autopkgtest dependency on python2, replacing it with python3.
Also remove the dependency on bzr as it's unused.
Signed-off-by: Francis Ginther <francis.ginther@canonical.com> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
1> Driver Registers with Devlink framework.
2> Implements devlink ops flash_update callback that programs modem fw.
3> Creates region & snapshot required for device coredump log collection.
On early detection of wwan device in fastboot mode driver sets up CLDMA0 HW
tx/rx queues for raw data transfer and then registers to devlink framework.
On user space application issuing command for firmware update the driver
sends fastboot flash command & firmware to program NAND.
In flashing procedure the fastboot command & response are exchanged between
driver and device. Once firmware flashing is success completion status is
reported to user space application.
Below is the devlink command usage for firmware flashing
$devlink dev flash pci/$BDF file ABC.img component ABC
Note: ABC.img is the firmware to be programmed to "ABC" partition.
In case of coredump collection when wwan device encounters an exception
it reboots & stays in fastboot mode for coredump collection by host driver.
On detecting exception state driver collects the core dump, creates the
devlink region & reports an event to user space application for dump
collection. The user space application invokes devlink region read command
for dump collection.
Below are the devlink commands used for coredump collection.
devlink region new pci/$BDF/mr_dump
devlink region read pci/$BDF/mr_dump snapshot $ID address $ADD length $LEN
devlink region del pci/$BDF/mr_dump snapshot $ID
Change-Id: I36c87dc3b7433439716023a4841820093ece3cdc Signed-off-by: M Chetan Kumar <m.chetan.kumar@linux.intel.com> Signed-off-by: Devegowda Chandrashekar <chandrashekar.devegowda@intel.com> Signed-off-by: Mishra Soumya Prakash <soumya.prakash.mishra@intel.com>
(cherry picked from https://patchwork.kernel.org/project/netdevbpf/patch/20230105154300.198873-1-m.chetan.kumar@linux.intel.com/) Signed-off-by: You-Sheng Yang (vicamo) <vicamo.yang@canonical.com> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
M Chetan Kumar [Mon, 16 Jan 2023 09:15:02 +0000 (17:15 +0800)]
UBUNTU: SAUCE: net: wwan: t7xx: PCIe reset rescan
BugLink: https://bugs.launchpad.net/bugs/2002089
PCI rescan module implements "rescan work queue".
In firmware flashing or coredump collection procedure
WWAN device is programmed to boot in fastboot mode and
a work item is scheduled for removal & detection.
The WWAN device is reset using APCI call as part driver
removal flow. Work queue rescans pci bus at fixed interval
for device detection, later when device is detect work queue
exits.
Change-Id: I4bc254ae0eae76c41da75b1b76fcef36ec866e84 Signed-off-by: Haijun Liu <haijun.liu@mediatek.com> Co-developed-by: Madhusmita Sahu <madhusmita.sahu@intel.com> Signed-off-by: Madhusmita Sahu <madhusmita.sahu@intel.com> Signed-off-by: Ricardo Martinez <ricardo.martinez@linux.intel.com> Signed-off-by: M Chetan Kumar <m.chetan.kumar@linux.intel.com> Signed-off-by: Devegowda Chandrashekar <chandrashekar.devegowda@intel.com>
(cherry picked from https://patchwork.kernel.org/project/netdevbpf/patch/20230105154245.198858-1-m.chetan.kumar@linux.intel.com/) Signed-off-by: You-Sheng Yang (vicamo) <vicamo.yang@canonical.com> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
M Chetan Kumar [Mon, 16 Jan 2023 09:15:01 +0000 (17:15 +0800)]
UBUNTU: SAUCE: net: wwan: t7xx: Infrastructure for early port configuration
BugLink: https://bugs.launchpad.net/bugs/2002089
To support cases such as FW update or Core dump, the t7xx
device is capable of signaling the host that a special port
needs to be created before the handshake phase.
This patch adds the infrastructure required to create the
early ports which also requires a different configuration of
CLDMA queues.
Change-Id: Ib4b9d5c0328be89f0290706390ee0293530d7b70 Signed-off-by: Haijun Liu <haijun.liu@mediatek.com> Co-developed-by: Madhusmita Sahu <madhusmita.sahu@intel.com> Signed-off-by: Madhusmita Sahu <madhusmita.sahu@intel.com> Signed-off-by: Ricardo Martinez <ricardo.martinez@linux.intel.com> Signed-off-by: Devegowda Chandrashekar <chandrashekar.devegowda@intel.com> Signed-off-by: M Chetan Kumar <m.chetan.kumar@linux.intel.com>
(cherry picked from https://patchwork.kernel.org/project/netdevbpf/patch/20230105154229.198843-1-m.chetan.kumar@linux.intel.com/) Signed-off-by: You-Sheng Yang (vicamo) <vicamo.yang@canonical.com> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Haijun Liu [Mon, 16 Jan 2023 09:15:00 +0000 (17:15 +0800)]
UBUNTU: SAUCE: net: wwan: t7xx: Add AP CLDMA
BugLink: https://bugs.launchpad.net/bugs/2002089
The t7xx device contains two Cross Layer DMA (CLDMA) interfaces to
communicate with AP and Modem processors respectively. So far only
MD-CLDMA was being used, this patch enables AP-CLDMA.
Rename small Application Processor (sAP) to AP.
Change-Id: I37d4311f013ff19891ca3801ee048b08b27c4847 Signed-off-by: Haijun Liu <haijun.liu@mediatek.com> Co-developed-by: Madhusmita Sahu <madhusmita.sahu@intel.com> Signed-off-by: Madhusmita Sahu <madhusmita.sahu@intel.com> Signed-off-by: Moises Veleta <moises.veleta@linux.intel.com> Signed-off-by: Devegowda Chandrashekar <chandrashekar.devegowda@intel.com> Signed-off-by: M Chetan Kumar <m.chetan.kumar@linux.intel.com> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Reviewed-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>
(cherry picked from https://patchwork.kernel.org/project/netdevbpf/patch/20230105154215.198828-1-m.chetan.kumar@linux.intel.com/) Signed-off-by: You-Sheng Yang (vicamo) <vicamo.yang@canonical.com> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
UBUNTU: SAUCE: shiftfs: fix -EOVERFLOW inside the container
BugLink: https://bugs.launchpad.net/bugs/1990849
We haven't supported idmapped layers with shiftfs and moreover, that makes
no sense. Once lower fs support idmapped mounts when shiftfs is not needed.
Starting from linux-image-5.15.0-48-generic users started seeing EOVERFLOW
errors from the userspace side on a trivial fs operations inside the containers.
This is caused by patches ("fs: tweak fsuidgid_has_mapping()"),
("fs: support mapped mounts of mapped filesystems"). These patches extends
and enables idmapped mounts support in Ubuntu kernel, but the problem is
that shiftfs was not properly ported.
See also:
("namei: prepare for idmapped mounts")
https://lore.kernel.org/all/20210121131959.646623-15-christian.brauner@ubuntu.com/
("overlayfs: do not mount on top of idmapped mounts")
https://lore.kernel.org/all/20210121131959.646623-29-christian.brauner@ubuntu.com/
as a reference.
This patch should be appied on top of kinetic/master-next and based on the
changes by Andrea Righi 4c934edc66 ("UBUNTU: SAUCE: shiftfs: always rely on init_user_ns")
This commit together with 4c934edc66 ("UBUNTU: SAUCE: shiftfs: always rely on init_user_ns")
have to be ported to the jammy tree too.
Fixes: d347e71d2c0 ("UBUNTU: [SAUCE] shiftfs: support kernel 5.15") Reported-by: Thomas Parrott <thomas.parrott@canonical.com> Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com> Acked-by: Tim Gardner <tim.gardner@canonical.com> Acked-by: Andrea Righi <andrea.righi@canonical.com> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Andrea Righi [Tue, 31 Jan 2023 13:45:15 +0000 (14:45 +0100)]
UBUNTU: [Packaging] annotations: do not drop undefined configs in derivatives
Prevent dropping configs that are undefined across all the supported
architectures in annotations that have includes, because we may want to
use them to override configs imported from other annotations.
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Juerg Haefliger [Thu, 26 Jan 2023 10:58:35 +0000 (11:58 +0100)]
UBUNTU: [Packaging] debian/rules: 1-maintainer.mk -- Use make's if-else
Use make's built-in if-else conditional rather than the shell's so we
can drop multi-line shell statements and make the code more readable.
While at it, don't purge the 'build' directory at the end of the config
operations. That's a directory used internally by the kernelconfig script
which handles the cleanup.
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Juerg Haefliger [Tue, 24 Jan 2023 13:03:12 +0000 (14:03 +0100)]
UBUNTU: [Packaging] debian/rules: Bring back 'editconfigs'
With the switch to the new annotations-only mechanism and the new
annotations script, the 'editconfigs' target was dropped for some
reason. It's usefull so bring it back.
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
UBUNTU: [Packaging] Revoke and rotate to new signing key
BugLink: https://bugs.launchpad.net/bugs/2002812
Update revocations, which match the next Ubuntu shim v15.7
revocations. Specifically - revoke certs that were previously
protected with by-hash revocations, revoke lost/unused certificates.
Kernels with this patch applied should be signed using ubuntu/4 pro/3
core/2 signing streams.
TPM PCR values and measurements will change when changing the signing
key.
Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Andrea Righi [Thu, 19 Jan 2023 14:05:11 +0000 (15:05 +0100)]
UBUNTU: SAUCE: Revert "net/smc: Introduce a specific sysctl for TEST_LINK time"
BugLink: https://bugs.launchpad.net/bugs/2003547
This commit seems to cause network issues and IBM is not sure if we can
get a fix in time for the final 6.2, so let's revert this for now.
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Andrea Righi [Thu, 19 Jan 2023 14:03:51 +0000 (15:03 +0100)]
UBUNTU: SAUCE: Revert "net/smc: Unbind r/w buffer size from clcsock and make them tunable"
BugLink: https://bugs.launchpad.net/bugs/2003547
This commit seems to cause network issues and IBM is not sure if we can
get a fix in time for the final 6.2, so let's revert this for now.
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Juerg Haefliger [Wed, 18 Jan 2023 07:23:07 +0000 (08:23 +0100)]
UBUNTU: [Packaging] scripts/misc/kernelconfig: Disable config checks for mainline builds
For mainline builds, all checks need to be disabled since failures can't
be tolerated/handled. For that, do_skip_checks is set to 'true' but the
new kernelconfig script doesn't honor that. Fix it.
While at it, add a header comment listing all supported environment
variables.
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
The kernelconfig script evolved over a long time and accumulated quite
some cruft. With the switch to using annotations only, that got even
worse so it's time for a major overhaul. Rather than sending tons of
little patches, just rewrite the whole script and also ensure shellcheck
is happy.
No functional changes intended.
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Juerg Haefliger [Tue, 10 Jan 2023 16:25:53 +0000 (17:25 +0100)]
UBUNTU: [Packaging] debian/rules: Clean up 'printenv' target output
The output of the 'printenv' target is misaligned and somewhat in random
order. Fix the alignment and group the variables by 'type' and put the
flag variables at the end.
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Juerg Haefliger [Tue, 10 Jan 2023 16:02:52 +0000 (17:02 +0100)]
UBUNTU: [Packaging] debian/rules: Mark PHONY targets individually
Mark all PHONY targets individually in rules.d/1-maintainer.mk rather
than listing them on a single line. This makes it easier to spot missing
PHONY markers and also matches the other rules files.
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Build PPAs have a configuration option 'Build debug symbols'. Currently,
if we build in a PPA that has this option disabled, we still build
the debug packages but we remove them from debian/files so they don't
get published. That seems wrong, we shouldn't even build the packages.
The LP build system adds the option 'noautodgbsym' to the env variable
DEB_BUILD_OPTIONS in such a case [1]. Use that to disable debug package
builds.
While at it, clean up the mangling of debian/files and remove logic
that was added in 2010 to support future LP buildd features that never
materialized [2].
Juerg Haefliger [Thu, 12 Jan 2023 07:40:40 +0000 (08:40 +0100)]
UBUNTU: [Packaging] debian/rules: Rename 'full_build' to 'do_full_build'
Flag variables (that can take true/false values and drive different build
behaviors) are named 'do_<foo>'. Rename 'full_build' to follow that
convention.
While at it, clarify the comment.
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Juerg Haefliger [Wed, 11 Jan 2023 09:09:36 +0000 (10:09 +0100)]
UBUNTU: [Packaging] debian/rules: Rename 'skip_checks' to 'do_skip_checks'
Flag variables (that can take true/false values and drive different build
behaviors) are named 'do_<foo>'. Rename 'skip_checks' to follow that
convention.
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Juerg Haefliger [Mon, 9 Jan 2023 15:08:56 +0000 (16:08 +0100)]
UBUNTU: [Packaging] debian/rules: Rename 'skip_dbg' to 'do_dbgsym_package'
Rename the variable skipdbg' to 'do_dbgsym_package' to match the naming
convention of the 'do_<foo>' variables, since that is what it really does.
Obvioulsy inverse the logic.
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Add an optional 'skip_checks' argument to match the other checker scripts.
This is used for mainline builds to not fail a build even if the checker
script finds problems.
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Juerg Haefliger [Mon, 9 Jan 2023 14:21:49 +0000 (15:21 +0100)]
UBUNTU: [Packaging] debian/rules: Replace skip<foo> variables with skip_checks
There are different skip<foo> variables to disable individual ABI checks
but they're all set together and only for mainline builds so replace them
with the single variable skip_checks.
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Juerg Haefliger [Mon, 9 Jan 2023 13:59:07 +0000 (14:59 +0100)]
UBUNTU: [Packaging] debian/rules: Drop NOKERNLOG and PRINTSHAS env variables
The env variables NOKERNLOG and PRINTSHAS were introduced in 2007 for
some special case and to retain old behavior when generating the
changelog. That hasn't been used in ages and git-ubuntu-log doesn't
even support it anymore since 2016 so drop it all.
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Masahiro Yamada [Wed, 11 Jan 2023 00:08:36 +0000 (09:08 +0900)]
UBUNTU: SAUCE: (no-up) do not remove debian directory by 'make mrproper'
If you use only remote build servers such as launchpad, cbd, etc.
you may not care about this, but if you run 'make mrproper', the
debian directory is entirely removed because it is a generated
directory for the upstream kernel.
I do not want to lose the debian directory by accident when I am
debugging something on my local machine.
Signed-off-by: Masahiro Yamada <masahiro.yamada@canonical.com> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Masahiro Yamada [Thu, 12 Jan 2023 13:47:27 +0000 (22:47 +0900)]
UBUNTU: [Packaging] Fix module-check error when modules are compressed
Some parts in the packaging scripts are written based on the assumption
that module file names always end with the .ko suffix.
The module suffix might be .ko.gz, .ko.xz, or .ko.zst if module
compression is enabled.
If CONFIG_MODULE_COMPRESS_GZIP/XZ/ZSTD is enabled, the module-check
fails with a lot of "MISS" because currently only files with *.ko
suffix are picked up.
Ubuntu kernels do not enable module compression by default, but users
may tweak CONFIG options when they build their custom kernel.
Modules are compressed in some distributions, for example in Fedora,
modules are *.ko.xz.
Signed-off-by: Masahiro Yamada <masahiro.yamada@canonical.com> Ack-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Andrea Righi [Thu, 12 Jan 2023 16:07:09 +0000 (17:07 +0100)]
UBUNTU: [Config] enable EFI handover protocol
GRUB may include some downstream patches that may rely on the handover
protocol, so enable it to make sure that everything is still bootable
using GRUB with EFI.
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Andrea Righi [Tue, 3 Jan 2023 09:12:44 +0000 (10:12 +0100)]
UBUNTU: [Packaging] annotations: remove configs that are undefined across all arches/flavours
Sometimes certain config options are removed in new kernels, so when
annotations is updated these options result to be undefined across all
architectures and flavours, in this case it's much more clean to simply
drop them from annotations (considering that the kernel doesn't support
them anymore).
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
It is not very easy to access them, one needs to either download linux
kernel package source code; or boot the kernel to look up builtin hashes;
and then find certificates externally.
It would be more convenient for inspection to expose these in the
buildinfo package, which already exposes auxiliary kernel information.
Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com> Acked-by: Cory Todd <cory.todd@canonical.com> Acked-by: Tim Gardner <tim.gardner@canonical.com> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>