]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
sched/topology: fix KASAN warning in hop_cmp()
authorYury Norov <yury.norov@gmail.com>
Fri, 17 Feb 2023 01:39:08 +0000 (17:39 -0800)
committerJakub Kicinski <kuba@kernel.org>
Mon, 20 Feb 2023 19:45:33 +0000 (11:45 -0800)
commit01bb11ad828b320749764fa93ad078db20d08a9e
tree7c85bb1f6473ba62607a6a37b1d75f1660d6620a
parent3fcdf2dfefb6313ea0395519d1784808c0b6559b
sched/topology: fix KASAN warning in hop_cmp()

Despite that prev_hop is used conditionally on cur_hop
is not the first hop, it's initialized unconditionally.

Because initialization implies dereferencing, it might happen
that the code dereferences uninitialized memory, which has been
spotted by KASAN. Fix it by reorganizing hop_cmp() logic.

Reported-by: Bruno Goncalves <bgoncalv@redhat.com>
Fixes: cd7f55359c90 ("sched: add sched_numa_find_nth_cpu()")
Signed-off-by: Yury Norov <yury.norov@gmail.com>
Link: https://lore.kernel.org/r/Y+7avK6V9SyAWsXi@yury-laptop/
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
kernel/sched/topology.c