]> git.proxmox.com Git - mirror_qemu.git/commit
qapi: Fix generated code when flat union has member 'kind'
authorMarkus Armbruster <armbru@redhat.com>
Fri, 31 Jul 2015 08:30:04 +0000 (10:30 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Fri, 4 Sep 2015 13:47:13 +0000 (15:47 +0200)
commit0f61af3eb396ae163cd1572ce12e05f5d08d7c15
tree6bf37b6d51adf1446d7cd4f1f22beb061e380f5a
parent5aa05d3f72e556752167f7005d6a3dea0f4432c5
qapi: Fix generated code when flat union has member 'kind'

A flat union's tag member gets renamed to 'kind' in the generated
code.  Breaks when another member named 'kind' exists.

Example, adapted from qapi-schema-test.json:

    { 'struct': 'UserDefUnionBase',
      'data': { 'kind': 'str', 'enum1': 'EnumOne' } }

We generate:

    struct UserDefFlatUnion
    {
        EnumOne kind;
        union {
            void *data;
            UserDefA *value1;
            UserDefB *value2;
            UserDefB *value3;
        };
        char *kind;
    };

Kill the silly rename.

Reported-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
scripts/qapi-types.py
scripts/qapi-visit.py
tests/test-qmp-input-visitor.c
tests/test-qmp-output-visitor.c