]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
ice: fix receive buffer size miscalculation
authorJesse Brandeburg <jesse.brandeburg@intel.com>
Thu, 10 Aug 2023 23:51:10 +0000 (16:51 -0700)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Mon, 21 Aug 2023 16:19:47 +0000 (09:19 -0700)
commit10083aef784031fa9f06c19a1b182e6fad5338d9
treed1110467196b133b22f20a4799ac501fa8b0126c
parentd1cdbf66e18cd39dd749937221240ab97c06d9e6
ice: fix receive buffer size miscalculation

The driver is misconfiguring the hardware for some values of MTU such that
it could use multiple descriptors to receive a packet when it could have
simply used one.

Change the driver to use a round-up instead of the result of a shift, as
the shift can truncate the lower bits of the size, and result in the
problem noted above. It also aligns this driver with similar code in i40e.

The insidiousness of this problem is that everything works with the wrong
size, it's just not working as well as it could, as some MTU sizes end up
using two or more descriptors, and there is no way to tell that is
happening without looking at ice_trace or a bus analyzer.

Fixes: efc2214b6047 ("ice: Add support for XDP")
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice_base.c