]> git.proxmox.com Git - mirror_ovs.git/commit
ovsdb-idl: Return correct seqno from ovsdb_idl_db_set_condition().
authorDumitru Ceara <dceara@redhat.com>
Tue, 10 Nov 2020 14:34:28 +0000 (15:34 +0100)
committerIlya Maximets <i.maximets@ovn.org>
Mon, 16 Nov 2020 16:47:12 +0000 (17:47 +0100)
commit17f22fe46142ef0402bff0e3eb9a4768d93b8008
tree9cfa3a2dfd28d824be309858dc2db0840e69ba4a
parent12eb2f67df055faab7603b987c9f3c044cc199a8
ovsdb-idl: Return correct seqno from ovsdb_idl_db_set_condition().

If an IDL client sets the same monitor condition twice, the expected
seqno when the IDL contents are updated should be the same for both
calls.

In the following scenario:
1. Client calls ovsdb_idl_db_set_condition(db, table, cond1)
2. ovsdb_idl sends monitor_cond_change(cond1) but the server doesn't yet
   reply.
3. Client calls ovsdb_idl_db_set_condition(db, table, cond1)

At step 3 the returned expected seqno should be the same as at step 1.
Similarly, if step 2 is skipped, i.e., the client calls sets
the condition twice in the same iteration, then both
ovsdb_idl_db_set_condition() calls should return the same value.

Fixes: 46437c5232bd ("ovsdb-idl: Enhance conditional monitoring API")
Signed-off-by: Dumitru Ceara <dceara@redhat.com>
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
lib/ovsdb-idl.c
tests/test-ovsdb.c