]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
tun: don't hold network namespace by tun sockets
authorStanislav Kinsbursky <skinsbursky@parallels.com>
Mon, 12 Mar 2012 02:59:41 +0000 (02:59 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 13 Mar 2012 00:14:00 +0000 (17:14 -0700)
commit1ab5ecb90cb6a3df1476e052f76a6e8f6511cb3d
treef808476bf94d8f4191b1a753a38d7d168ddfec51
parentde5c37414af10ac9305d4a3e9c1468347ca3ccaa
tun: don't hold network namespace by tun sockets

v3: added previously removed sock_put() to the tun_release() callback, because
sk_release_kernel() doesn't drop the socket reference.

v2: sk_release_kernel() used for socket release. Dummy tun_release() is
required for sk_release_kernel() ---> sock_release() ---> sock->ops->release()
call.

TUN was designed to destroy it's socket on network namesapce shutdown. But this
will never happen for persistent device, because it's socket holds network
namespace.
This patch removes of holding network namespace by TUN socket and replaces it
by creating socket in init_net and then changing it's net it to desired one. On
shutdown socket is moved back to init_net prior to final put.

Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/tun.c