]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
drm/i915/gem: Flush contexts on driver release
authorJanusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Fri, 16 Sep 2022 09:24:02 +0000 (11:24 +0200)
committerAndi Shyti <andi.shyti@linux.intel.com>
Mon, 19 Sep 2022 15:56:43 +0000 (17:56 +0200)
commit1cec34442408a77ba5396b19725fed2c398005c3
treea9134af3e939407a47e787151e89421324f76ae9
parent14f2f9bf34b180aa90b2088836f5153cb56db95e
drm/i915/gem: Flush contexts on driver release

Due to i915_perf assuming that it can use the i915_gem_context reference
to protect its i915->gem.contexts.list iteration, we need to defer removal
of the context from the list until last reference to the context is put.
However, there is a risk of triggering kernel warning on contexts list not
empty at driver release time if we deleagate that task to a worker for
i915_gem_context_release_work(), unless that work is flushed first.
Unfortunately, it is not flushed on driver release.  Fix it.

Instead of additionally calling flush_workqueue(), either directly or via
a new dedicated wrapper around it, replace last call to
i915_gem_drain_freed_objects() with existing i915_gem_drain_workqueue()
that performs both tasks.

Fixes: 75eefd82581f ("drm/i915: Release i915_gem_context from a worker")
Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Cc: stable@kernel.org # v5.16+
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220916092403.201355-2-janusz.krzysztofik@linux.intel.com
drivers/gpu/drm/i915/i915_gem.c