]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
serial: sh-sci: Fix race condition causing garbage during shutdown
authorGeert Uytterhoeven <geert+renesas@glider.be>
Tue, 25 Apr 2017 18:15:35 +0000 (20:15 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 May 2017 14:19:16 +0000 (16:19 +0200)
commit1cf4a7efdc71cab84c42cfea7200608711ea954f
treea58abd69389f1903d054b1a1adedb5b9202a008a
parent7fbcf3afe6e8e180bfc39fb3f41657fa6e4af55c
serial: sh-sci: Fix race condition causing garbage during shutdown

If DMA is enabled and used, a burst of old data may be seen on the
serial console during "poweroff" or "reboot".  uart_flush_buffer()
clears the circular buffer, but sci_port.tx_dma_len is not reset.
This leads to a circular buffer overflow, dumping (UART_XMIT_SIZE -
sci_port.tx_dma_len) bytes.

To fix this, add a .flush_buffer() callback that resets
sci_port.tx_dma_len.

Inspired by commit 31ca2c63fdc0aee7 ("tty/serial: atmel: fix race
condition (TX+DMA)").

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/sh-sci.c