]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
ftrace: Fix issue that 'direct->addr' not restored in modify_ftrace_direct()
authorZheng Yejian <zhengyejian1@huawei.com>
Thu, 30 Mar 2023 02:52:23 +0000 (10:52 +0800)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Thu, 6 Apr 2023 15:01:30 +0000 (11:01 -0400)
commit2a2d8c51defb446e8d89a83f42f8e5cd529111e9
tree9750c35d6baae76250e6a435b3e27fa844c3bb83
parent3357c6e429643231e60447b52ffbb7ac895aca22
ftrace: Fix issue that 'direct->addr' not restored in modify_ftrace_direct()

Syzkaller report a WARNING: "WARN_ON(!direct)" in modify_ftrace_direct().

Root cause is 'direct->addr' was changed from 'old_addr' to 'new_addr' but
not restored if error happened on calling ftrace_modify_direct_caller().
Then it can no longer find 'direct' by that 'old_addr'.

To fix it, restore 'direct->addr' to 'old_addr' explicitly in error path.

Link: https://lore.kernel.org/linux-trace-kernel/20230330025223.1046087-1-zhengyejian1@huawei.com
Cc: stable@vger.kernel.org
Cc: <mhiramat@kernel.org>
Cc: <mark.rutland@arm.com>
Cc: <ast@kernel.org>
Cc: <daniel@iogearbox.net>
Fixes: 8a141dd7f706 ("ftrace: Fix modify_ftrace_direct.")
Signed-off-by: Zheng Yejian <zhengyejian1@huawei.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/ftrace.c