]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
tty: don't crash in tty_init_dev when missing tty_port
authorJiri Slaby <jslaby@suse.cz>
Fri, 22 Nov 2019 10:17:21 +0000 (11:17 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 22 Nov 2019 10:38:38 +0000 (11:38 +0100)
commit2ae0b31e0faced43c011ce3221f2535721cb6a66
treeb6431e759d83ae24f77130c75cfe27f8844f2bed
parent1250ed7114a977cdc2a67a0c09d6cdda63970eb9
tty: don't crash in tty_init_dev when missing tty_port

We currently warn the user when tty->port is not set in tty_init_dev
yet. The warning says that the kernel will crash later. And it really
will only few lines below at:
tty->port->itty = tty;

So be nice and avoid the crash -- return an error instead. And update
the warning.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Link: https://lore.kernel.org/r/20191122101721.7222-1-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/tty_io.c