]> git.proxmox.com Git - mirror_frr.git/commit
bgpd: Fix route install upon non-best nexthop change
authorvivek <vivek@cumulusnetworks.com>
Mon, 5 Sep 2016 17:35:19 +0000 (10:35 -0700)
committervivek <vivek@cumulusnetworks.com>
Mon, 5 Sep 2016 17:35:19 +0000 (10:35 -0700)
commit3064bf43a7d8162dadada2934132f915a45d2bcb
tree2a13a6e40a5baed503681878ba6877c692e28239
parent7f80b49ae060867542506503da79023dadca5830
bgpd: Fix route install upon non-best nexthop change

After BGP path selection, even if the best route entry selected has not
changed, ensure that the route is installed again in zebra if any non-best
but multipath route entry has a nexthop resolution change.

In the absence of this fix, if a non-best multipath route entry had a
nexthop resolution change (such as being resolved over two first hops instead
of one), the route would get reinstalled into zebra only in some situations
(i.e., when the best route entry had its IGP change flag set). If the route
does not get reinstalled by BGP, the corresponding route in the zebra RIB
would not have all the first hops.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>
Reviewed-by: Donald Sharp <sharpd@cumulusnetworks.com>
Reviewed-by: Daniel Walton <dwalton@cumulusnetworks.com>
Reviewed-by: Sid Khot <sidkhot@cumulusnetworks.com>
Ticket: CM-12390
Reviewed By: CCR-5134
Testing Done: Manual, bgp-smoke
bgpd/bgp_nht.c
bgpd/bgp_route.c