]> git.proxmox.com Git - mirror_qemu.git/commit
block: Deprecate bdrv_set_read_only() and users
authorKevin Wolf <kwolf@redhat.com>
Tue, 7 Nov 2017 17:21:41 +0000 (18:21 +0100)
committerKevin Wolf <kwolf@redhat.com>
Fri, 17 Nov 2017 12:35:59 +0000 (13:35 +0100)
commit398e6ad014df261d20d3fd6cff2cfbf940bac714
tree32ab30963ddfd86a2e4bb9199c393c6a466e00f3
parentf66afbe26f0c093d639610d70d16d7cc3183b652
block: Deprecate bdrv_set_read_only() and users

bdrv_set_read_only() is used by some block drivers to override the
read-only option given by the user. This is not how read-only images
generally work in QEMU: Instead of second guessing what the user really
meant (which currently includes making an image read-only even if the
user didn't only use the default, but explicitly said read-only=off), we
should error out if we can't provide what the user requested.

This adds deprecation warnings to all callers of bdrv_set_read_only() so
that the behaviour can be corrected after the usual deprecation period.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block.c
block/bochs.c
block/cloop.c
block/dmg.c
block/rbd.c
block/vvfat.c
qapi/block-core.json