]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
vdpa: check that offsets are within bounds
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 8 Dec 2021 10:33:37 +0000 (13:33 +0300)
committerMichael S. Tsirkin <mst@redhat.com>
Wed, 8 Dec 2021 19:53:15 +0000 (14:53 -0500)
commit3ed21c1451a14d139e1ceb18f2fa70865ce3195a
treeeeb29cc356febfbbd40ed9cd4f888eb5d6181b06
parentff9f9c6e74848170fcb45c8403c80d661484c8c9
vdpa: check that offsets are within bounds

In this function "c->off" is a u32 and "size" is a long.  On 64bit systems
if "c->off" is greater than "size" then "size - c->off" is a negative and
we always return -E2BIG.  But on 32bit systems the subtraction is type
promoted to a high positive u32 value and basically any "c->len" is
accepted.

Fixes: 4c8cf31885f6 ("vhost: introduce vDPA-based backend")
Reported-by: Xie Yongji <xieyongji@bytedance.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20211208103337.GA4047@kili
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Cc: stable@vger.kernel.org
drivers/vhost/vdpa.c