]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
phy: rockchip-typec: fix tcphy_get_mode error case
authorNeill Kapron <nkapron@google.com>
Thu, 26 Jan 2023 00:10:12 +0000 (00:10 +0000)
committerVinod Koul <vkoul@kernel.org>
Tue, 14 Feb 2023 13:55:28 +0000 (19:25 +0530)
commit4ca651df07183e29cdad7272255e23aec0169a1b
tree77f2b422a5b4fa6b74c7cc057b2cf76adf71b0e3
parent037d05af382e2915f0a9d028019152b4e2a23ec3
phy: rockchip-typec: fix tcphy_get_mode error case

The existing logic in tcphy_get_mode() can cause the phy to be
incorrectly configured to USB UFP or DisplayPort mode when
extcon_get_state returns an error code.

extcon_get_state() can return 0, 1, or a negative error code.

It is possible to get into the failing state with an extcon driver
which does not support the extcon connector id specified as the
second argument to extcon_get_state().

tcphy_get_mode()
->extcon_get_state()
-->find_cable_index_by_id()
--->return -EINVAL;

Fixes: e96be45cb84e ("phy: Add USB Type-C PHY driver for rk3399")
Signed-off-by: Neill Kapron <nkapron@google.com>
Reviewed-by: Lee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20230126001013.3707873-1-nkapron@google.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/rockchip/phy-rockchip-typec.c