]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
drm/vmwgfx: Revert "drm/vmwgfx: Replace numeric parameter like 0444 with macro"
authorØyvind A. Holm <sunny@sunbase.org>
Thu, 23 Mar 2017 21:54:48 +0000 (14:54 -0700)
committerSinclair Yeh <syeh@vmware.com>
Fri, 31 Mar 2017 22:21:16 +0000 (15:21 -0700)
commit50f837371dd9aea5470c06d5d10bc9ca3e8155b6
tree937cb3ea932dbd4b0be07c57f1c486f09d742f76
parente9cebe837be720af5972959d2ea295ece3be3721
drm/vmwgfx: Revert "drm/vmwgfx: Replace numeric parameter like 0444 with macro"

This reverts commit 2d8e60e8b074 ("drm/vmwgfx: Replace numeric
parameter like 0444 with macro")

The commit belongs to the series of 1285 patches sent to LKML on
2016-08-02, it changes the representation of file permissions from the
octal value "0600" to "S_IRUSR | S_IWUSR".

The general consensus was that the changes does not increase
readability, quite the opposite; 0600 is easier to parse mentally than
S_IRUSR | S_IWUSR.

It also causes argument inconsistency, due to commit 04319d89fbec
("drm/vmwgfx: Add an option to change assumed FB bpp") that added
another call to module_param_named() where the permissions are written
as 0600.

Signed-off-by: Øyvind A. Holm <sunny@sunbase.org>
Reviewed-by: Sinclair Yeh <syeh@vmware.com>
drivers/gpu/drm/vmwgfx/vmwgfx_drv.c