]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
clk: x86: Stop marking clocks as CLK_IS_CRITICAL
authorHans de Goede <hdegoede@redhat.com>
Wed, 12 Sep 2018 09:34:56 +0000 (11:34 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 18 Sep 2018 01:47:58 +0000 (18:47 -0700)
commit648e921888ad96ea3dc922739e96716ad3225d7f
tree265778341e820a569f935aa6e9dec41c02bdd177
parentc2f6f3ee7f22521fabc3295f51149bc3f4dd9202
clk: x86: Stop marking clocks as CLK_IS_CRITICAL

Commit d31fd43c0f9a ("clk: x86: Do not gate clocks enabled by the
firmware"), which added the code to mark clocks as CLK_IS_CRITICAL, causes
all unclaimed PMC clocks on Cherry Trail devices to be on all the time,
resulting on the device not being able to reach S0i3 when suspended.

The reason for this commit is that on some Bay Trail / Cherry Trail devices
the r8169 ethernet controller uses pmc_plt_clk_4. Now that the clk-pmc-atom
driver exports an "ether_clk" alias for pmc_plt_clk_4 and the r8169 driver
has been modified to get and enable this clock (if present) the marking of
the clocks as CLK_IS_CRITICAL is no longer necessary.

This commit removes the CLK_IS_CRITICAL marking, fixing Cherry Trail
devices not being able to reach S0i3 greatly decreasing their battery
drain when suspended.

Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=193891#c102
Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=196861
Cc: Johannes Stezenbach <js@sig21.net>
Cc: Carlo Caione <carlo@endlessm.com>
Reported-by: Johannes Stezenbach <js@sig21.net>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/clk/x86/clk-pmc-atom.c