]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
perf annotate: Fix a bug following symbolic link of a build-id file
authorTaeung Song <treeze.taeung@gmail.com>
Mon, 27 Mar 2017 07:10:36 +0000 (16:10 +0900)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 27 Mar 2017 17:58:20 +0000 (14:58 -0300)
commit6ebd2547dd24daf95a21b2bc59931de8502afcc3
treee98731e942523a48a48b7220481a2826466eb009
parent5dfa210e407d0fedf746958bff206995bd46570d
perf annotate: Fix a bug following symbolic link of a build-id file

It is wrong way to read link name from a build-id file.  Because a
build-id file is not anymore a symbolic link but build-id directory of
it is symbolic link, so fix it.

For example, if build-id file name gotten from
dso__build_id_filename() is as below,

  /root/.debug/.build-id/4f/75c7d197c951659d1c1b8b5fd49bcdf8f3f8b1/elf

To correctly read link name of build-id, use the build-id dir path that
is a symbolic link, instead of the above build-id file name like below.

  /root/.debug/.build-id/4f/75c7d197c951659d1c1b8b5fd49bcdf8f3f8b1

Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1490598638-13947-2-git-send-email-treeze.taeung@gmail.com
Fixes: 01412261d994 ("perf buildid-cache: Use path/to/bin/buildid/elf instead of path/to/bin/buildid")
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/annotate.c