]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
procfs: Use generic_file_llseek in /proc/vmcore
authorFrederic Weisbecker <fweisbec@gmail.com>
Tue, 30 Mar 2010 00:33:36 +0000 (02:33 +0200)
committerFrederic Weisbecker <fweisbec@gmail.com>
Fri, 9 Apr 2010 15:23:24 +0000 (17:23 +0200)
commit73296bc611cee009f3be6b451e827d1425b9c10f
tree553af58153a05e6a6cc43d4dbcf5acdf6fc3f4c8
parent41775e29a74ed825496c975ba19c7661e15f0523
procfs: Use generic_file_llseek in /proc/vmcore

/proc/vmcore has no llseek and then falls down to use default_llseek.
This is racy against read_vmcore() that directly manipulates fpos
but it doesn't hold the bkl there so using it in llseek doesn't
protect anything.

Let's use generic_file_llseek() instead.

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: John Kacur <jkacur@redhat.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Al Viro <viro@ZenIV.linux.org.uk>
fs/proc/vmcore.c