]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
staging: axis-fifo: initialize timeouts in init only
authorKhadija Kamran <kamrankhadijadj@gmail.com>
Thu, 16 Mar 2023 20:09:00 +0000 (01:09 +0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 Mar 2023 07:13:41 +0000 (08:13 +0100)
commit752cbd8f191678e86aa754f795546b7f06b7f171
treec98519d013283b1943238310c2d1dae0542de672
parent5001d664e328b4a07e2377f09d7a6871ce12bc01
staging: axis-fifo: initialize timeouts in init only

Initialize the module parameters, read_timeout and write_timeout once in
init().

Module parameters can only be set once and cannot be modified later, so we
don't need to evaluate them again when passing the parameters to
wait_event_interruptible_timeout().

Convert datatype of {read,write}_timeout from 'int' to 'long int' because
implicit conversion of 'long int' to 'int' in statement
'{read,write}_timeout = MAX_SCHEDULE_TIMEOUT' results in an overflow.

Change format specifier for {read,write}_timeout from %i to %li.

Reviewed-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
Link: https://lore.kernel.org/r/ZBN3XAsItCiTk7CV@khadija-virtual-machine
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/axis-fifo/axis-fifo.c