]> git.proxmox.com Git - mirror_qemu.git/commit
watchdog/wdt_diag288: Mark diag288 watchdog as non-hotpluggable
authorThomas Huth <thuth@redhat.com>
Wed, 16 Aug 2017 14:08:48 +0000 (16:08 +0200)
committerCornelia Huck <cohuck@redhat.com>
Wed, 30 Aug 2017 16:23:25 +0000 (18:23 +0200)
commit84ebd3e8c7d4fe955b359b9aac84395907b0412e
treefc18e8870f02079892e88462b88b3129df5364c1
parenta8aec856b8e708d8346c60a17f72fc774fd41af5
watchdog/wdt_diag288: Mark diag288 watchdog as non-hotpluggable

QEMU currently aborts when the user tries to hot-unplug a diag288
device:

$ qemu-system-s390x -nographic -nodefaults -S -monitor stdio
QEMU 2.9.92 monitor - type 'help' for more information
(qemu) device_add diag288,id=x
(qemu) device_del x
**
ERROR:qemu/qdev-monitor.c:872:qdev_unplug: assertion failed: (hotplug_ctrl)
Aborted (core dumped)

The device is not designed as hot-pluggable (it should only be used
via the "-watchdog" parameter), so let's simply remove the possibility
to hotplug it to prevent that users can run into this ugly situation.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <1502892528-22618-1-git-send-email-thuth@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
hw/watchdog/wdt_diag288.c