]> git.proxmox.com Git - mirror_qemu.git/commit
pc-bios/s390-ccw: Fix problem with invalid virtio-scsi LUN when rebooting
authorThomas Huth <thuth@redhat.com>
Fri, 17 Nov 2017 18:10:28 +0000 (19:10 +0100)
committerCornelia Huck <cohuck@redhat.com>
Mon, 20 Nov 2017 09:35:12 +0000 (10:35 +0100)
commit8775d91a0f42d016833330881bb587982db88a3c
treeb2db6dc9ca0d5e9d2cea4d4df2ad14118923d45e
parent7337c6eb98786372cdbfe7ebe7affbd166fdc7ca
pc-bios/s390-ccw: Fix problem with invalid virtio-scsi LUN when rebooting

When rebooting a guest that has a virtio-scsi disk, the s390-ccw
bios sometimes bails out with an error message like this:

! SCSI cannot report LUNs: STATUS=02 RSPN=70 KEY=05 CODE=25 QLFR=00, sure !

Enabling the scsi_req* tracing in QEMU shows that the ccw bios is
trying to execute the REPORT LUNS SCSI command with a LUN != 0, and
this causes the SCSI command to fail.
Looks like we neither clear the BSS of the s390-ccw bios during reboot,
nor do we explicitly set the default_scsi_device.lun value to 0, so
this variable can contain random values from the OS after the reboot.
By setting this variable explicitly to 0, the problem is fixed and
the reboots always succeed.

Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1514352
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <1510942228-22822-1-git-send-email-thuth@redhat.com>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
pc-bios/s390-ccw/virtio-scsi.c