]> git.proxmox.com Git - qemu.git/commit
monitor: remove unused do_info_trace
authorHarsh Prateek Bora <harsh@linux.vnet.ibm.com>
Wed, 18 Jul 2012 09:45:58 +0000 (15:15 +0530)
committerStefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Thu, 19 Jul 2012 10:34:32 +0000 (11:34 +0100)
commit88affa1c77c9019f3450f851495997897bd14e40
treecca448b2547745eefd9cc074be354afbf4ae5135
parent794b1f962eb3b1ceb6bbb98dd7a57f62fc0fbc11
monitor: remove unused do_info_trace

Going forward with simpletrace v2 variable size trace records, we cannot
have a generic function to print trace event info and therefore this
interface becomes invalid.

As per Stefan Hajnoczi:

"This command is only available from the human monitor.  It's not very
useful because it historically hasn't been able to pretty-print events
or show them in the right order (we use a ringbuffer but it prints
them out from index 0).

Therefore, I don't think we're under any obligation to keep this
command around.  No one has complained about it's limitations - I
think this is a sign that no one has used it.  I'd be okay with a
patch that removes it."

Ref: http://lists.gnu.org/archive/html/qemu-devel/2012-01/msg01268.html

Signed-off-by: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
monitor.c
trace/simple.c
trace/simple.h