]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
ice, xsk: clear the status bits for the next_to_use descriptor
authorBjörn Töpel <bjorn.topel@intel.com>
Fri, 11 Dec 2020 14:57:11 +0000 (15:57 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 16 Dec 2020 18:51:07 +0000 (10:51 -0800)
commit8d14768a7972b92c73259f0c9c45b969d85e3a60
tree985987f2bc492ff8007fe5f324d283c162412d98
parent57030a0b620f735bf557696e5ceb9f32c2b3bb8f
ice, xsk: clear the status bits for the next_to_use descriptor

On the Rx side, the next_to_use index points to the next item in the
HW ring to be refilled/allocated, and next_to_clean points to the next
item to potentially be processed.

When the HW Rx ring is fully refilled, i.e. no packets has been
processed, the next_to_use will be next_to_clean - 1. When the ring is
fully processed next_to_clean will be equal to next_to_use. The latter
case is where a bug is triggered.

If the next_to_use bits are not cleared, and the "fully processed"
state is entered, a stale descriptor can be processed.

The skb-path correctly clear the status bit for the next_to_use
descriptor, but the AF_XDP zero-copy path did not do that.

This change adds the status bits clearing of the next_to_use
descriptor.

Fixes: 2d4238f55697 ("ice: Add support for AF_XDP")
Signed-off-by: Björn Töpel <bjorn.topel@intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/intel/ice/ice_xsk.c