]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
bus: mhi: ep: Move chan->lock to the start of processing queued ch ring
authorManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Wed, 28 Dec 2022 16:17:03 +0000 (21:47 +0530)
committerManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Fri, 27 Jan 2023 07:01:41 +0000 (12:31 +0530)
commit8d6a1fea53864cd9545741f48f4ae4df804db557
treee36173baceb98fc988c908ae4e99121fc5c3e8b3
parent8e697fcfdb9809634e268058ca743369c216b7ac
bus: mhi: ep: Move chan->lock to the start of processing queued ch ring

There is a good chance that while the channel ring gets processed, the STOP
or RESET command for the channel might be received from the MHI host. In
those cases, the entire channel ring processing needs to be protected by
chan->lock to prevent the race where the corresponding channel ring might
be reset.

While at it, let's also add a sanity check to make sure that the ring is
started before processing it. Because, if the STOP/RESET command gets
processed while mhi_ep_ch_ring_worker() waited for chan->lock, the ring
would've been reset.

Cc: <stable@vger.kernel.org> # 5.19
Fixes: 03c0bb8ec983 ("bus: mhi: ep: Add support for processing channel rings")
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Link: https://lore.kernel.org/r/20221228161704.255268-6-manivannan.sadhasivam@linaro.org
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
drivers/bus/mhi/ep/main.c