]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
numa: fix NULL pointer access and memory leak in unregister_one_node()
authorXishi Qiu <qiuxishi@huawei.com>
Thu, 6 Mar 2014 09:18:21 +0000 (17:18 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 9 Mar 2014 06:08:29 +0000 (22:08 -0800)
commit92d585ef067da7a966d6ce78c601bd1562b62619
treec839bfcc6efa0bf6f9d7c485ecb630c5fa130f59
parentaa0689b36b2144e91d2182605bed951565c4899b
numa: fix NULL pointer access and memory leak in unregister_one_node()

When doing socket hot remove, "node_devices[nid]" is set to NULL;
acpi_processor_remove()
try_offline_node()
unregister_one_node()

Then hot add a socket, but do not echo 1 > /sys/devices/system/cpu/cpuXX/online,
so register_one_node() will not be called, and "node_devices[nid]"
is still NULL.

If doing socket hot remove again, NULL pointer access will be happen.
unregister_one_node()
unregister_node()

Another, we should free the memory used by "node_devices[nid]" in
unregister_one_node().

Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/node.c