]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
rtc: ep93xx: Initialize drvdata before registering device
authorWolfram Sang <w.sang@pengutronix.de>
Thu, 5 May 2011 09:46:15 +0000 (11:46 +0200)
committerJohn Stultz <john.stultz@linaro.org>
Sat, 7 May 2011 00:42:04 +0000 (17:42 -0700)
commit92d921c5def1a7b1411bc54859c0771b2cf2c08d
tree780e72c2c1117013be350e7c788af27070c19bca
parentf4e708ae8e5f3eb98f4c53036c0a470717bbc709
rtc: ep93xx: Initialize drvdata before registering device

Commit f44f7f96a20 ("RTC: Initialize kernel state from RTC") uncovered
an issue in a number of RTC drivers, where the drivers call
rtc_device_register before initializing the device or platform drvdata.

This frequently results in null pointer dereferences when the
rtc_device_register immediately makes use of the rtc device, calling
rtc_read_alarm.

The solution is to ensure the drvdata is initialized prior to registering
the rtc device.

CC: Alessandro Zummo <a.zummo@towertech.it>
CC: Thomas Gleixner <tglx@linutronix.de>
CC: rtc-linux@googlegroups.com
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
[Fixed up commit log -jstultz]
Signed-off-by: John Stultz <john.stultz@linaro.org>
drivers/rtc/rtc-ep93xx.c