]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net: ipa: disable ipa interrupt during suspend
authorCaleb Connolly <caleb.connolly@linaro.org>
Sun, 15 Jan 2023 17:59:24 +0000 (17:59 +0000)
committerJakub Kicinski <kuba@kernel.org>
Wed, 18 Jan 2023 03:04:13 +0000 (19:04 -0800)
commit9ec9b2a30853ba843b70ea16f196e5fe3327be5f
tree926e438cc748fba2b3ffba10fe6581f0306be8fa
parent1f3bd64ad921f051254591fbed04fd30b306cde6
net: ipa: disable ipa interrupt during suspend

The IPA interrupt can fire when pm_runtime is disabled due to it racing
with the PM suspend/resume code. This causes a splat in the interrupt
handler when it tries to call pm_runtime_get().

Explicitly disable the interrupt in our ->suspend callback, and
re-enable it in ->resume to avoid this. If there is an interrupt pending
it will be handled after resuming. The interrupt is a wake_irq, as a
result even when disabled if it fires it will cause the system to wake
from suspend as well as cancel any suspend transition that may be in
progress. If there is an interrupt pending, the ipa_isr_thread handler
will be called after resuming.

Fixes: 1aac309d3207 ("net: ipa: use autosuspend")
Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
Reviewed-by: Alex Elder <elder@linaro.org>
Link: https://lore.kernel.org/r/20230115175925.465918-1-caleb.connolly@linaro.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ipa/ipa_interrupt.c
drivers/net/ipa/ipa_interrupt.h
drivers/net/ipa/ipa_power.c