]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
dyndbg: refine export, rename to dynamic_debug_exec_queries()
authorJim Cromie <jim.cromie@gmail.com>
Mon, 31 Aug 2020 18:22:09 +0000 (12:22 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 4 Sep 2020 15:21:56 +0000 (17:21 +0200)
commita2d375eda771a6a4866f3717a8ed81b63acb1dbd
tree6d582aa584c9e8f474fda0a9ef6664a2e39ba4c9
parentb52a95eac112f6f21f0c93987c0bbf3e91bfbf88
dyndbg: refine export, rename to dynamic_debug_exec_queries()

commit 4c0d77828d4f ("dyndbg: export ddebug_exec_queries") had a few
problems:
 - broken non DYNAMIC_DEBUG_CORE configs, sparse warning
 - the exported function modifies query string, breaks on RO strings.
 - func name follows internal convention, shouldn't be exposed as is.

1st is fixed in header with ifdefd function prototype or stub defn.
Also remove an obsolete HAVE-symbol ifdef-comment, and add others.

Fix others by wrapping existing internal function with a new one,
named in accordance with module-prefix naming convention, before
export hits v5.9.0.  In new function, copy query string to a local
buffer, so users can pass hard-coded/RO queries, and internal function
can be used unchanged.

Fixes: 4c0d77828d4f ("dyndbg: export ddebug_exec_queries")
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Link: https://lore.kernel.org/r/20200831182210.850852-3-jim.cromie@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/linux/dynamic_debug.h
lib/dynamic_debug.c