]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
bna: avoid writing uninitialized data into hw registers
authorArnd Bergmann <arnd@arndb.de>
Thu, 23 Mar 2017 16:07:26 +0000 (17:07 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 24 Mar 2017 19:49:12 +0000 (12:49 -0700)
commita5af83925363eb85d467933e3d6ec5a87001eb7c
treeaca30e24531bdf7fddace81ede204bf98d799a48
parent1f3466a0538cde69b03f2aba13e6da72208e56cd
bna: avoid writing uninitialized data into hw registers

The latest gcc-7 snapshot warns about bfa_ioc_send_enable/bfa_ioc_send_disable
writing undefined values into the hardware registers:

drivers/net/ethernet/brocade/bna/bfa_ioc.c: In function 'bfa_iocpf_sm_disabling_entry':
arch/arm/include/asm/io.h:109:22: error: '*((void *)&disable_req+4)' is used uninitialized in this function [-Werror=uninitialized]
arch/arm/include/asm/io.h:109:22: error: '*((void *)&disable_req+8)' is used uninitialized in this function [-Werror=uninitialized]

The two functions look like they should do the same thing, but only one
of them initializes the time stamp and clscode field. The fact that we
only get a warning for one of the two functions seems to be arbitrary,
based on the inlining decisions in the compiler.

To address this, I'm making both functions do the same thing:

- set the clscode from the ioc structure in both
- set the time stamp from ktime_get_real_seconds (which also
  avoids the signed-integer overflow in 2038 and extends the
  well-defined behavior until 2106).
- zero-fill the reserved field

Fixes: 8b230ed8ec96 ("bna: Brocade 10Gb Ethernet device driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/brocade/bna/bfa_ioc.c