]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
drm/shmem-helper: Fix locking for drm_gem_shmem_get_pages_sgt()
authorAsahi Lina <lina@asahilina.net>
Sun, 5 Feb 2023 12:51:24 +0000 (21:51 +0900)
committerJavier Martinez Canillas <javierm@redhat.com>
Fri, 10 Feb 2023 12:13:44 +0000 (13:13 +0100)
commitaa8c85affe3facd3842c8912186623415931cc72
tree711df7b21663299a43a5f58040833e7cdd55caf0
parent7c18189b14b33c1fbf76480b1bd217877c086e67
drm/shmem-helper: Fix locking for drm_gem_shmem_get_pages_sgt()

Other functions touching shmem->sgt take the pages lock, so do that here
too. drm_gem_shmem_get_pages() & co take the same lock, so move to the
_locked() variants to avoid recursive locking.

Discovered while auditing locking to write the Rust abstractions.

Fixes: 2194a63a818d ("drm: Add library for shmem backed GEM objects")
Fixes: 4fa3d66f132b ("drm/shmem: Do dma_unmap_sg before purging pages")
Signed-off-by: Asahi Lina <lina@asahilina.net>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230205125124.2260-1-lina@asahilina.net
drivers/gpu/drm/drm_gem_shmem_helper.c