]> git.proxmox.com Git - mirror_qemu.git/commit
Add G_GNUC_PRINTF to function qemu_set_info_str and fix related issues
authorStefan Weil via <qemu-devel@nongnu.org>
Sat, 26 Nov 2022 15:25:07 +0000 (16:25 +0100)
committerStefan Hajnoczi <stefanha@redhat.com>
Sun, 27 Nov 2022 18:36:17 +0000 (13:36 -0500)
commitac149498215809bfb5c0ddce1953519fbfda5004
tree713ff1144e702ba0059a7e81d6a586d429bd4646
parentec09f22d01d1e59a42f0a5d4f02c325e03df3bc6
Add G_GNUC_PRINTF to function qemu_set_info_str and fix related issues

With the G_GNUC_PRINTF function attribute the compiler detects
two potential insecure format strings:

../../../net/stream.c:248:31: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
    qemu_set_info_str(&s->nc, uri);
                              ^~~
../../../net/stream.c:322:31: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
    qemu_set_info_str(&s->nc, uri);
                              ^~~

There are also two other warnings:

../../../net/socket.c:182:35: warning: zero-length gnu_printf format string [-Wformat-zero-length]
  182 |         qemu_set_info_str(&s->nc, "");
      |                                   ^~
../../../net/stream.c:170:35: warning: zero-length gnu_printf format string [-Wformat-zero-length]
  170 |         qemu_set_info_str(&s->nc, "");

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20221126152507.283271-7-sw@weilnetz.de>
include/net/net.h
net/socket.c
net/stream.c