]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net: ethernet: mtk_eth_soc: fix state in __mtk_foe_entry_clear
authorDaniel Golle <daniel@makrotopia.org>
Fri, 30 Sep 2022 00:56:53 +0000 (01:56 +0100)
committerJakub Kicinski <kuba@kernel.org>
Sat, 1 Oct 2022 02:05:38 +0000 (19:05 -0700)
commitae3ed15da5889263de372ff9df2e83e16acca4cb
treea29c641743211a61841af4d630297a80c86a0627
parent0bafedc536499a533dd7a94c9c980d53f3ca2afc
net: ethernet: mtk_eth_soc: fix state in __mtk_foe_entry_clear

Setting ib1 state to MTK_FOE_STATE_UNBIND in __mtk_foe_entry_clear
routine as done by commit 0e80707d94e4c8 ("net: ethernet: mtk_eth_soc:
fix typo in __mtk_foe_entry_clear") breaks flow offloading, at least
on older MTK_NETSYS_V1 SoCs, OpenWrt users have confirmed the bug on
MT7622 and MT7621 systems.
Felix Fietkau suggested to use MTK_FOE_STATE_INVALID instead which
works well on both, MTK_NETSYS_V1 and MTK_NETSYS_V2.

Tested on MT7622 (Linksys E8450) and MT7986 (BananaPi BPI-R3).

Suggested-by: Felix Fietkau <nbd@nbd.name>
Fixes: 0e80707d94e4c8 ("net: ethernet: mtk_eth_soc: fix typo in __mtk_foe_entry_clear")
Fixes: 33fc42de33278b ("net: ethernet: mtk_eth_soc: support creating mac address based offload entries")
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Link: https://lore.kernel.org/r/YzY+1Yg0FBXcnrtc@makrotopia.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mediatek/mtk_ppe.c