]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
rtnetlink: call validate_linkmsg in rtnl_create_link
authorXin Long <lucien.xin@gmail.com>
Wed, 31 May 2023 16:01:42 +0000 (12:01 -0400)
committerJakub Kicinski <kuba@kernel.org>
Thu, 1 Jun 2023 16:59:43 +0000 (09:59 -0700)
commitb0ad3c179059089d809b477a1d445c1183a7b8fe
tree87dea0eba34721617fdedfba7509c744b13b4cbc
parentabaf8d51b0cedb16af51fb6b2189370d7515977c
rtnetlink: call validate_linkmsg in rtnl_create_link

validate_linkmsg() was introduced by commit 1840bb13c22f5b ("[RTNL]:
Validate hardware and broadcast address attribute for RTM_NEWLINK")
to validate tb[IFLA_ADDRESS/BROADCAST] for existing links. The same
check should also be done for newly created links.

This patch adds validate_linkmsg() call in rtnl_create_link(), to
avoid the invalid address set when creating some devices like:

  # ip link add dummy0 type dummy
  # ip link add link dummy0 name mac0 address 01:02 type macsec

Fixes: 0e06877c6fdb ("[RTNETLINK]: rtnl_link: allow specifying initial device address")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/rtnetlink.c